Bug#888055: ikiwiki: Fenced code block rendering has been broken
Control: tags -1 + fixed-upstream pending On Mon, 29 Jan 2018 at 17:56:00 +, Gabriel Filion wrote: > Simon McVittie: > > You're right that fenced code blocks are documented as being activated > > by the MKD_FENCEDCODE flag, but we've never passed that flag to Discount > > anyway, and they apparently worked in the past. That makes me wonder > > whether this was an incompatible change in the Discount library or in > > libtext-markdown-discount-perl, rather than in ikiwiki. Yes, it looks like this was an incompatible change in the Discount library. > It's annoying that there's no way to re-enable the fenced code blocks > through ikiwiki though I've applied a patch for this upstream, although it's fairly horrible: the correct API for doing this isn't bound in Text::Markdown::Discount. I'll include that in the next upload to Debian. I assume we want them enabled unconditionally, rather than having an option for it like we do for alphabetically-labelled ordered lists. http://source.ikiwiki.branchable.com/?p=source.git;a=commitdiff;h=f46e429d96ead32943cb2670d7686df8c77de361;hp=400f37967ccca314a052cb3eef7e2863a91ca477 Regards, smcv
Bug#888055: ikiwiki: Fenced code block rendering has been broken
Simon McVittie: >> [Fenced code blocks were] activated by an option when ikiwiki was >> calling discount, and >> for some reason that option was removed. So all fenced code block >> rendering was completely broken by that change. > You seem very sure that this was caused by an ikiwiki change. Can you > point to that change in ikiwiki.git? > > You're right that fenced code blocks are documented as being activated > by the MKD_FENCEDCODE flag, but we've never passed that flag to Discount > anyway, and they apparently worked in the past. That makes me wonder > whether this was an incompatible change in the Discount library or in > libtext-markdown-discount-perl, rather than in ikiwiki. oh you're right I was probably just confused about what had actually changed. It's annoying that there's no way to re-enable the fenced code blocks through ikiwiki though :\ signature.asc Description: OpenPGP digital signature
Bug#888055: ikiwiki: Fenced code block rendering has been broken
On Mon, 22 Jan 2018 at 18:48:39 -0500, Gabriel Filion wrote: > I'm wondering why that was removed without any means to bring it back. Not deliberately. As far as I can tell, ikiwiki has never gone to any particular effort to either enable or disable fenced code blocks, so whatever Text::Markdown::Discount does by default, that's the rendering ikiwiki will get. > [Fenced code blocks were] activated by an option when ikiwiki was > calling discount, and > for some reason that option was removed. So all fenced code block > rendering was completely broken by that change. You seem very sure that this was caused by an ikiwiki change. Can you point to that change in ikiwiki.git? You're right that fenced code blocks are documented as being activated by the MKD_FENCEDCODE flag, but we've never passed that flag to Discount anyway, and they apparently worked in the past. That makes me wonder whether this was an incompatible change in the Discount library or in libtext-markdown-discount-perl, rather than in ikiwiki. Looking at https://anonscm.debian.org/cgit/collab-maint/discount.git/log/?id=refs/heads/upstream it seems fenced code blocks might have changed from "configured at compile time, on by default" to "configured at runtime, off by default" in version 2.2.0. I suspect you observed this bug after upgrading from Debian 8 'jessie' to Debian 9 'stretch'. Please could you try downgrading the libmarkdown2 library from stretch's version 2.2.2-1 to jessie's version 2.1.7-1, and see whether fenced code blocks come back? smcv
Bug#888055: ikiwiki: Fenced code block rendering has been broken
Package: ikiwiki Version: 3.20170111 Severity: normal Hello, I've been using fenced code blocks for a while since I usually post about technical issues or howtos. That used to be available in Discount, used through ikiwiki, with a line that contains only a set of more than three ~ characters above and another one below the code block. That was activated by an option when ikiwiki was calling discount, and for some reason that option was removed. So all fenced code block rendering was completely broken by that change. Discount can have that feature enabled by an environment variable, so I've tried specifying that variable in the environment variables in my wiki's .setup file but that unfortunately didn't bring fenced code blocks back. Apparently the only way to re-enable the missing option is to patch ikiwiki. I'm wondering why that was removed without any means to bring it back. I'd very much like to be able to re-enable fenced code blocks. -- System Information: Debian Release: 9.3 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores) Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.utf8), LANGUAGE=en_CA:en (charmap=UTF-8) (ignored: LC_ALL set to en_CA.utf8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages ikiwiki depends on: ii libhtml-parser-perl 3.72-3 ii libhtml-scrubber-perl 0.15-1 ii libhtml-template-perl 2.95-2 ii libjson-perl2.90-1 ii libtext-markdown-discount-perl 0.11-1+b3 ii liburi-perl 1.71-1 ii libyaml-libyaml-perl0.63-2 ii perl5.24.1-3+deb9u2 Versions of packages ikiwiki recommends: ii gcc [c-compiler] 4:6.3.0-4 ii gcc-6 [c-compiler] 6.3.0-18 ii git [git-core] 1:2.11.0-3+deb9u2 ii libauthen-passphrase-perl0.008-2 ii libc6-dev [libc-dev] 2.24-11+deb9u1 ii libcgi-formbuilder-perl 3.10-1 ii libcgi-pm-perl 4.35-1 ii libcgi-session-perl 4.48-3 ii libcrypt-ssleay-perl 0.73.04-2 ii libgravatar-url-perl 1.07-1 ii liblwpx-paranoidagent-perl 1.12-1 ii libmail-sendmail-perl0.79.16-2 ii libnet-openid-consumer-perl 1.18-1 ii librpc-xml-perl 0.80-1 ii libterm-readline-gnu-perl1.35-1 ii libtimedate-perl 2.3000-2 ii libxml-simple-perl 2.22-1 Versions of packages ikiwiki suggests: pn dvipng ii file 1:5.30-1+deb9u1 pn gettext pn ghostscript pn graphviz pn libfile-mimeinfo-perl pn libhighlight-perl ii libhtml-tree-perl 5.03-2 pn libimage-magick-perl | perlmagick ii liblocale-gettext-perl 1.07-3+b1 pn libmagickcore-extra ii libmailtools-perl 2.18-1 pn libnet-amazon-s3-perl pn libnet-inet6glue-perl pn libsearch-xapian-perl ii libsort-naturally-perl 1.03-1 pn libsparkline-php pn libtext-csv-perl ii libtext-multimarkdown-perl 1.35-1 pn libtext-textile-perl pn libtext-typography-perl pn libtext-wikicreole-perl pn libtext-wikiformat-perl pn libxml-feed-perl pn libxml-writer-perl pn po4a pn polygen ii python 2.7.13-2 ii python-docutils0.13.1+dfsg-2 pn texlive pn tidy pn viewvc | gitweb | viewcvs pn xapian-omega -- no debconf information
