Bug#888312: RFS: streamlink/0.10.0+dfsg-1

2018-01-25 Thread Paul Wise 
On Thu, 2018-01-25 at 22:35 +0100, Alexis Murzeau wrote:

> Without this override, dh_installchangelogs uses "docs/changelog.rst"
> instead, which contains only an include statement and not the actual
> content (see diffoscope in attachment)
> 
> According to its sources, dh_installchangelogs iterates ".", "doc/",
> "docs/" directories in this order and takes the last found. Only if
> there are several matches in a given directory, it takes the first
> one found in that directory.

I see, thanks for the explanation. Seems I misread the code :)

> I've added a comment about that on top of
> override_dh_installchangelogs.

Great.

> Do you think there is something better to do here ?

Maybe debhelper could be smarter about not choosing tiny changelog
files over larger files, but you would still need the override for
older suites.

If it doesn't already, it would be a good idea for lintian to check
that the upstream changelog file is a sane one; it should have a
version number in it and not be too tiny.

If you would like to do some more research and file bugs for these,
that would be appreciated.

> The python3-iso3166 package is indeed available, the missing one is
> iso639 which I miss-written. When not using pycountry, streamlink
> need both iso3166 and iso639 python packages.
> I updated the comment with python3-iso639 instead of python3-iso3166.

I see, great.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part

Bug#888312: RFS: streamlink/0.10.0+dfsg-1

2018-01-25 Thread Alexis Murzeau 
Le 25/01/2018 à 07:47, Paul Wise a écrit :
> On Thu, Jan 25, 2018 at 5:26 AM, Alexis Murzeau wrote:
> 
>> I am looking for a sponsor for my package "streamlink" for a new
>> upstream version 0.10.0.
> 
> Uploaded.

Thanks :)

> 
> Some things that would be nice to fix at some point:
> 
> I'm surprised override_dh_installchangelogs is needed, the code seems
> like it would match CHANGELOG.rst. Please build the package twice,
> once with it and once without and then diffoscope the resulting binary
> packages.

Without this override, dh_installchangelogs uses "docs/changelog.rst"
instead, which contains only an include statement and not the actual
content (see diffoscope in attachment)

According to its sources, dh_installchangelogs iterates ".", "doc/",
"docs/" directories in this order and takes the last found. Only if
there are several matches in a given directory, it takes the first one
found in that directory.

I've added a comment about that on top of override_dh_installchangelogs.

Do you think there is something better to do here ?

> 
> There is an incorrect statement in debian/rules, Debian has the
> python3-iso3166 package.

The python3-iso3166 package is indeed available, the missing one is
iso639 which I miss-written. When not using pycountry, streamlink need
both iso3166 and iso639 python packages.
I updated the comment with python3-iso639 instead of python3-iso3166.

> 
> Some grammar fixes for debian/rules:
> 
> s/need to have/needs to have/
> s/Debian have/Debian has/

Thanks, updated.

> 
> In future, I would suggest not mentioning check-all-the-things (or
> lintian) in debian/changelog and instead mention what was fixed.

ok

> 
> I would suggest using this as the donation link, since it won't go out
> of date if they switch away from OpenCollective. It also mentions
> Bountysource and individual team member donations.
> 
> https://streamlink.github.io/donate.html

Indeed, I will update to this one, thanks.

> 
> I saw in the upstream code that they are manually building some URLs
> with string concatenation. I think it would be much better to use a
> URL class that knows how to encode parameters etc.
> 

ok I will investigate this.

-- 
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F
--- streamlink_0.10.0+dfsg-1_all.deb
+++ streamlink_0.10.0+dfsg-2_all.deb
├── file list
│ @@ -1,3 +1,3 @@
│ --rw-r--r--   0004 2018-01-23 22:55:45.00 
debian-binary
│ --rw-r--r--   000 1632 2018-01-23 22:55:45.00 
control.tar.xz
│ --rw-r--r--   00053948 2018-01-23 22:55:45.00 
data.tar.xz
│ +-rw-r--r--   0004 2018-01-25 18:47:31.00 
debian-binary
│ +-rw-r--r--   000 1636 2018-01-25 18:47:31.00 
control.tar.xz
│ +-rw-r--r--   00034624 2018-01-25 18:47:31.00 
data.tar.xz
├── control.tar.xz
│ ├── control.tar
│ │ ├── file list
│ │ │ @@ -1,5 +1,5 @@
│ │ │ -drwxr-xr-x   0 root (0) root (0)0 2018-01-23 
22:55:45.00 ./
│ │ │ --rw-r--r--   0 root (0) root (0)  801 2018-01-23 
22:55:45.00 ./control
│ │ │ --rw-r--r--   0 root (0) root (0) 1533 2018-01-23 
22:55:45.00 ./md5sums
│ │ │ --rwxr-xr-x   0 root (0) root (0)  191 2018-01-23 
22:55:45.00 ./postinst
│ │ │ --rwxr-xr-x   0 root (0) root (0)  395 2018-01-23 
22:55:45.00 ./prerm
│ │ │ +drwxr-xr-x   0 root (0) root (0)0 2018-01-25 
18:47:31.00 ./
│ │ │ +-rw-r--r--   0 root (0) root (0)  801 2018-01-25 
18:47:31.00 ./control
│ │ │ +-rw-r--r--   0 root (0) root (0) 1533 2018-01-25 
18:47:31.00 ./md5sums
│ │ │ +-rwxr-xr-x   0 root (0) root (0)  191 2018-01-25 
18:47:31.00 ./postinst
│ │ │ +-rwxr-xr-x   0 root (0) root (0)  395 2018-01-25 
18:47:31.00 ./prerm
│ │ ├── ./control
│ │ │ @@ -1,13 +1,13 @@
│ │ │  Package: streamlink
│ │ │ -Version: 0.10.0+dfsg-1
│ │ │ +Version: 0.10.0+dfsg-2
│ │ │  Architecture: all
│ │ │  Maintainer: Alexis Murzeau 
│ │ │ -Installed-Size: 151
│ │ │ -Depends: python3:any (>= 3.4~), python3-streamlink (= 0.10.0+dfsg-1)
│ │ │ +Installed-Size: 133
│ │ │ +Depends: python3:any (>= 3.4~), python3-streamlink (= 0.10.0+dfsg-2)
│ │ │  Section: video
│ │ │  Priority: optional
│ │ │  Homepage: https://streamlink.github.io/
│ │ │  Description: CLI for extracting video streams from various websites to a 
video player
│ │ │   Streamlink is a CLI utility that pipes flash videos from online 
streaming
│ │ │   services to a variety of video players such as VLC, or alternatively, a
│ │ │   browser.
│ │ ├── ./md5sums
│ │ │ ├── ./md5sums
│ │ │ │┄ Files differ
├── data.tar.xz
│ ├── data.tar
│ │ ├── file list
│ │ │ @@ -1,33 +1,33 @@
│ │ │ -drwxr-xr-x   0 root (0) root (0)0 2018-01-23 
22:55:45.00 ./
│ │ │

Bug#888312: RFS: streamlink/0.10.0+dfsg-1

2018-01-24 Thread Paul Wise 
On Thu, Jan 25, 2018 at 5:26 AM, Alexis Murzeau wrote:

> I am looking for a sponsor for my package "streamlink" for a new
> upstream version 0.10.0.

Uploaded.

Some things that would be nice to fix at some point:

I'm surprised override_dh_installchangelogs is needed, the code seems
like it would match CHANGELOG.rst. Please build the package twice,
once with it and once without and then diffoscope the resulting binary
packages.

There is an incorrect statement in debian/rules, Debian has the
python3-iso3166 package.

Some grammar fixes for debian/rules:

s/need to have/needs to have/
s/Debian have/Debian has/

In future, I would suggest not mentioning check-all-the-things (or
lintian) in debian/changelog and instead mention what was fixed.

I would suggest using this as the donation link, since it won't go out
of date if they switch away from OpenCollective. It also mentions
Bountysource and individual team member donations.

https://streamlink.github.io/donate.html

I saw in the upstream code that they are manually building some URLs
with string concatenation. I think it would be much better to use a
URL class that knows how to encode parameters etc.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Bug#888312: RFS: streamlink/0.10.0+dfsg-1

2018-01-24 Thread Alexis Murzeau 
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "streamlink" for a new
upstream version 0.10.0.

 * Package name: streamlink
   Version : 0.10.0+dfsg-1
   Upstream Author : Streamlink Team
 * URL : https://streamlink.github.io/
 * License : BSD-2-clause, Apache-2.0, MIT/Expat, SIL-OFL-1.1
   Section : python

It builds those binary packages:

  livestreamer - transitional package - streamlink
  python3-streamlink - Python module for extracting video streams from
various websites
  python3-streamlink-doc - CLI for extracting video streams from various
websites (documenta
  streamlink - CLI for extracting video streams from various websites to
a video

To access further information about this package, please visit the
following URL:
  https://mentors.debian.net/package/streamlink


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/s/streamlink/streamlink_0.10.0+dfsg-1.dsc

More information about hello can be obtained from
https://streamlink.github.io/

Changes since the last upload:
streamlink (0.10.0+dfsg-1) unstable; urgency=low

  * Bump standard version to 4.1.3, no change required
  * Bump debhelper compat to 11
  * Add upstream metadata in d/u/metadata
  * Add information about binary packages in d/README.source
  * Add autopkgtest tests running streamlink via cli
  * Remove dh_builddeb override, not needed in Debian
  * Update d/copyrights to 2018
  * Remove proxy in d/rules (already handled by pybuild)
  * Fix bad git repository in VCS fields of d/control
  * New upstream version 0.10.0+dfsg
  * Apply check-all-the-things suggestions on debian/ folder

 -- Alexis Murzeau   Tue, 23 Jan 2018 23:55:45 +0100

Regards,
--
 Alexis Murzeau
 PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F





signature.asc
Description: OpenPGP digital signature