Bug#890823: Modification to /etc/tmpfiles.d/screen-cleanup.conf not preserved on upgrade
Control: tag -1 + pending Dear Laurent, Laurent Bigonville wrote: > Looking in the postinst script I realized it was created by the package > iself. Correct. > If I'm not wrong, the package is not preserving the changes to that file > on upgrade. I think that's not true. From 4.6.2-3's screen.postinst (comments are just for highlighting lines in this mail): override=/etc/tmpfiles.d/screen-cleanup.conf if [ $perms -eq 4755 ]; then chmod 0755 /run/screen if [ ! -f $override ]; then # < check! echo 'd /run/screen 0755 root utmp' > $override fi elif [ $perms -eq 755 ]; then chmod 1777 /run/screen if [ ! -f $override ]; then # < check! echo 'd /run/screen 1777 root utmp' > $override fi fi So it only writes this file if it doesn't yet exist. And according to "git blame" the highlighted lines are in there since at least 2015-06-16. > Also, some comments on the top of the file should mention that the > file has been created by the package Good idea! Will be done with the next upload! Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Bug#890823: Modification to /etc/tmpfiles.d/screen-cleanup.conf not preserved on upgrade
Package: screen Version: 4.6.2-1 Severity: important Hi, Today I saw that there was a screen-cleanup.conf file in /etc/tmpfiles.d/ that I didn't remember creating. Looking in the postinst script I realized it was created by the package iself. If I'm not wrong, the package is not preserving the changes to that file on upgrade. I don't think this is a policy violation but this seems not good either. Also, some comments on the top of the file should mention that the file has been created by the package (and maybe that the file is not preserved). Kind regards, Laurent Bigonville -- System Information: Debian Release: buster/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: SELinux: enabled - Mode: Permissive - Policy name: refpolicy Versions of packages screen depends on: ii libc6 2.26-6 ii libpam0g 1.1.8-3.7 ii libtinfo5 6.1-1 ii libutempter0 1.1.6-3 screen recommends no packages. Versions of packages screen suggests: pn byobu | screenie | iselect ii ncurses-term6.1-1 -- no debconf information
