Bug#890878: RFS: company-irony
Hi Alberto, It's been a long time without a reply to this RFS. Would you please provide a status update? Thanks! Nicholas signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Oops, that last link was supposed to be https://github.com/Sarcasm/irony-mode/issues/172 signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Hi Alberto, On Wed, Mar 14, 2018 at 12:39:44PM -0400, Nicholas D Steeves wrote: > Hi Alberto, > > On Wed, Mar 14, 2018 at 09:34:07AM +0100, Alberto Luaces wrote: > > > > Because for now the most pressing issue is that it doesn't initialise > > > properly... > > > > > > Company backend 'company-clang' could not be initialized: > > > Company found no clang executable > > > > > > This was both with no configuration (and M-x company-mode), and with > > > following upstream's README in a clean sid chroot. I opened a random > > > cpp from kdeconnect to test. I suspect a documentation of > > > configuration issue because I would have expected company-irony to > > > load rather than company-clang...but it's possibly a bug. > > > > > > Please let me know how you made company-irony work. > > > > Oh, yes, I think this is expected. From the documentation at > > > > /usr/share/doc/elpa-company-irony/README.md > > > > --8<---cut here---start->8--- > > > > ## Configuration > > > > Add `company-irony` to your company backends. > > > > ~~~el > > (eval-after-load 'company > > '(add-to-list 'company-backends 'company-irony)) > > ~~~ > > > > --8<---cut here---end--->8--- > > This is exactly one of the two things that I tried. To be fair, > company-irony's autocomplete seems to function properly despite this > :-) > > Could you patch README.md to show how to remove company-clang from > company-backends, and also document that this warning is harmless (if > it's harmless). Any progress on this? In pseudo code: eval company-backends to check if company-clang is an element if non nil (eg: if the company-clang element exists) remove company-clang from company-backends (add-to-list 'company-backends 'company-irony) Justification: company-clang and company-irony should not be used at the same time, and company-irony replaces company-clang. Also, here are some resources for patching the upstream description and for improving the Debian description: https://www.reddit.com/r/emacs/comments/26cxgl/fastest_c_completion_system/ https://github.com/Sarcasm/company-irony/issues/33 https://github.com/Sarcasm/company-irony/issues/33 Happy hacking, Nicholas signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Hi Alberto, On Wed, Mar 14, 2018 at 09:34:07AM +0100, Alberto Luaces wrote: > >> > I: company-irony source: testsuite-autopkgtest-missing > >> > >> This is N/A, I think. > > > > It's not required at this point in time, but someday it's possible > > that self tests will be required. Dh_elpa_test runs the tests as part > > of a package build, and autopkgtest is a framework that automates > > testing of packages in a container or virtual machine. Because this > > is Informational level lint it's not high priority for Lintian, but if > > you ever want to write a test that gets an company-irony autocompleted > > list for something, and then compares that against the expected list, > > in the expected order. Tests that provide assurances it won't do > > hilarious/embarrassing autocompletion like cell phones do. A Nice to > > have, later, if you have time and find the challenge interesting ;-) > > > > Ok. I don't have currently the skills for writing those tests, but > maybe in the future I can try to learn from some other packages. Sounds good! :-) > > Because for now the most pressing issue is that it doesn't initialise > > properly... > > > > Company backend 'company-clang' could not be initialized: > > Company found no clang executable > > > > This was both with no configuration (and M-x company-mode), and with > > following upstream's README in a clean sid chroot. I opened a random > > cpp from kdeconnect to test. I suspect a documentation of > > configuration issue because I would have expected company-irony to > > load rather than company-clang...but it's possibly a bug. > > > > Please let me know how you made company-irony work. > > Oh, yes, I think this is expected. From the documentation at > > /usr/share/doc/elpa-company-irony/README.md > > --8<---cut here---start->8--- > > ## Configuration > > Add `company-irony` to your company backends. > > ~~~el > (eval-after-load 'company > '(add-to-list 'company-backends 'company-irony)) > ~~~ > > --8<---cut here---end--->8--- This is exactly one of the two things that I tried. To be fair, company-irony's autocomplete seems to function properly despite this :-) Could you patch README.md to show how to remove company-clang from company-backends, and also document that this warning is harmless (if it's harmless). Thanks! Nicholas signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Hi Nicholas, Nicholas D Steeves writes: [...] Thanks again for your advice! >> > I: company-irony source: testsuite-autopkgtest-missing >> >> This is N/A, I think. > > It's not required at this point in time, but someday it's possible > that self tests will be required. Dh_elpa_test runs the tests as part > of a package build, and autopkgtest is a framework that automates > testing of packages in a container or virtual machine. Because this > is Informational level lint it's not high priority for Lintian, but if > you ever want to write a test that gets an company-irony autocompleted > list for something, and then compares that against the expected list, > in the expected order. Tests that provide assurances it won't do > hilarious/embarrassing autocompletion like cell phones do. A Nice to > have, later, if you have time and find the challenge interesting ;-) > Ok. I don't have currently the skills for writing those tests, but maybe in the future I can try to learn from some other packages. [...] > > Because for now the most pressing issue is that it doesn't initialise > properly... > > Company backend 'company-clang' could not be initialized: > Company found no clang executable > > This was both with no configuration (and M-x company-mode), and with > following upstream's README in a clean sid chroot. I opened a random > cpp from kdeconnect to test. I suspect a documentation of > configuration issue because I would have expected company-irony to > load rather than company-clang...but it's possibly a bug. > > Please let me know how you made company-irony work. Oh, yes, I think this is expected. From the documentation at /usr/share/doc/elpa-company-irony/README.md --8<---cut here---start->8--- ## Configuration Add `company-irony` to your company backends. ~~~el (eval-after-load 'company '(add-to-list 'company-backends 'company-irony)) ~~~ --8<---cut here---end--->8--- Regards, Alberto
Bug#890878: RFS: company-irony
Hi Alberto, On Thu, Mar 08, 2018 at 05:10:13PM +0100, Alberto Luaces wrote: > Thanks again, Nicholas: You're welcome :-) > Nicholas D Steeves writes: > > > W: company-irony source: out-of-date-standards-version 4.1.1 (current is > > 4.1.3) > > Ok. Upgraded to 4.1.3 while checking that it complains with the Policy > upgrades: basically none of them applied, except for the Vcs-* one, that > this package is already compliant with. Nice, that's exactly how it's done. > > I: company-irony source: testsuite-autopkgtest-missing > > This is N/A, I think. It's not required at this point in time, but someday it's possible that self tests will be required. Dh_elpa_test runs the tests as part of a package build, and autopkgtest is a framework that automates testing of packages in a container or virtual machine. Because this is Informational level lint it's not high priority for Lintian, but if you ever want to write a test that gets an company-irony autocompleted list for something, and then compares that against the expected list, in the expected order. Tests that provide assurances it won't do hilarious/embarrassing autocompletion like cell phones do. A Nice to have, later, if you have time and find the challenge interesting ;-) > > W: elpa-company-irony: new-package-should-close-itp-bug > > Now I have a number assigned. Thank you. > > I: elpa-company-irony: extended-description-is-probably-too-short > > Ok. Rephrased. I'll reply to points relating to the description with a couple of comments later. Because for now the most pressing issue is that it doesn't initialise properly... Company backend 'company-clang' could not be initialized: Company found no clang executable This was both with no configuration (and M-x company-mode), and with following upstream's README in a clean sid chroot. I opened a random cpp from kdeconnect to test. I suspect a documentation of configuration issue because I would have expected company-irony to load rather than company-clang...but it's possibly a bug. Please let me know how you made company-irony work. Cheers, Nicholas signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Thanks again, Nicholas: Nicholas D Steeves writes: > W: company-irony source: out-of-date-standards-version 4.1.1 (current is > 4.1.3) Ok. Upgraded to 4.1.3 while checking that it complains with the Policy upgrades: basically none of them applied, except for the Vcs-* one, that this package is already compliant with. > I: company-irony source: testsuite-autopkgtest-missing This is N/A, I think. > W: elpa-company-irony: new-package-should-close-itp-bug Now I have a number assigned. > I: elpa-company-irony: extended-description-is-probably-too-short Ok. Rephrased. Regards, Alberto
Bug#890878: RFS: company-irony
On Thu, Mar 01, 2018 at 11:15:45AM +0100, Alberto Luaces wrote: > Nicholas D Steeves writes: > > [...] > > > > Thanks for the tips! You're welcome! > > debian/copyright: [...] > > I went the route of adding the email address, but of course it can be > changed at any time. Looks good. > > debian/gbp.conf: [...] > Ok, I pushed a "upstream" branch and all of its tags, so gbp should not > choke this time. Looks good. > > debian/watch: [...] > I think I managed to get one working, from reading other packages and > the uscan manpage. Looks good. For future reference, you can test a watch file with: uscan -v --no-download This package also has some lint that needs to be taken care of. It's a good idea to run lintian after building a package, and you should configure whatever builder you're using to do this automatically. W: company-irony source: out-of-date-standards-version 4.1.1 (current is 4.1.3) I: company-irony source: testsuite-autopkgtest-missing W: elpa-company-irony: new-package-should-close-itp-bug I: elpa-company-irony: extended-description-is-probably-too-short Out-of-date-standards-version is a Warning that should be addressed, and additionally must be addressed for NEW packages. Periodically, when you update your package you'll see this pop up. Once you've done the work to make sure a package is policy-compliant you can use the following checklist to keep it up to date: https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt On this topic, in the next phase of review I'll check if your package installs and functions properly, and also if it is compliant with Policy 4.1.3. https://www.debian.org/doc/debian-policy/ New-package-should-close-itp-bug Warning will need to be addressed before someone will sponsor the upload. Extended-description-is-probably-too-short is Informational, but in this case I think it should be addressed. At a minimum add "for the C, C++ and Objective-C languages" (README.md notes this), and please also read these sections 3.4, 3.4.1, and 3.4.2. It's worth developing a strong habit towards this as early as possible, and I will confess that I need to work on better descriptions for some of my packages. ;-) https://www.debian.org/doc/debian-policy/#the-description-of-a-package Have fun! Nicholas signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Nicholas D Steeves writes: [...] > > Hi Alberto, > > Welcome to the team, and thank you for packaging company-irony! I > consider it a valuable addition to the archive :-) The following > might be something you already know, but if not, here's a neat trick: > > Make your changes, and then while in emacs, M-x magit-status, then d u > (diff unstaged). Stage the changes that are part of one logical > operation with C-, select region, then s (or just s on a hunk to > stage the whole hunk). Finally c c (commit staged), write your commit > message, and finally C-c C-c. Later you can use gbp dch -a [-N > $upstream_version-$debian_revision, if necessary] to generate a nice > changelog. > Thanks for the tips! > > Hi Sean and David, > > I'm willing to do reviews, and want to encourage best practises and our > team's high standards. Please feel free to comment. > > debian/copyright: > Author's email is directly underneath Copyright in > company-irony.el's header. I would either Add it to the Copyright: > for the 'Files: *' section, or add an Upstream-Contact field. ( > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#examples > ) Sean, what's your best practices stance on this? I'm guessing > Upstream-Contact. > I went the route of adding the email address, but of course it can be changed at any time. > > debian/gbp.conf: > gbp:info: Tarballs 'company-irony_1.1.0.orig.tar.xz' not found > gbp:warning: Pristine-tar branch "pristine-tar" not found > gbp:info: Creating > /home/sten/devel/build-area/company-irony_1.1.0.orig.tar.xz > gbp:error: v1.1.0 is not a valid treeish > > Alberto, if you're using pristine-tar you need to push the branch; > alternatively, if you got upstream source from git and are not using > pristine-tar you need to push the upstream tag to our repo and also > modify gbp.conf to indicate you're not using pristine-tar. Also, > for future reference, if you choose the git-only workflow you'll > need to push each new upstream version tag as you update the > package. > Ok, I pushed a "upstream" branch and all of its tags, so gbp should not choke this time. > debian/watch: > Missing, please add one. Between the one for irony-mode (watch > version 3, Guillaume is also the upstream for this one) and > fountain-mode (version 4) you should be able to figure out how to > produce a working v4 one ;-) The only reason I mention > fountain-mode is because it's the one I've checked most recently. > I think I managed to get one working, from reading other packages and the uscan manpage. Regards, Alberto
Bug#890878: RFS: company-irony
On Mon, Feb 26, 2018 at 02:43:51PM -0700, Sean Whitton wrote: > Hello, > > On Mon, Feb 26 2018, Alberto Luaces wrote: > > > I have refreshed those fields. I have not still refreshed the > > changelog date in order to wait for more potential changes. > > Thanks for fixing this. > > I'm not in a position to properly review this package, unfortunately. > Sorry for suggesting in a previous mail that I was planning on doing > that. Just wanted to get the Vcs-* fields fixed. > > -- > Sean Whitton Hi Alberto, Welcome to the team, and thank you for packaging company-irony! I consider it a valuable addition to the archive :-) The following might be something you already know, but if not, here's a neat trick: Make your changes, and then while in emacs, M-x magit-status, then d u (diff unstaged). Stage the changes that are part of one logical operation with C-, select region, then s (or just s on a hunk to stage the whole hunk). Finally c c (commit staged), write your commit message, and finally C-c C-c. Later you can use gbp dch -a [-N $upstream_version-$debian_revision, if necessary] to generate a nice changelog. Hi Sean and David, I'm willing to do reviews, and want to encourage best practises and our team's high standards. Please feel free to comment. debian/copyright: Author's email is directly underneath Copyright in company-irony.el's header. I would either Add it to the Copyright: for the 'Files: *' section, or add an Upstream-Contact field. ( https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#examples ) Sean, what's your best practices stance on this? I'm guessing Upstream-Contact. debian/gbp.conf: gbp:info: Tarballs 'company-irony_1.1.0.orig.tar.xz' not found gbp:warning: Pristine-tar branch "pristine-tar" not found gbp:info: Creating /home/sten/devel/build-area/company-irony_1.1.0.orig.tar.xz gbp:error: v1.1.0 is not a valid treeish Alberto, if you're using pristine-tar you need to push the branch; alternatively, if you got upstream source from git and are not using pristine-tar you need to push the upstream tag to our repo and also modify gbp.conf to indicate you're not using pristine-tar. Also, for future reference, if you choose the git-only workflow you'll need to push each new upstream version tag as you update the package. debian/watch: Missing, please add one. Between the one for irony-mode (watch version 3, Guillaume is also the upstream for this one) and fountain-mode (version 4) you should be able to figure out how to produce a working v4 one ;-) The only reason I mention fountain-mode is because it's the one I've checked most recently. I'll do a more in depth review in the next round. Cheers, Nicholas signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Hello, On Mon, Feb 26 2018, Alberto Luaces wrote: > I have refreshed those fields. I have not still refreshed the > changelog date in order to wait for more potential changes. Thanks for fixing this. I'm not in a position to properly review this package, unfortunately. Sorry for suggesting in a previous mail that I was planning on doing that. Just wanted to get the Vcs-* fields fixed. -- Sean Whitton signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Hi Alberto, On Mon, Feb 26, 2018 at 04:30:02PM +0100, Alberto Luaces wrote: > Sean Whitton writes: > > > Hello, > > > > On Wed, Feb 21 2018, Alberto Luaces wrote: > > > >> Thanks, Sean. It is now located at > >> > >> https://salsa.debian.org/aluaces-guest/company-irony > >> > >> I guess someone else has to clone it under the team project folders, > >> so I created that personal repository first. > > > > You should be able to do it yourself... are you saying that you were > > unable to create a repo under emacsen-team? I just bumped your > > permission level. > > > > Thanks for that. Yes, I think salsa's default permissions for non-DDs > are much more stricter than Alioth were. Nevertheless, I have been able > to create and populate the repository under the Team's group. > > > > > I don't want to upload the package with the wrong Vcs-* headers, so > > let's get this fixed first. > > I have refreshed those fields. I have not still refreshed the changelog > date in order to wait for more potential changes. > Thank you for packaging company-irony! I'd be happy to review your packaging too; although, I can't sponsor the upload. Please ping me if you haven't received an update in the next 48h. ;-) Cheers, Nicholas signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Sean Whitton writes: > Hello, > > On Wed, Feb 21 2018, Alberto Luaces wrote: > >> Thanks, Sean. It is now located at >> >> https://salsa.debian.org/aluaces-guest/company-irony >> >> I guess someone else has to clone it under the team project folders, >> so I created that personal repository first. > > You should be able to do it yourself... are you saying that you were > unable to create a repo under emacsen-team? I just bumped your > permission level. > Thanks for that. Yes, I think salsa's default permissions for non-DDs are much more stricter than Alioth were. Nevertheless, I have been able to create and populate the repository under the Team's group. > > I don't want to upload the package with the wrong Vcs-* headers, so > let's get this fixed first. I have refreshed those fields. I have not still refreshed the changelog date in order to wait for more potential changes.
Bug#890878: RFS: company-irony
Hello, On Wed, Feb 21 2018, Alberto Luaces wrote: > Thanks, Sean. It is now located at > > https://salsa.debian.org/aluaces-guest/company-irony > > I guess someone else has to clone it under the team project folders, > so I created that personal repository first. You should be able to do it yourself... are you saying that you were unable to create a repo under emacsen-team? I just bumped your permission level. I don't want to upload the package with the wrong Vcs-* headers, so let's get this fixed first. -- Sean Whitton signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Sean Whitton writes: > Hello, > > On Tue, Feb 20 2018, Alberto Luaces wrote: > >> I would need someone to sponsor "company-irony", which is now packaged >> and uploaded to Alioth. > > It should be on salsa. alioth is shutting down in a matter of weeks. > > If you request access to https://salsa.debian.org/emacsen-team/ I'll > grant it. Thanks, Sean. It is now located at https://salsa.debian.org/aluaces-guest/company-irony I guess someone else has to clone it under the team project folders, so I created that personal repository first.
Bug#890878: RFS: company-irony
Hello, On Tue, Feb 20 2018, Alberto Luaces wrote: > I would need someone to sponsor "company-irony", which is now packaged > and uploaded to Alioth. It should be on salsa. alioth is shutting down in a matter of weeks. If you request access to https://salsa.debian.org/emacsen-team/ I'll grant it. -- Sean Whitton signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
On Tue, Feb 20, 2018 at 12:52:41PM +0100, Alberto Luaces wrote: > Sorry again for the confusion: the guidelines I followed implied that I > had to fill a RFS Sure, but RFSes should follow a template that includes many things, and you didn't even include the URL where to get the software. -- WBR, wRAR signature.asc Description: PGP signature
Bug#890878: RFS: company-irony
Geert Stappers writes: > On Tue, Feb 20, 2018 at 10:15:37AM +0100, Alberto Luaces wrote: >> I would need someone to sponsor "company-irony", > > What is "company-irony"? > Please tell more about it ( think "try to sell it" ) > Sorry about that: "company" is a completion framework for emacs. "irony" is a completion system for C++. "company-irony" makes irony analysis of the source code available to the company framework, so it makes emacs behave as a sort of IDE for C++. > >> which is now packaged and uploaded to Alioth. > > Where? > Please provide URL ( think "help those you want to help you" ) > It is in the debian-emacsen git repo: https://anonscm.debian.org/git/pkg-emacsen/pkg/company-irony.git/ Sorry again for the confusion: the guidelines I followed implied that I had to fill a RFS, CCing to debian-emacsen. I understand that for other people it can be a bit cryptic. Alberto
Bug#890878: RFS: company-irony
On Tue, Feb 20, 2018 at 10:15:37AM +0100, Alberto Luaces wrote: > I would need someone to sponsor "company-irony", What is "company-irony"? Please tell more about it ( think "try to sell it" ) > which is now packaged and uploaded to Alioth. Where? Please provide URL ( think "help those you want to help you" ) Groeten Geert Stappers -- Leven en laten leven
Bug#890878: RFS: company-irony
Package: sponsorship-requests Severity: normal Hello, I would need someone to sponsor "company-irony", which is now packaged and uploaded to Alioth. Thank you! P.S.: I have followed the guidelines at the dh-make-elpa manpage.
