Bug#891757: package's /etc/udhcpd.conf still mentions obsolete "remaining" option

[Nathan Stratton Treadway]

On Wed, Feb 28, 2018 at 10:36:46 -0500, Nathan Stratton Treadway wrote:
> (Comparing those two files quickly I don't see any other obsolete option
> still listed in the Debian /etc/udhcpd.conf file.)

Actually, looking a little more closely it seems that this
Debian-specific file was copied (essentially unchanged) from the
upstream "examples" version of the file shortly before the
above-mentioned commit 2b0e95780863da44f6a9244699ece8620a599e19, and it
hasn't been updated since.  So perhaps it would make sense just to
distribute the upstream version as Debian's /etc/udhcpd.conf rather than
having a separate copy?

=
$ git diff 
2b0e95780863da44f6a9244699ece8620a599e19^1:examples/udhcp/udhcpd.conf 
HEAD:debian/tree/udhcpd/etc/udhcpd.conf | cat
diff --git 
a/2b0e95780863da44f6a9244699ece8620a599e19^1:examples/udhcp/udhcpd.conf 
b/HEAD:debian/tree/udhcpd/etc/udhcpd.conf
index 8c9a968..672c481 100644
--- a/2b0e95780863da44f6a9244699ece8620a599e19^1:examples/udhcp/udhcpd.conf
+++ b/HEAD:debian/tree/udhcpd/etc/udhcpd.conf
@@ -114,7 +114,7 @@ option  lease   864000  # 10 days of seconds
 #opt ntpsrv
 #opt tftp
 #opt bootfile
-
+#opt wpad
 
 # Static leases map
 #static_lease 00:60:08:11:CE:4E 192.168.0.54
$ git log debian/tree/udhcpd/etc/udhcpd.conf
commit 9f5c542f05969830b28e16d73c2f8af69c742a90
Author: Bastian Blank 
Date:   Sat Nov 7 18:26:56 2009 +

* debian/busybox-syslogd.busybox-klogd.init, debian/busybox-syslogd.default,
  debian/busybox-syslogd.init, debian/busybox-syslogd.links,
  debian/udhcpc.install, debian/udhcpc.links,
  debian/udhcpd.install, debian/udhcpd.links: Add.
* debian/config/deb, debian/config/static: Enable FEATURE_PIDFILE-
* debian/control: Add new binary packages.
* debian/copyright: Fix typo.
* debian/rules: Build new binary packages.
* debian/tree/udhcpc, debian/tree/udhcpd: Add trees.

r61201

=


Nathan

Bug#891757: package's /etc/udhcpd.conf still mentions obsolete "remaining" option

[Nathan Stratton Treadway]

Package: udhcpd 
Version: 1:1.27.2-2

I noticed that the copy of /etc/udhcpd.conf installed by the udhcpd
package includes a section describing the "remaining" option:

=
# If remaining is true (default), udhcpd will store the time
# remaining for each lease in the udhcpd leases file. This is
# for embedded systems that cannot keep time between reboots.
# If you set remaining to no, the absolute time that the lease
# expires at will be stored in the dhcpd.leases file.

#remaining  yes #default: yes
=

However, this option was actually removed from the udhcpd program many
years ago, in commit 0416e3dde17ea9295635c52183b30fe3d7172333  (See,
e.g.:
  
https://git.busybox.net/busybox/commit?id=0416e3dde17ea9295635c52183b30fe3d7172333
or
  
https://anonscm.debian.org/cgit/d-i/busybox.git/commit/?id=0416e3dde17ea9295635c52183b30fe3d7172333
), and from the examples/udhcp/udhcpd.conf file in the upstream source
in commit 2b0e95780863da44f6a9244699ece8620a599e19 .


(Comparing those two files quickly I don't see any other obsolete option
still listed in the Debian /etc/udhcpd.conf file.)


Nathan