Bug#892917: love: use BD on lua OR luajit
Hi James, On Wed, 14 Mar 2018 13:50:04 +, James Cowgill wrote: > Hi, > > On 14/03/18 13:37, Frédéric Bonnard wrote: > > Package: src:love > > Version: 0.9.1-4 > > > > -- > > > > Dear maintainer, > > > > at the moment both liblua5.1-0-dev and libluajit-5.1-dev are required to > > build. I think one or the other exclusively should be enough, and your > > d/rules specifies one or the other already. > > The best being to require first libluajit-5.1-dev if available and > > fallback on liblua5.1-0-dev. > > This way, love will benefit from luajit's speed if possible but will > > build on more architectures as well thanks to lua's portability (that > > should fix the BD-Uninstallable status on some architectures) > > Here is a patch for this. > > Also, ppc64el's support in luajit is unsure in the long term, so with > > the patch, we ensure to be able to still have love on this architecture > > even if luajit drops ppc64el support (and thus fix the current FTBFS : > > https://buildd.debian.org/status/fetch.php?pkg=love&arch=ppc64el&ver=0.9.1-4&stamp=1503721727&raw=0 > > Bear in mind the buildds ignore alternatives in build-dependencies, so > from their perspective, your patch is equivalent to dropping the non-jit > dependency and won't fix any of the BD-Uninstallable architectures. oh.. indeed > I think keeping the current build-dependency on liblua5.1-0-dev but > restricting it to the architectures where luajit is not used should do > what you want. right. Actually the following seems to work as expected : libluajit-5.1-dev [!s390x !alpha !hppa !ia64 !m68k !powerpcspe !sh4 !sparc64] | liblua5.1-0-dev, based on the architectures not supported by luajit at the moment. Regards, F. > > James > pgpzYSKqmPonh.pgp Description: PGP signature
Bug#892917: love: use BD on lua OR luajit
2018-03-14 14:50 UTC+01:00, James Cowgill : > Hi, > > On 14/03/18 13:37, Frédéric Bonnard wrote: >> Package: src:love >> Version: 0.9.1-4 Hi, This package is severly outdated, I know. I put back then a lot of work to upgrade it, but never finished the copyright review. Please import this into Salsa and build uppon if you are interrested. https://anonscm.debian.org/cgit/pkg-games/love.git/log/ Greetings,
Bug#892917: love: use BD on lua OR luajit
Hi, On 14/03/18 13:37, Frédéric Bonnard wrote: > Package: src:love > Version: 0.9.1-4 > > -- > > Dear maintainer, > > at the moment both liblua5.1-0-dev and libluajit-5.1-dev are required to > build. I think one or the other exclusively should be enough, and your > d/rules specifies one or the other already. > The best being to require first libluajit-5.1-dev if available and > fallback on liblua5.1-0-dev. > This way, love will benefit from luajit's speed if possible but will > build on more architectures as well thanks to lua's portability (that > should fix the BD-Uninstallable status on some architectures) > Here is a patch for this. > Also, ppc64el's support in luajit is unsure in the long term, so with > the patch, we ensure to be able to still have love on this architecture > even if luajit drops ppc64el support (and thus fix the current FTBFS : > https://buildd.debian.org/status/fetch.php?pkg=love&arch=ppc64el&ver=0.9.1-4&stamp=1503721727&raw=0 Bear in mind the buildds ignore alternatives in build-dependencies, so from their perspective, your patch is equivalent to dropping the non-jit dependency and won't fix any of the BD-Uninstallable architectures. I think keeping the current build-dependency on liblua5.1-0-dev but restricting it to the architectures where luajit is not used should do what you want. James signature.asc Description: OpenPGP digital signature
Bug#892917: love: use BD on lua OR luajit
Package: src:love Version: 0.9.1-4 -- Dear maintainer, at the moment both liblua5.1-0-dev and libluajit-5.1-dev are required to build. I think one or the other exclusively should be enough, and your d/rules specifies one or the other already. The best being to require first libluajit-5.1-dev if available and fallback on liblua5.1-0-dev. This way, love will benefit from luajit's speed if possible but will build on more architectures as well thanks to lua's portability (that should fix the BD-Uninstallable status on some architectures) Here is a patch for this. Also, ppc64el's support in luajit is unsure in the long term, so with the patch, we ensure to be able to still have love on this architecture even if luajit drops ppc64el support (and thus fix the current FTBFS : https://buildd.debian.org/status/fetch.php?pkg=love&arch=ppc64el&ver=0.9.1-4&stamp=1503721727&raw=0 Thanks, Regards. F. pgp1RSAl5HYy9.pgp Description: PGP signature diff -Nru love-0.9.1/debian/control love-0.9.1/debian/control --- love-0.9.1/debian/control 2016-08-03 20:27:34.0 + +++ love-0.9.1/debian/control 2016-08-03 20:37:52.0 + @@ -17,8 +17,7 @@ libflac++-dev, libflac-dev, libfreetype6-dev, - liblua5.1-0-dev, - libluajit-5.1-dev [!hurd-i386 !kfreebsd-amd64 !s390x], + libluajit-5.1-dev [!hurd-i386 !kfreebsd-amd64 !s390x] | liblua5.1-0-dev, libmodplug-dev, libmpg123-dev, libogg-dev, pgpE49kREfaNN.pgp Description: PGP signature
