Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Hideki Yamane]

On Sat, 25 Aug 2018 09:11:45 +0200
Raphael Hertzog  wrote:
> you should really add some automated test
> to catch the regressions.

 Well, limited to this time, how did I catch its regression with test?


-- 
Regards,

 Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Philipp Kern]

On 25.08.2018 09:11, Raphael Hertzog wrote:
> On Sat, 25 Aug 2018, Hideki Yamane wrote:
>>> So you saved a few kilobytes and made the life harder for others.
>>> IMO it was the wrong decision.
>>
>>  It was my mistake, of course, but I DON'T WANT TO MAKE SOMEONE'S LIFE
>>  ANY HARDER, IT IS NOT INTENDED. People who made wrong decision should
>>  be blamed as fool? If so, please revert debootstrap before I started 
>>  to commit to it.
> 
> Sorry if you found my message a bit rude, I appreciate the work you are
> doing and I even encouraged you to try it out because clearly nobody
> was assuming the task. But honestly there have been way too many uploads
> with regressions, you should spend more time thinking about the
> consequences of each change and you should really add some automated test
> to catch the regressions.
> 
> I understand the "release early, release often" mantra, but here we are
> speaking of an important tool that we really to keep working at any time.

In this case automated regression testing would only have found it if
derivatives would've been tested for.

Unfortunately while I tried to anticipate the fallout here in [1] I also
did not get an answer to my question. I guess I would've needed to be
more clear in wanting a debdiff between the two udebs because that's
usually how things are reviewed in Debian land - and just reviewing
changes to the source does not convey the same information.

At work we have code review tooling that shows you the change in data
(sadly not in .debs either). I wonder if something similar of "build
package at origin and at target and diff the two" exists.

But that would still require some culture of timely reviews and the
requester waiting until that review is done. Right now merge requests
for d-i won't really work for contributors who already have commit
access because there are two few people who are actually willing to
review - and others actively unassign themselves. I understand why that
is, but at the same time we then need to attenuate our feedback.
Anticipating the consequences requires a certain familiarity that new
contributors don't have. Still automatic pre-release testing is
something very useful.

Kind regards
Philipp Kern

[1]
https://salsa.debian.org/installer-team/debootstrap/merge_requests/16#note_35325

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Raphael Hertzog]

Hello Hideki,

On Sat, 25 Aug 2018, Hideki Yamane wrote:
> > So you saved a few kilobytes and made the life harder for others.
> > IMO it was the wrong decision.
> 
>  It was my mistake, of course, but I DON'T WANT TO MAKE SOMEONE'S LIFE
>  ANY HARDER, IT IS NOT INTENDED. People who made wrong decision should
>  be blamed as fool? If so, please revert debootstrap before I started 
>  to commit to it.

Sorry if you found my message a bit rude, I appreciate the work you are
doing and I even encouraged you to try it out because clearly nobody
was assuming the task. But honestly there have been way too many uploads
with regressions, you should spend more time thinking about the
consequences of each change and you should really add some automated test
to catch the regressions.

I understand the "release early, release often" mantra, but here we are
speaking of an important tool that we really to keep working at any time.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Hideki Yamane]

On Tue, 21 Aug 2018 12:37:00 +0200
Raphael Hertzog  wrote:
> While cleaning up the list of scripts to keep, you decided to drop the
> scripts for all derivatives making it impossible to use the udeb built
> for Debian on any derivative (Kali bug report here:
> https://bugs.kali.org/view.php?id=4921)

 It was not correct assumptions that derivatives use it own udeb
 packages, my apologies.


> So you saved a few kilobytes and made the life harder for others.
> IMO it was the wrong decision.

 It was my mistake, of course, but I DON'T WANT TO MAKE SOMEONE'S LIFE
 ANY HARDER, IT IS NOT INTENDED. People who made wrong decision should
 be blamed as fool? If so, please revert debootstrap before I started 
 to commit to it.


-- 
Regards,

 Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Raphael Hertzog]

Hi,

On Tue, 21 Aug 2018, Cyril Brulebois wrote:
> Right. Feel free to fix/revert this at your earliest convenience.

Did this in 1b4bb92db9812db76c71ee8743f232d0d2d8f8b2.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/


signature.asc
Description: PGP signature

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Cyril Brulebois]

Hi Raphaël,

Raphael Hertzog  (2018-08-21):
> On Fri, 23 Mar 2018, Hideki Yamane wrote:
> >  It's not a problem, but we can improve it, IMO (so severity is low).
> 
> So you tried to fix a non-problem... and while doing so you introduced
> a real problem.
> 
> While cleaning up the list of scripts to keep, you decided to drop the
> scripts for all derivatives making it impossible to use the udeb built
> for Debian on any derivative (Kali bug report here:
> https://bugs.kali.org/view.php?id=4921)
> 
> So you saved a few kilobytes and made the life harder for others.
> IMO it was the wrong decision.
> 
> The other bug that you fixed at the same time asked to add more scripts,
> it did not ask to remove any.
> 
> If you really want to do anything at this level, you should just have
> a list of obsolete release and automatically drop the corresponding
> scripts. But IMO this is not worth the effort. We should just keep all
> scripts.

Right. Feel free to fix/revert this at your earliest convenience.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Raphael Hertzog]

Hi,

On Fri, 23 Mar 2018, Hideki Yamane wrote:
>  It's not a problem, but we can improve it, IMO (so severity is low).

So you tried to fix a non-problem... and while doing so you introduced
a real problem.

While cleaning up the list of scripts to keep, you decided to drop the
scripts for all derivatives making it impossible to use the udeb built
for Debian on any derivative (Kali bug report here:
https://bugs.kali.org/view.php?id=4921)

So you saved a few kilobytes and made the life harder for others.
IMO it was the wrong decision.

The other bug that you fixed at the same time asked to add more scripts,
it did not ask to remove any.

If you really want to do anything at this level, you should just have
a list of obsolete release and automatically drop the corresponding
scripts. But IMO this is not worth the effort. We should just keep all
scripts.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Hideki Yamane]

On Fri, 23 Mar 2018 21:40:08 +0900 Hideki Yamane  wrote:
> > What's the problem here?
> 
>  It's not a problem, but we can improve it, IMO (so severity is low).

 Proposed Merge Request
 https://salsa.debian.org/installer-team/debootstrap/merge_requests/15


-- 
Regards,

 Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Hideki Yamane]

Hi,

On Thu, 22 Mar 2018 06:36:06 +0100
Cyril Brulebois  wrote:
> What's the problem here?

 It's not a problem, but we can improve it, IMO (so severity is low).
 In debian/rules,

> override_dh_auto_install:
> dh_auto_build
> 
> $(MAKE) install DESTDIR=$(CURDIR)/debian/debootstrap
> $(MAKE) install DESTDIR=$(CURDIR)/debian/debootstrap-udeb
> 
> # remove scripts not needed by d-i
> -rm -f debian/debootstrap-udeb/usr/share/debootstrap/scripts/potato \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/woody \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/sarge \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/warty \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/hoary \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/breezy \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/dapper \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/edgy \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/feisty \
> 
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/*.buildd \
> 
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/*.fakechroot \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/stable \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/testing 
> \
> debian/debootstrap-udeb/usr/share/debootstrap/scripts/unstable

 Most of scripts in current udeb seem to be unnecessary.


-- 
Regards,

 Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Cyril Brulebois]

Hideki Yamane  (2018-03-21):
> Package: debootstrap-udeb
> Severity: minor
> 
> Hi,
> 
>  It contains meaningless scripts as below.
> 
> 
> drwxr-xr-x root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/
> -rw-r--r-- root/root  6016 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/aequorea
> -rw-r--r-- root/root  6296 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/etch
> -rw-r--r-- root/root  7461 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/gutsy
> -rw-r--r-- root/root  6233 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/artful -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/bartholomea -> aequorea
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/bionic -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/bullseye -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/buster -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/chromodoris -> aequorea
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/dasyatis -> aequorea
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/etch-m68k -> etch
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/hardy -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/intrepid -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/jaunty -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/jessie -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/jessie-kfreebsd -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/karmic -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/lenny -> etch
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/lucid -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/maverick -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/natty -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/oldoldstable -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/oldstable -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/oneiric -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/precise -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/quantal -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/raring -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/saucy -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/squeeze -> etch
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/stretch -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/trusty -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/utopic -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/vivid -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/wheezy -> sid
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/wily -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/xenial -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/yakkety -> gutsy
> lrwxrwxrwx root/root 0 2018-03-17 23:46 
> ./usr/share/debootstrap/scripts/zesty -> gutsy
> 
>  Not harm but messy.

What's the problem here?


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#893713: debootstrap-udeb: containts too many scripts files (most of them are symlink but...)

[Hideki Yamane]

Package: debootstrap-udeb
Severity: minor

Hi,

 It contains meaningless scripts as below.


drwxr-xr-x root/root 0 2018-03-17 23:46 ./usr/share/debootstrap/scripts/
-rw-r--r-- root/root  6016 2018-03-17 23:46 
./usr/share/debootstrap/scripts/aequorea
-rw-r--r-- root/root  6296 2018-03-17 23:46 
./usr/share/debootstrap/scripts/etch
-rw-r--r-- root/root  7461 2018-03-17 23:46 
./usr/share/debootstrap/scripts/gutsy
-rw-r--r-- root/root  6233 2018-03-17 23:46 
./usr/share/debootstrap/scripts/sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/artful -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/bartholomea -> aequorea
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/bionic -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/bullseye -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/buster -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/chromodoris -> aequorea
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/dasyatis -> aequorea
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/etch-m68k -> etch
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/hardy -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/intrepid -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/jaunty -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/jessie -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/jessie-kfreebsd -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/karmic -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/lenny -> etch
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/lucid -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/maverick -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/natty -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/oldoldstable -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/oldstable -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/oneiric -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/precise -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/quantal -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/raring -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/saucy -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/squeeze -> etch
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/stretch -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/trusty -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/utopic -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/vivid -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/wheezy -> sid
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/wily -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/xenial -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/yakkety -> gutsy
lrwxrwxrwx root/root 0 2018-03-17 23:46 
./usr/share/debootstrap/scripts/zesty -> gutsy

 Not harm but messy.