Bug#896016: strace: please make the build reproducible

[James Addison]

Source: strace
Followup-For: Bug #896016
X-Debbugs-Cc: la...@debian.org, reproducible-b...@lists.alioth.debian.org
Control: fixed -1 strace/4.26-0.1
Control: close -1 

Bug#896016: strace: please make the build reproducible

[Chris Lamb]

James Addison wrote:

> Unfortunately there are plenty of FTBFS failures -- mostly test timeouts on
> some architectures, alongside libfaketime errors that seem to affect i386 --
> but those seem like separate problems.  Perhaps we could close this bug?

Sure thing: as in, I agree that the FTBFS's are a separate problem
and also that this bug can be closed. Can you go ahead and do so,
presumably with the correct versioning? Many thanks.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-

Bug#896016: strace: please make the build reproducible

[James Addison]

Source: strace
Followup-For: Bug #896016
X-Debbugs-Cc: la...@debian.org, reproducible-b...@lists.alioth.debian.org

Looking at the Reproducible Builds build history[1] for strace on Debian,
all _successful_ builds I see between Y2019 and today, across all four
architectures listed (amd64, arm64, armhf, i386) have produced reproducible
results.

As a result of that, I agree that the Apr 2018 fix[2] (released Jun 2018)
mentioned by Chris has provided reproducibility for strace.

Unfortunately there are plenty of FTBFS failures -- mostly test timeouts on
some architectures, alongside libfaketime errors that seem to affect i386 --
but those seem like separate problems.  Perhaps we could close this bug?

[1] - 
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/strace.html

[2] - 
https://github.com/strace/strace/commit/fc8294cbc2ac907737d85abca55b854bd426ab50

Bug#896016: strace: please make the build reproducible

[Chris Lamb]

Chris Lamb wrote:

> A quick glance suggests like this was fixed upstream in Apr 2018:
>
>  https://github.com/strace/strace/pull/68#ref-commit-fc8294c
>
> Can you confirm? Unfortunately, your package FTBFS in our
> infrastructure (something to do with libfaketime, as yet
> uninvestigated).
>
>  
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/strace.html
>
> Click the "rbuild" link on the left hand side for the build log;
> apologies for the weird UI/UX here.

Any ideas here, out of interest?


Regards,

--
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#896016: strace: please make the build reproducible

[Chris Lamb]

> Would you consider applying this patch and uploading?

A quick glance suggests like this was fixed upstream in Apr 2018:

  https://github.com/strace/strace/pull/68#ref-commit-fc8294c

Can you confirm? Unfortunately, your package FTBFS in our
infrastructure (something to do with libfaketime, as yet
uninvestigated).

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/strace.html

Click the "rbuild" link on the left hand side for the build log;
apologies for the weird UI/UX here.


Best wishes,

--
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#896016: strace: please make the build reproducible

[Chris Lamb]

forwarded 896016 https://github.com/strace/strace/pull/68
thanks

I've forwarded this upstream here:

  https://github.com/strace/strace/pull/68


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#896016: strace: please make the build reproducible

[Chris Lamb]

Source: strace
Version: 4.21-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that strace could not be built reproducibly as it encodes a
timezone-varying date in the manpage.

Patch attached that uses SOURCE_DATE_EPOCH [1].

  [0] https://reproducible-builds.org/
  [1] https://reproducible-builds.org/specs/source-date-epoch/


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/patches/reproducible-build 1970-01-01 01:00:00.0 +0100
--- b/debian/patches/reproducible-build 2018-04-18 18:48:03.072934833 +0100
@@ -0,0 +1,24 @@
+Description: Make the build reproducible
+Author: Chris Lamb 
+Last-Update: 2018-04-18
+
+--- strace-4.21.orig/file-date-gen
 strace-4.21/file-date-gen
+@@ -20,6 +20,11 @@ date=
+ 
+ [ -f "${DATE_FILE}" ] && date="$(cat "${DATE_FILE}")"
+ 
++# Use SOURCE_DATE_EPOCH if it exists.
++# 
++[ -n "${SOURCE_DATE_EPOCH}" ] ||
++  date="@${SOURCE_DATE_EPOCH}"
++
+ [ -n "${date}" ] ||
+   date="$(git log -n 1 --format=format:%cD --no-patch "${FILE}")"
+ 
+@@ -32,4 +37,4 @@ date=
+   exit 1
+ }
+ 
+-exec printf "%s" $(date "+${DATE_FORMAT}" -d "${date}")
++exec printf "%s" $(date -u "+${DATE_FORMAT}" -d "${date}")
--- a/debian/patches/series 2018-04-18 18:43:14.655180095 +0100
--- b/debian/patches/series 2018-04-18 18:48:01.920928268 +0100
@@ -1 +1,2 @@
 no-arm-unaligned-access
+reproducible-build