Bug#896559: googletest: please separate source and "prebuilt library" packages

2018-04-24 Thread Roman Lebedev
On Tue, Apr 24, 2018 at 4:21 AM, Steve Robbins  wrote:
> On Sunday, April 22, 2018 5:27:07 AM CDT you wrote:
>> Package: googletest
>> Version: 1.8.0-8
>> Severity: important
>>
>> Dear maintainer. Now that #868234 has been resolved,
>> the package installs sources into /usr/src,
>> and the prebuild library, + headers into /usr/include.
>>
>> This is somewhat problematic.
>> Now if one does not want to use the prebuilt library,
>> but build it in tree (anyone who cares will do that),
>> the headers from the prebuild library will still be in
>> the search path.
>
> I agree it is not optimal.  I have prepared a new revision that implements
> your suggestion #4.  In the upcoming revision:
>
> Package googletest installs sources only
> Package libgtest-dev installs headers + lib for gtest
> New package libgmock-dev installs headers + lib for gmock
SGTM, thanks.

> Let me know if this works for you.  I've just pushed it to Salsa:
> https://salsa.debian.org/debian/googletest
>
>
>> There are several solutions:
>> 1. Don't provide prebuild library.
>> 2. Don't install sources in googletest package,
>>tell people to use $ apt-get source.  BAD.
>> 3. Install headers into some prefix, so they won't be automatically used.
>> 4. Keep googletest with only the sources, and package
>>built library + headers as a separate package, googletest-prebuilt.
>> 5. 3+4 Probably the best one.
>
> I don't believe #3 is worth the trouble because (a) it breaks the automatic
> detection I've seen in some packages; and (b) the headers in /usr/src/googlest
> and in /usr/include are identical, so there's no real issue if the latter is
> used for a source build.
>
> Best,
> -Steve
Roman.



Bug#896559: googletest: please separate source and "prebuilt library" packages

2018-04-23 Thread Steve Robbins
On Sunday, April 22, 2018 5:27:07 AM CDT you wrote:
> Package: googletest
> Version: 1.8.0-8
> Severity: important
> 
> Dear maintainer. Now that #868234 has been resolved,
> the package installs sources into /usr/src,
> and the prebuild library, + headers into /usr/include.
> 
> This is somewhat problematic.
> Now if one does not want to use the prebuilt library,
> but build it in tree (anyone who cares will do that),
> the headers from the prebuild library will still be in
> the search path.

I agree it is not optimal.  I have prepared a new revision that implements 
your suggestion #4.  In the upcoming revision:

Package googletest installs sources only
Package libgtest-dev installs headers + lib for gtest
New package libgmock-dev installs headers + lib for gmock

Let me know if this works for you.  I've just pushed it to Salsa:
https://salsa.debian.org/debian/googletest 


> There are several solutions:
> 1. Don't provide prebuild library.
> 2. Don't install sources in googletest package,
>tell people to use $ apt-get source.  BAD.
> 3. Install headers into some prefix, so they won't be automatically used.
> 4. Keep googletest with only the sources, and package
>built library + headers as a separate package, googletest-prebuilt.
> 5. 3+4 Probably the best one.

I don't believe #3 is worth the trouble because (a) it breaks the automatic 
detection I've seen in some packages; and (b) the headers in /usr/src/googlest 
and in /usr/include are identical, so there's no real issue if the latter is 
used for a source build.

Best,
-Steve


signature.asc
Description: This is a digitally signed message part.


Bug#896559: googletest: please separate source and "prebuilt library" packages

2018-04-22 Thread Roman Lebedev
Package: googletest
Version: 1.8.0-8
Severity: important

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Dear maintainer. Now that #868234 has been resolved,
the package installs sources into /usr/src,
and the prebuild library, + headers into /usr/include.

This is somewhat problematic.
Now if one does not want to use the prebuilt library,
but build it in tree (anyone who cares will do that),
the headers from the prebuild library will still be in
the search path.

Please change that.

There are several solutions:
1. Don't provide prebuild library.
2. Don't install sources in googletest package,
   tell people to use $ apt-get source.  BAD.
3. Install headers into some prefix, so they won't be automatically used.
4. Keep googletest with only the sources, and package
   built library + headers as a separate package, googletest-prebuilt.
5. 3+4 Probably the best one.

Roman.

- -- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'unstable-debug'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.15.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages googletest depends on:
ii  python  2.7.15~rc1-1

googletest recommends no packages.

googletest suggests no packages.

- -- no debconf information

-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEjkF6151RK40WXe2HCDw+u0oWieAFAlrcY3gACgkQCDw+u0oW
ieCbIQ/9HslhYiFnL//+RXetMK2eFOSCAJrIAWQjrpGIUUi5cQ58evDbPwoSHYTb
aKHrvCVYXSc1vUyHohiQHxyciQCchhLIiublNIGQutwZsZ+KghoJ1VO5RciTH/MB
HtcW14+Ds5+9KkphxLIzlGVNhuCff6Sn3tGglxi9ttBeIIkL52Al43s3EcSdM4Ix
jKR0YrCrhVeKTQDeYhITEOV89lL0/8ERtrekznT9UtgzV/hsWnB6GjwOuqyf+o5g
X9jXf5TFd+7AZgAuJtcIklr7bT7mGNRi7hhqRHRGkUTqQl4/Xd+AiXhyS84qrncp
Cee0gb9tRRo/z9E2yUKJsxuiNaC4IIHapiTHTt+49fwbctyXr0EiUkiQLd3W9tqq
1IcrMx/1mQ53CnM6cFJwCs8ih7YHPKeON4AgKN4R1buB7wa+em7SnqEMx0BibW+H
7LyJ/hAePkFLG1aZfX5ygNyC+NifP2JIf5hLFynr1aWvF1Trl59GAWgIcxq1/jho
1WkkzJqIl38bcUpTM4eztCtUEhOtiFMVPQGs8KnnXsHY/5bx6q61Q7XJyXC2QZIp
vlr9Jin1VjIdrj4nyUXmXNfXh/Z/l56PSVPhgDMXGJiVEmOh9aGkCiBE49KB2vPk
f2ZxMR58N+hDr16WcR8DBvCc8xH72wDoTKwu6+PId3DJK5qkLis=
=fZad
-END PGP SIGNATURE-