Source: bsdgames
Version: 2.17-26
Severity: wishlist
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

While trying to cross build bsdgames, I noticed that it would always
select gcc and g++ as compilers. The attached patch does not make
bsdgames cross buildable, but it makes bsdgames use a more suitable
compiler:
 * For cross compilation dpkg's buildtools.mk has sane defaults.
 * Using the CC and CXX variables allows builders to override the
   compiler e.g. with clang in a uniform way.

Cross building still fails, because bsdgames has a few support utilities
that are run during build. Its build system does not properly
differentiate these tools for use with different compilers.

Please consider applying the attached patch to improve the compiler
choice nonetheless.

Helmut
diff --minimal -Nru bsdgames-2.17/debian/changelog 
bsdgames-2.17/debian/changelog
--- bsdgames-2.17/debian/changelog      2017-11-01 17:37:54.000000000 +0100
+++ bsdgames-2.17/debian/changelog      2018-04-26 19:37:43.000000000 +0200
@@ -1,3 +1,11 @@
+bsdgames (2.17-26.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use user supplied CC/CXX with sane defaults for cross compilation.
+    (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de>  Thu, 26 Apr 2018 19:37:43 +0200
+
 bsdgames (2.17-26) unstable; urgency=medium
 
   * Fix FTBFS with libncurses6.
diff --minimal -Nru bsdgames-2.17/debian/rules bsdgames-2.17/debian/rules
--- bsdgames-2.17/debian/rules  2016-04-05 10:27:54.000000000 +0200
+++ bsdgames-2.17/debian/rules  2018-04-26 19:37:43.000000000 +0200
@@ -2,6 +2,9 @@
 
 # Use all hardening features
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+-include /usr/share/dpkg/buildtools.mk
+export bsd_games_cfg_cc=$(CC)
+export bsd_games_cfg_cxx=$(CXX)
 
 %:
        dh $@

Reply via email to