Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Martín Ferrari]

On 17/05/18 09:48, Lucas Nussbaum wrote:

>> I have no issue with this decision.
> Same here. But it's strange: given my workflow, I think that the build
> was retried on a idle server after the initial failure.

Not sure what happened, but you can see there is some timing info in
some tests, and the run that failed was 3 times slower than the other,
and the tests that passed were very close to the cut-off:

Passing:

  Mustache CLI
✓ writes syntax hints into stderr when runned with wrong number of
arguments (531ms)
✓ writes hints about JSON parsing errors when given invalid JSON (639ms)
✓ writes module version into stdout when runned with --version (605ms)
✓ writes module version into stdout when runned with -v (550ms)

Failing:

  Mustache CLI
✓ writes syntax hints into stderr when runned with wrong number of
arguments (1795ms)
1) writes hints about JSON parsing errors when given invalid JSON
✓ writes module version into stdout when runned with --version (1828ms)
✓ writes module version into stdout when runned with -v (1931ms)


-- 
Martín Ferrari (Tincho)

Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Lucas Nussbaum]

On 17/05/18 at 10:17 +0200, Pierre-Elliott Bécue wrote:
> Le 17 mai 2018 10:14:41 GMT+02:00, "Martín Ferrari"  a 
> écrit :
> >severity 897536 important
> >thanks
> >
> >On Mon, 14 May 2018 00:30:36 +0200 Pierre-Elliott
> >=?iso-8859-1?Q?B=E9cue?=  wrote:
> >
> >> Indeed the rake issue is gone with the latest upload of rake.
> >> 
> >> Yet, [1] shows that mustache.js still FTBFS.
> >
> >> [1]
> >https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mustache.js.html
> >
> >While we should fix this, I don't think this counts as a serious bug.
> >The tests fail sometimes (probably on a busy server), but that's it.
> >
> >I think the severity of this bug should be lowered, as this is
> >threatening to remove from testing mustache.js and its reverse
> >dependencies.
> 
> I have no issue with this decision.

Same here. But it's strange: given my workflow, I think that the build
was retried on a idle server after the initial failure.

Lucas

Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Martín Ferrari]

severity 897536 important
thanks

On Mon, 14 May 2018 00:30:36 +0200 Pierre-Elliott
=?iso-8859-1?Q?B=E9cue?=  wrote:

> Indeed the rake issue is gone with the latest upload of rake.
> 
> Yet, [1] shows that mustache.js still FTBFS.

> [1] 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mustache.js.html

While we should fix this, I don't think this counts as a serious bug.
The tests fail sometimes (probably on a busy server), but that's it.

I think the severity of this bug should be lowered, as this is
threatening to remove from testing mustache.js and its reverse dependencies.

-- 
Martín Ferrari (Tincho)

Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Pierre-Elliott Bécue]

Le 17 mai 2018 10:14:41 GMT+02:00, "Martín Ferrari"  a écrit 
:
>severity 897536 important
>thanks
>
>On Mon, 14 May 2018 00:30:36 +0200 Pierre-Elliott
>=?iso-8859-1?Q?B=E9cue?=  wrote:
>
>> Indeed the rake issue is gone with the latest upload of rake.
>> 
>> Yet, [1] shows that mustache.js still FTBFS.
>
>> [1]
>https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mustache.js.html
>
>While we should fix this, I don't think this counts as a serious bug.
>The tests fail sometimes (probably on a busy server), but that's it.
>
>I think the severity of this bug should be lowered, as this is
>threatening to remove from testing mustache.js and its reverse
>dependencies.

I have no issue with this decision.

Cheers!
-- 
PEB

Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Pierre-Elliott Bécue]

Le vendredi 11 mai 2018 à 12:12:44+0200, Jonas Meurer a écrit :
> Control: tag -1 +moreinfo
> 
> Hello,
> 
> I just tried to reproduce the FTBFS and failed. rake is defined as
> build-dependency and correctly pulled in according to linked the build logs.
> 
> My best guess is that rake 12.3.1-2 had some bug that got fixed in 12.3.1-3.
> 
> Lucas, could you trigger another rebuild to see whether this got fixed
> by the latest rake upload?
> 
> In any case, it doesn't look like a bug in mustache.js package to me.
> 
> Cheers,

Indeed the rake issue is gone with the latest upload of rake.

Yet, [1] shows that mustache.js still FTBFS.

The reason seems to be that the mustache.js CLI takes too much time to do
its job in some tests on the build servers of the reproducible-builds
project. As the timeout of mocha testsuite is 2s, this leads to some
failures.

A fix should be designed. I see two solutions:

 1) In all describe statements of cli-test.js[2], add a more reasonable
timeout delay to mocha, such as
"""
describe('Mustache CLI', function () {
this.timeout(5000);
var expectedOutput;
[…]
"""
 2) Disable these tests.

It should be noted that tests that may fail based on a time-dependency
(timeout, time-based tests) are not fit for reproducibility tests.

Cheers.

[1] 
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mustache.js.html
[2] https://github.com/janl/mustache.js/blob/master/test/cli-test.js

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.


signature.asc
Description: PGP signature

Bug#897536: [Pkg-javascript-devel] Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Bastien ROUCARIES]

On Fri, May 11, 2018 at 12:12 PM, Jonas Meurer  wrote:
> Control: tag -1 +moreinfo
>
> Hello,
>
> I just tried to reproduce the FTBFS and failed. rake is defined as
> build-dependency and correctly pulled in according to linked the build logs.
>
> My best guess is that rake 12.3.1-2 had some bug that got fixed in 12.3.1-3.
>
> Lucas, could you trigger another rebuild to see whether this got fixed
> by the latest rake upload?
>
> In any case, it doesn't look like a bug in mustache.js package to me.

In this case build-depends on 12.3.1-3.

Bastien
>
> Cheers,
>  jonas
>
> On Wed, 2 May 2018 22:51:57 +0200 Lucas Nussbaum  wrote:
>> Source: mustache.js
>> Version: 2.3.0-2
>> Severity: serious
>> Tags: buster sid
>> User: debian...@lists.debian.org
>> Usertags: qa-ftbfs-20180502 qa-ftbfs
>> Justification: FTBFS on amd64
>>
>> Hi,
>>
>> During a rebuild of all packages in sid, your package failed to build on
>> amd64.
>>
>> Relevant part (hopefully):
>> >  debian/rules build
>> > dh build --builddirectory=/<>/build
>> >dh_update_autotools_config -O--builddirectory=/<>/build
>> >dh_auto_configure -O--builddirectory=/<>/build
>> >debian/rules override_dh_auto_build
>> > make[1]: Entering directory '/<>'
>> > rake jquery
>> > make[1]: rake: Command not found
>> > make[1]: *** [debian/rules:13: override_dh_auto_build] Error 127
>>
>> The full build log is available from:
>>http://aws-logs.debian.net/2018/05/02/mustache.js_2.3.0-2_unstable.log
>>
>> A list of current common problems and possible solutions is available at
>> http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
>>
>> About the archive rebuild: The rebuild was done on EC2 VM instances from
>> Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
>> failed build was retried once to eliminate random failures.
>>
>>
>
>
> --
> Pkg-javascript-devel mailing list
> pkg-javascript-de...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Jonas Meurer]

Control: tag -1 +moreinfo

Hello,

I just tried to reproduce the FTBFS and failed. rake is defined as
build-dependency and correctly pulled in according to linked the build logs.

My best guess is that rake 12.3.1-2 had some bug that got fixed in 12.3.1-3.

Lucas, could you trigger another rebuild to see whether this got fixed
by the latest rake upload?

In any case, it doesn't look like a bug in mustache.js package to me.

Cheers,
 jonas

On Wed, 2 May 2018 22:51:57 +0200 Lucas Nussbaum  wrote:
> Source: mustache.js
> Version: 2.3.0-2
> Severity: serious
> Tags: buster sid
> User: debian...@lists.debian.org
> Usertags: qa-ftbfs-20180502 qa-ftbfs
> Justification: FTBFS on amd64
> 
> Hi,
> 
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
> 
> Relevant part (hopefully):
> >  debian/rules build
> > dh build --builddirectory=/<>/build
> >dh_update_autotools_config -O--builddirectory=/<>/build
> >dh_auto_configure -O--builddirectory=/<>/build
> >debian/rules override_dh_auto_build
> > make[1]: Entering directory '/<>'
> > rake jquery
> > make[1]: rake: Command not found
> > make[1]: *** [debian/rules:13: override_dh_auto_build] Error 127
> 
> The full build log is available from:
>http://aws-logs.debian.net/2018/05/02/mustache.js_2.3.0-2_unstable.log
> 
> A list of current common problems and possible solutions is available at
> http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
> 
> About the archive rebuild: The rebuild was done on EC2 VM instances from
> Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
> failed build was retried once to eliminate random failures.
> 
> 



signature.asc
Description: OpenPGP digital signature

Bug#897536: mustache.js: FTBFS: make[1]: rake: Command not found

[Lucas Nussbaum]

Source: mustache.js
Version: 2.3.0-2
Severity: serious
Tags: buster sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20180502 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
>  debian/rules build
> dh build --builddirectory=/<>/build
>dh_update_autotools_config -O--builddirectory=/<>/build
>dh_auto_configure -O--builddirectory=/<>/build
>debian/rules override_dh_auto_build
> make[1]: Entering directory '/<>'
> rake jquery
> make[1]: rake: Command not found
> make[1]: *** [debian/rules:13: override_dh_auto_build] Error 127

The full build log is available from:
   http://aws-logs.debian.net/2018/05/02/mustache.js_2.3.0-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.