Bug#898205: Consecutive builds may fail

2018-05-20 Thread Nicholas D Steeves
Hi Chris,

On Tue, May 08, 2018 at 06:51:17PM +0100, Chris Lamb wrote:
> Nicholas,
> 
> > Continuing from #883218.  Strictly speaking I think this might be a
> > §4.9 "clean (required)" Policy violation and should be priority
> > "serious", but I'd like to keep it as "important" until
> 
> I fear looking up the exact Policy reference, writing this mail and
> additionally providing a justification to why you chose a particular
> level seems a little add odds time and energy-wise for a one-line fix
> to a package, no? :)

Haha, yes, for the general case absolutely!  This was before the
virtual "ftbfs" bug priority, and I believe that the extra work is
similar to the old "one must manually look up every mispelt word in a
physical dictionary to learn how to spell it, rather than learning how
to rely on a spellcheck gadget or on others".  So yeah, important for
DD application candidacy ;-)

Also I appreciate you took the time to find this issue and feel bad
that I misunderstood where your were encountering the error, and
especially that I had missed what turned out to be a serious policy
violation!

Still waiting to yasnippet-snippets to merge Elpy's snippets, and for
a new Elpy release.  Even if neither of these occurs, I'll request
sponsorship for an upload on the first of June, in order to close this
bug.

Take care!
Nicholas


signature.asc
Description: PGP signature


Bug#898205: Consecutive builds may fail

2018-05-08 Thread Chris Lamb
Nicholas,

> Continuing from #883218.  Strictly speaking I think this might be a
> §4.9 "clean (required)" Policy violation and should be priority
> "serious", but I'd like to keep it as "important" until

I fear looking up the exact Policy reference, writing this mail and
additionally providing a justification to why you chose a particular
level seems a little add odds time and energy-wise for a one-line fix
to a package, no? :)


Best wishes,


-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#898205: Consecutive builds may fail

2018-05-08 Thread Nicholas D Steeves
Package: elpy
Version: 1.20.0-1
Severity: important

Continuing from #883218.  Strictly speaking I think this might be a
§4.9 "clean (required)" Policy violation and should be priority
"serious", but I'd like to keep it as "important" until June because
it does not affect the usability of elpa-elpy.  Also, I'd prefer for
the next upload to also include a new upstream version, and I believe
one will be released before June..

Hi Chris,

On Tue, May 08, 2018 at 03:32:53AM +0100, Chris Lamb wrote:
> Hi Nicholas,
> 
> > > Anyway, thank you for your kind comments. Do let me know if/when
> > > you have any updates to the package, particularly one that fixes the
> > > FTBFS twice-in-a-row.
> > 
> > This was solved in #896998 "python-pip: missing required _vendor
> > module. Broken ${python:Depends}?". 
> 
> Hm? I think you misparsed - your package FTBFS when built twice in a
> row right now AFACIT. Nothing to do with tests or pip or anything..

Oh, now I see what you mean.  Yeah, I thought "FTBFS when built twice
in a row" was build A fails and B fails (which occurred with failing
tests or the pip bug), but didn't realise you meant dpkg-buildpackage
for build A succeeds and B fails when A and B are run without a
freshly unpacked src:package (eg: not in a package builder that does
this automatically).  The specific error is this:

  dpkg-source: info: using source format '3.0 (quilt)'
  dpkg-source: info: building elpy using existing ./elpy_1.20.0.orig.tar.xz
  dpkg-source: warning: file elpy-1.20.0/elpy.egg-info/SOURCES.txt has no final 
  newline (either original or modified version)
  dpkg-source: info: local changes detected, the modified files are:
   elpy-1.20.0/elpy.egg-info/PKG-INFO
   elpy-1.20.0/elpy.egg-info/SOURCES.txt
   elpy-1.20.0/elpy.egg-info/dependency_links.txt
   elpy-1.20.0/elpy.egg-info/requires.txt
   elpy-1.20.0/elpy.egg-info/top_level.txt

If that's what you're referring to, I just fixed it in git and am
thinking about a good changelog entry for the commit before pushing. :-)

Thank you for pushing me to be more thorough!
Cheers,
Nicholas