Bug#898426: [PATCH] partx: exit with error code when partition read failed

2018-06-18 Thread Karel Zak
On Sun, Jun 17, 2018 at 02:49:15PM +0200, Andreas Henriksson wrote:
>  disk-utils/partx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
 Karel Zak  
 http://karelzak.blogspot.com



Bug#898426: [PATCH] partx: exit with error code when partition read failed

2018-06-17 Thread Andreas Henriksson
Make sure partx exits with a non-0 return code when
it runs into either code-path where getting the partition
table failed (or wasn't even attempted because of previous
error condition).

Change was tested using:
touch /tmp/foobar
partx -s - /tmp/foobar

Previously that was only printing an error/warning message
and then exiting with 0, but after this change it exits
with 1.

Signed-off-by: Andreas Henriksson 
Reported-by: Juan Céspedes 
Addresses: https://bugs.debian.org/898426
---
 disk-utils/partx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/disk-utils/partx.c b/disk-utils/partx.c
index 3ccd1afad..f895b9be3 100644
--- a/disk-utils/partx.c
+++ b/disk-utils/partx.c
@@ -1054,7 +1054,9 @@ int main(int argc, char **argv)
default:
abort();
}
-   }
+   } else
+   rc = 1;
+
blkid_free_probe(pr);
}
 
-- 
2.17.1