Bug#898912: telepathy-gabble: please make the build reproducible

[Chris Lamb]

Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#898912: telepathy-gabble: please make the build reproducible

[Chris Lamb]

Dear Maintainer,

> Source: telepathy-gabble
> Version: 0.18.4-1
> Tags: patch

There hasn't seem to be any update on this bug in 837 days, in which
time the Reproducible Builds effort has come on a long way.

Would you consider applying this patch and uploading?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#898912: telepathy-gabble: please make the build reproducible

[Chris Lamb]

Source: telepathy-gabble
Version: 0.18.4-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that telepathy-gabble could not be built reproducibly.

This was due to a test file using the absolute build directly.

Patch attached that simply drops this file - it won't work without
the build-time ./libtool wrapper anyway...

 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/patches/Reproducible-build.patch   1970-01-01 01:00:00.0 
+0100
--- b/debian/patches/Reproducible-build.patch   2018-05-17 12:49:41.382034189 
+0200
@@ -0,0 +1,16 @@
+Description: Make the build reproducible
+Author: Chris Lamb 
+Last-Update: 2018-05-17
+
+This file won't work without the build-time ./libtool anyway.
+
+--- telepathy-gabble-0.18.4.orig/tests/twisted/Makefile.am
 telepathy-gabble-0.18.4/tests/twisted/Makefile.am
+@@ -288,7 +288,6 @@ if ENABLE_INSTALLED_TESTS
+ twistedtestsdir = @gabbletestsdir@/twisted
+ nobase_nodist_twistedtests_SCRIPTS = \
+   run-test.sh \
+-  tools/exec-with-log.sh \
+   tools/run-gabble.sh \
+   $(NULL)
+ nobase_dist_twistedtests_SCRIPTS = \
--- a/debian/patches/series 2018-05-17 12:18:32.808996924 +0200
--- b/debian/patches/series 2018-05-17 12:42:23.427877897 +0200
@@ -1 +1,2 @@
 Add-a-systemd-user-service.patch
+Reproducible-build.patch