Bug#900061: Please remove theoretically unneeded patch from debian directory

[Graham Inggs]

On 25 May 2018 at 17:44, Lumin  wrote:
> And my laptop has also built it successfully, passing all the unit tests.
>
> So I directly pushed the change.
>
> https://salsa.debian.org/science-team/pandas/commit/2e02f24129fb3bc28155279ff139e35fa1e9950a

Excellent, thank you!

Would you also please add an entry to the changelog, with (Closes:
#900061)?  Otherwise, it may be forgotten.

Bug#900061: Please remove theoretically unneeded patch from debian directory

[Lumin]

control: tag -1 +pending

On Fri, May 25, 2018 at 05:10:52PM +0200, Graham Inggs wrote:
> Hi, I think you replied to me only, and not the bug.

Noticed that, and I have updated my mutt config.
 
> I'm happy to sponsor an upload if you think it is urgent, but I think it can
> wait until pandas 0.23.
 
This is not urgent.

After removing the patch, debomatic build seems to be successful.

http://debomatic-amd64.debian.net/distribution#unstable/pandas/0.22.0-6.1/buildlog

And my laptop has also built it successfully, passing all the unit tests.

So I directly pushed the change.

https://salsa.debian.org/science-team/pandas/commit/2e02f24129fb3bc28155279ff139e35fa1e9950a

> 
> On 25/05/2018 16:00, Lumin wrote:
> > control: tag -1 +moreinfo
> > 
> > On Fri, May 25, 2018 at 03:37:12PM +0200, Graham Inggs wrote:
> > > On 25/05/2018 15:25, Lumin wrote:
> > > > I didn't test the package without the patch. However, theoretically
> > > > speaking, this patch should be removed ASAP.
> > > 
> > > Would you please test the package without the patch, and make the change 
> > > on
> > > Salsa if successful?
> > 
> > I guess that my laptop cannot finish the build before I go to sleep.
> > Let's have DoM-amd64 to test it
> > 
> > http://debomatic-amd64.debian.net/distribution#unstable/pandas/0.22.0-6.1/buildlog
> > 
> > Result should be available in several hours. The debdiff of the
> > tester package is as follows
> > 
> >/tmp ❯❯❯ debdiff pandas_0.22.0-6.dsc pandas_0.22.0-6.1.dsc
> >diff -Nru pandas-0.22.0/debian/changelog pandas-0.22.0/debian/changelog
> >--- pandas-0.22.0/debian/changelog   2018-04-24 19:09:20.0 
> > +
> >+++ pandas-0.22.0/debian/changelog   2018-05-25 13:46:58.0 
> > +
> > 
> >[...]
> >diff -Nru pandas-0.22.0/debian/patches/series 
> > pandas-0.22.0/debian/patches/series
> >--- pandas-0.22.0/debian/patches/series  2018-04-24 17:35:34.0 
> > +
> >+++ pandas-0.22.0/debian/patches/series  2018-05-25 13:46:58.0 
> > +
> >@@ -3,7 +3,7 @@
> > deb_skip_stata_on_bigendians
> > deb_disable_googleanalytics
> > deb_skip_sequencelike_on_armel
> >-deb_fix_test_failure_test_basic_indexing
> >+#deb_fix_test_failure_test_basic_indexing
> > # Try to skip -- migth have been addressed upstream
> > # deb_skip_test_pytables_failure
> > # up_buggy_overflows
> > 
> 


signature.asc
Description: PGP signature

Bug#900061: Please remove theoretically unneeded patch from debian directory

[Graham Inggs]

On 25/05/2018 15:25, Lumin wrote:

I didn't test the package without the patch. However, theoretically
speaking, this patch should be removed ASAP.


Would you please test the package without the patch, and make the change 
on Salsa if successful?

Bug#900061: Please remove theoretically unneeded patch from debian directory

[Lumin]

Package: python3-pandas
Version: 0.22.0-6
Severity: normal

Dear Pandas Maintainers,

I introduced a patch to pandas at the last time I team upload it.
The patch is specific to a test failure of pandas 0.20.3 , and the
workaround, I guess, is now not needed anymore.

>  pandas (0.20.3-11) unstable; urgency=medium
>
>
>* Workaround test failure of test_basic_indexing() in file
>  pandas/tests/series/test_indexing.py .
>  + patches/deb_fix_test_failure_test_basic_indexing

However please note that, I had added a comment in the patch, saying

> 26 Note: Please remove this patch when version >= 0.21.

I didn't test the package without the patch. However, theoretically
speaking, this patch should be removed ASAP.


signature.asc
Description: PGP signature