Bug#900270: libcryptui: Fails to display the signing key when the signing key has multiple subkeys

2018-08-17 Thread Ulrike Uhlig
Hi!

Simon McVittie:
> Control: tags -1 + patch
> Control: forwarded -1 https://bugzilla.gnome.org/show_bug.cgi?id=774611
> 
> On Fri, 17 Aug 2018 at 14:11:00 +, Ulrike Uhlig wrote:
> If you're pinging a bug like this, please keep the subject line that
> identifies which package and bug you're talking about: maintainers will
> often see these messages completely out-of-context, and having to look
> up a bug number before you can do anything is not a great incentive to
> work on a particular bug :-)

Ack! Thanks for pointing it out. This is not very intuitive from the
BTS' web interface.

>> Unfortunately upstream has not replied, but you might still be able to
>> cherry-pick the patches… is that something you'd consider?
> 
> Adding metadata that could help someone do that.

Thanks.

> The patches appear to be:
> https://gitlab.gnome.org/GNOME/libcryptui/commit/bdd2fd518bac805e379ab6b23cc450d257d524fa
> "daemon: Add a hack to find subkeys identities"
> and
> https://gitlab.gnome.org/GNOME/libcryptui/commit/6a4d4b83bd1d82bcc21bf66143fecd04f8e872a6
> "daemon: Fall back to displaying the key ID if the key is not found"
> 
> Can you confirm that applying those two patches is sufficient?

I confirm this.

> (I have not attempted to review them)

 As you can see on the upstream bug report, they've actually merged them
into master.

> Back in 2017, upstream did say:
>> This library is on its last legs, however
> 
> I believe seahorse is not very maintained upstream at the moment, so
> if it's important to you, it might be a good idea for someone with a
> visible history of contributions to talk to upstream GNOME developers
> (perhaps the GNOME release team or the desktop-devel mailing list, if
> the maintainer of libcryptui can't be contacted?) about the possibility
> of taking over maintenance.

This seems like a good idea. I'll ask the people who proposed the patches.

Cheers!
u.



Bug#900270: libcryptui: Fails to display the signing key when the signing key has multiple subkeys

2018-08-17 Thread Simon McVittie
Control: tags -1 + patch
Control: forwarded -1 https://bugzilla.gnome.org/show_bug.cgi?id=774611

On Fri, 17 Aug 2018 at 14:11:00 +, Ulrike Uhlig wrote:
> ping ^

If you're pinging a bug like this, please keep the subject line that
identifies which package and bug you're talking about: maintainers will
often see these messages completely out-of-context, and having to look
up a bug number before you can do anything is not a great incentive to
work on a particular bug :-)

> Unfortunately upstream has not replied, but you might still be able to
> cherry-pick the patches… is that something you'd consider?

Adding metadata that could help someone do that.

The patches appear to be:
https://gitlab.gnome.org/GNOME/libcryptui/commit/bdd2fd518bac805e379ab6b23cc450d257d524fa
"daemon: Add a hack to find subkeys identities"
and
https://gitlab.gnome.org/GNOME/libcryptui/commit/6a4d4b83bd1d82bcc21bf66143fecd04f8e872a6
"daemon: Fall back to displaying the key ID if the key is not found"

Can you confirm that applying those two patches is sufficient?

(I have not attempted to review them)

Back in 2017, upstream did say:
> This library is on its last legs, however

I believe seahorse is not very maintained upstream at the moment, so
if it's important to you, it might be a good idea for someone with a
visible history of contributions to talk to upstream GNOME developers
(perhaps the GNOME release team or the desktop-devel mailing list, if
the maintainer of libcryptui can't be contacted?) about the possibility
of taking over maintenance.

smcv