Bug#900407: RFS: odp-dpdk/1.19.0.0-1 [ITP]
On Wed, 30 May 2018 13:37:29 +0300 Dmitry Eremin-Solenikov wrote: > Package: sponsorship-requests > Severity: normal > Control: block -1 by 896970 > Control: block 899383 by -1 > > Dear mentors, > > I am looking for a sponsor for my package "odp-dpdk" > > * Package name: odp-dpdk >Version : 1.19.0.0-1 >Upstream Author : Linaro / ODP community > * URL : https://www.opendataplane.org/ > * License : BSD-3-Clause >Section : libs > > It builds those binary packages: > > libodp-dpdk-dev - OpenDataPlane DPDK faceplate library (development) > libodp-dpdk119 - OpenDataPlane DPDK faceplate library (runtime) > > To access further information about this package, please visit the following URL: > > https://mentors.debian.net/package/odp-dpdk > > > Alternatively, one can download the package with dget using this command: > > dget -x https://mentors.debian.net/debian/pool/main/o/odp-dpdk/odp- dpdk_1.19.0.0-1.dsc > > More information about hello can be obtained from https://www.opendat aplane.org. > These packages provide hardware-optimized implementation of ODP API > (using DPDK as a backend). > > -- > With best wishes > Dmitry Eremin-Solenikov I'd recommend to change the build system to check for pkg-config first (libdpdk.pc), and only fallback to the manual checks if not found. We have already shipped libdpdk.pc for years in Ubuntu and Debian, and now upstream is shipping it too when using the new build system based on Meson. This will make your life much easier as there are frequently changes in compiler flags or headers or libraries locations happening, for example there are a few queued for 18.11. With pkg-config you can just ignore all that and it will just work (TM). -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part
Bug#900407: RFS: odp-dpdk/1.19.0.0-1 [ITP]
control: tag -1 +moreinfo control: owner -1 ! Hi Dmitry, Thank you for the package. It looks good except for several flaws: 1. error in postrm script, which causes error on removal update-alternatives: error: alternative name (/usr/lib/x86_64-linux-gnu/libodp-linux.so.119) must not contain '/' and spaces dpkg: error processing package libodp-dpdk119:amd64 (--remove): installed libodp-dpdk119:amd64 package pre-removal script subprocess returned error exit status 2 Errors were encountered while processing: libodp-dpdk119:amd64 2. the alternatives priority of the .so file and .so.119 file should be the same. 3. Similar to src:odp, the copyright file of odp-dpdk is not complete: grep -ri copyright | grep -vi linaro | grep -i copyright Apart from that, I have to ask a few questions about this package: >From README.DPDK > DPDK only works on a selected range of network cards. 11. Does it support any open-sourced/free network card, which doesn't require binary blobs? If it does not support open-sourced/free hardwares, which means non-free drivers are indirectly required by this package. In this case I'd suggest this package go to contrib section instead of main. -Section: libs +Section: contrib/libs 12. This implementation is specifically optimized for several architectures. Does that mean this implementation leverages specific instruction sets, e.g. NEON (arm), AVX (amd64), VSX (ppc)?
Bug#900407: RFS: odp-dpdk/1.19.0.0-1 [ITP]
Package: sponsorship-requests Severity: normal Control: block -1 by 896970 Control: block 899383 by -1 Dear mentors, I am looking for a sponsor for my package "odp-dpdk" * Package name: odp-dpdk Version : 1.19.0.0-1 Upstream Author : Linaro / ODP community * URL : https://www.opendataplane.org/ * License : BSD-3-Clause Section : libs It builds those binary packages: libodp-dpdk-dev - OpenDataPlane DPDK faceplate library (development) libodp-dpdk119 - OpenDataPlane DPDK faceplate library (runtime) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/odp-dpdk Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/o/odp-dpdk/odp-dpdk_1.19.0.0-1.dsc More information about hello can be obtained from https://www.opendataplane.org. These packages provide hardware-optimized implementation of ODP API (using DPDK as a backend). -- With best wishes Dmitry Eremin-Solenikov -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.16.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
