Bug#901547: seabios: Source tarball ships compiled binaries

[Andreas Henriksson]

Control: retitle -1 please remove shipped binaries in clean target
Control: severity -1 wishlist

On Fri, Jun 15, 2018 at 03:43:25PM +0100, Chris Lamb wrote:
[...]
> (As an aside, it might be clearer to explicitly remove the pre-built
> files in the clean target — this way it guarantees they are always
> rebuilt... but that's an entire adjunct remark.)

As everyone seems to agree the binaries doesn't have to be removed
from the tarball to meet DFSG, I'm retitling and adjusting severity
according to the comment quoted above.

Regards,
Andreas Henriksson

Bug#901547: seabios: Source tarball ships compiled binaries

[Vivia Nikolaidou]

On 15 June 2018 at 14:43, Chris Lamb  wrote:
> Michael Tokarev wrote:
>
>> We ensure the pre-built files are not used during build, and the source
>> of them is included, so we comply to DFSG.
>
> Indeed, I don't see a DFSG violation here..  Vivia?

OK then, seems I had misunderstood the DFSG. Sorry for the noise, feel
free to close this one.

Bug#901547: seabios: Source tarball ships compiled binaries

[Chris Lamb]

Michael Tokarev wrote:

> We ensure the pre-built files are not used during build, and the source
> of them is included, so we comply to DFSG.

Indeed, I don't see a DFSG violation here..  Vivia?

Whilst it might be "better" if upstream did not ship these, repacking
the tarball simply to remove them is unnecessary and involves other
compromises.

(As an aside, it might be clearer to explicitly remove the pre-built
files in the clean target — this way it guarantees they are always
rebuilt... but that's an entire adjunct remark.)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#901547: seabios: Source tarball ships compiled binaries

[Michael Tokarev]

Control: tag -1 + moreinfo

14.06.2018 19:23, Vivia Nikolaidou wrote:
> Package: seabios
> Version: 1.11.1-1
> Severity: serious
> Justification: Policy 2.1.2
> 
> Dear Maintainer,
> 
> I just noticed that the source tarball of seabios includes some compiled
> binaries:
[]
> They should not be shipped at all, they should just be built when packaging.

What is "should" in this case? I don't see a reason to repackage upstream
tarball just to remove the iasl pre-compiled files it contains.
We ensure the pre-built files are not used during build, and the source
of them is included, so we comply to DFSG.

Thanks,

/mjt

Bug#901547: seabios: Source tarball ships compiled binaries

[Vivia Nikolaidou]

Package: seabios
Version: 1.11.1-1
Severity: serious
Justification: Policy 2.1.2

Dear Maintainer,

I just noticed that the source tarball of seabios includes some compiled
binaries:

$ ls src/fw/*.hex
src/fw/acpi-dsdt.hex  src/fw/ssdt-misc.hex  src/fw/ssdt-pcihp.hex  src/fw/ssdt-
proc.hex

In debian/rules, these files are moved away and rebuilt:

# move out shipped .hex files and rebuild them
mkdir -p build/src/fw
for f in ${FW_FILES}; do [ -f $$f.sav -o ! -f $$f ] || mv $$f $$f.sav;
done
rm -f ${FW_FILES}
make OUT=build/ ${FW_FILES}
touch $@

They should not be shipped at all, they should just be built when packaging.



-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=el_GR.UTF-8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- no debconf information