Bug#903090: Want to spot source-only binaries-NEW upload to Debian

[Sean Whitton]

Hello,

On Sun 27 Oct 2019 at 12:22PM -07, Russ Allbery wrote:

> My thought process was more that since I've run dgit sbuild, there's a
> *.changes file that lists all the binary packages that the source builds.
> But there probably isn't any reasonable way for push-source to be able to
> use that *.changes file to know the binary package list, since it doesn't
> know that any *.changes file is from the same package that one is calling
> push-source on.

I see what you mean.

If there is a single pkg_*.changes containing binaries in the
build-products-dir, it is probably safe for dgit to use that to get a
list of the binary packages built by 'pkg'.  After all, this is only a
check to prevent mistakes, not a process which determines any of the
contents of uploads.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#903090: Want to spot source-only binaries-NEW upload to Debian

[Russ Allbery]

Sean Whitton  writes:
> On Sat 26 Oct 2019 at 03:54PM -07, Russ Allbery wrote:

>> For what it's worth, I also always follow a practice of running dgit
>> sbuild before dgit push-source, so dgit could have detected the binary
>> packages that way in theory, but I'm not sure if that's common.

> Wouldn't dgit have to connect to the Internet in order to perform the
> detection?

> I'm not sure we want a build command performing any connections.

My thought process was more that since I've run dgit sbuild, there's a
*.changes file that lists all the binary packages that the source builds.
But there probably isn't any reasonable way for push-source to be able to
use that *.changes file to know the binary package list, since it doesn't
know that any *.changes file is from the same package that one is calling
push-source on.

-- 
Russ Allbery (r...@debian.org)  

Bug#903090: Want to spot source-only binaries-NEW upload to Debian

[Sean Whitton]

Hello Russ,

On Sat 26 Oct 2019 at 03:54PM -07, Russ Allbery wrote:

> For what it's worth, I also always follow a practice of running dgit
> sbuild before dgit push-source, so dgit could have detected the binary
> packages that way in theory, but I'm not sure if that's common.

Wouldn't dgit have to connect to the Internet in order to perform the
detection?

I'm not sure we want a build command performing any connections.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#903090: Want to spot source-only binaries-NEW upload to Debian

[Russ Allbery]

Package: dgit
Version: 9.9
Followup-For: Bug #903090

For the purposes of tracking interest, I just ran into this problem with
a package that introduced a new binary package, and would also like dgit
to be able to detect this situation and warn me before doing a
push-source.  Parsing debian/control to get a list of built binaries
would work for my use case.

For what it's worth, I also always follow a practice of running dgit
sbuild before dgit push-source, so dgit could have detected the binary
packages that way in theory, but I'm not sure if that's common.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'unstable-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.2.0-3-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dgit depends on:
ii  apt1.8.4
ii  ca-certificates20190110
ii  coreutils  8.30-3+b1
ii  curl   7.66.0-1
ii  devscripts 2.19.6
ii  dpkg-dev   1.19.7
ii  dput-ng [dput] 1.28
ii  git [git-core] 1:2.23.0-1
ii  git-buildpackage   0.9.15
ii  libdpkg-perl   1.19.7
ii  libjson-perl   4.02000-1
ii  liblist-moreutils-perl 0.416-1+b5
ii  liblocale-gettext-perl 1.07-3+b5
ii  libtext-csv-perl   2.00-1
ii  libtext-glob-perl  0.10-1
ii  libtext-iconv-perl 1.7-6+b2
ii  libwww-curl-perl   4.17-6
ii  perl [libdigest-sha-perl]  5.30.0-6

Versions of packages dgit recommends:
ii  distro-info-data 0.42
ii  liburi-perl  1.76-1
ii  openssh-client [ssh-client]  1:8.1p1-1

Versions of packages dgit suggests:
ii  sbuild  0.78.1-2

-- no debconf information