Bug#903246: [pkg-cryptsetup-devel] Bug#903246:

2018-07-08 Thread Guilhem Moulin
Control: retitle -1 crypttab source specifications shouldn't be converted to 
/dev/block/$maj:$min
Control: severity -1 important
Control: tag -1 pending

On Sun, 08 Jul 2018 at 18:53:07 +1000, Ian Tester wrote:
> Upon further exploration, it appears the problem is that /dev/block is not
> being created and populated on this system. I'll have to figure out why
> that is. This report may be closed or at least knocked down in severity.

With a running udev daemon `udevadm trigger --type=devices --action=add`
creates and populates that directory.  This is done at early boot stage
and I'm not able to create a bootable environment where this is not the
case, so I'm lowering the severity to non-RC.

That being said there is no reason to convert the crypttab source
specifications to /dev/block/$maj:$min.  (We do want to do the
conversion when traversing the sysfs hierarchy, but for the crypttab
it's unnecessary.)  This commit should do it:


https://salsa.debian.org/cryptsetup-team/cryptsetup/commit/0d03f850113b3e5bd0d8211f0bc0161455e09368

-- 
Guilhem.


signature.asc
Description: PGP signature


Bug#903246: [pkg-cryptsetup-devel] Bug#903246:

2018-07-08 Thread Guilhem Moulin
Control: tag -1 moreinfo

On Sun, 08 Jul 2018 at 18:53:07 +1000, Ian Tester wrote:
> Upon further exploration, it appears the problem is that /dev/block is not
> being created and populated on this system. I'll have to figure out why
> that is.

Do you have udev installed and running?  It should take care of creating
/dev/block/$major:$minor, cf.

https://sources.debian.org/src/systemd/239-5/src/udev/udev-node.c/#L337

That being said, ‘cryptsetup-run’ is missing a dependency on the ‘udev’
package.  (OTOH ‘cryptsetup-initramfs’ pulls it in as ‘initramfs-tools’
depends on it.)  Also instead of using hardcoded ‘/dev/block/$major:$minor’
for source devices we should probably query

udevadm info -rq name /sys/dev/block/$major:$minor

(On your system, does the above command return the path to the source
device?)

-- 
Guilhem.


signature.asc
Description: PGP signature