Bug#905385: stretch-pu: package weboob/1.2-1
Quack, On 2020-06-17 02:32, Adam D. Barratt wrote: That's entirely your choice. I'll convert this request to a removal from oldstable, but if you do decide that you'd like to update it instead then please let us know ASAP. Thanks for the clarification. Please convert it to removal then. Regards. \_o< -- Marc Dequènes
Bug#905385: stretch-pu: package weboob/1.2-1
On Tue, 2020-06-16 at 18:05 +0900, Marc Dequènes (duck) wrote: > Quack, > > On 2020-06-16 04:37, Adam D. Barratt wrote: > > > We're now planning for the final point release for stretch before > > it moves to LTS support. Is this still something that you're > > (either of you) interested in fixing for stretch? > > Thanks for reaching out. > > Since a removal request was pushed forcefully I assumed it would > affect all suites. No, removal from unstable only affects that suite, and subsequently testing. For (old)stable, separate removal requests are needed. The package wasn't in testing at the point of the buster release, so isn't in stable, but is currently still in oldstable (and jessie, aka oldoldstable, but that's entirely unchangeable and will be archived soon). > Anyway I see no point in fixing the package instead of removal at > this stage, unless this is impossible to undesirable for the release > of course. That's entirely your choice. I'll convert this request to a removal from oldstable, but if you do decide that you'd like to update it instead then please let us know ASAP. Regards, Adam
Bug#905385: stretch-pu: package weboob/1.2-1
Quack, On 2020-06-16 04:37, Adam D. Barratt wrote: We're now planning for the final point release for stretch before it moves to LTS support. Is this still something that you're (either of you) interested in fixing for stretch? Thanks for reaching out. Since a removal request was pushed forcefully I assumed it would affect all suites. Anyway I see no point in fixing the package instead of removal at this stage, unless this is impossible to undesirable for the release of course. Regards. \_o< -- Marc Dequènes
Bug#905385: stretch-pu: package weboob/1.2-1
On Wed, 2018-08-29 at 15:25 +0100, Jonathan Dowland wrote: > Hello, > > On Wed, Aug 15, 2018 at 04:43:41PM +0900, Marc Dequènes wrote: > > Jonathan, if you still feel like giving a hand, then feel free to > > branch on the original repo with all the insult-removal patch > > needed, and please add the warning message as well. > > I've added the additional patch and disclaimer on top of this branch > in my fork, which is branched from the stretch version of the > package, and the changelog is set up ready for stretch-proposed- > updates: > > https://salsa.debian.org/jmtd/weboob/tree/905299-stretch > > If you are happy with this, can I suggest you create a branch for > stretch in the main repo and merge this in? > That is the last response in the bug log, which is mostly why this request has unfortunately sat in moreinfo limbo ever since. :-( We're now planning for the final point release for stretch before it moves to LTS support. Is this still something that you're (either of you) interested in fixing for stretch? Regards, Adam
Bug#905385: stretch-pu: package weboob/1.2-1
Hello, On Wed, Aug 15, 2018 at 04:43:41PM +0900, Marc Dequènes wrote: Jonathan, if you still feel like giving a hand, then feel free to branch on the original repo with all the insult-removal patch needed, and please add the warning message as well. I've added the additional patch and disclaimer on top of this branch in my fork, which is branched from the stretch version of the package, and the changelog is set up ready for stretch-proposed-updates: https://salsa.debian.org/jmtd/weboob/tree/905299-stretch If you are happy with this, can I suggest you create a branch for stretch in the main repo and merge this in? I've done a source-only build and put it here for your convenience https://jmtd.net/tmp/weboob_1.2-1+deb9u1.dsc (signed with my key) However I have not yet managed to convince sbuild to set up a stretch chroot and build binaries successfully (some pyqt4/5 issue, probably unrelated to these changes). So basically I think if you can take a look at my changes and if you are happy the ball is then back in the release team's court. Thanks, -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Jonathan Dowland ⢿⡄⠘⠷⠚⠋⠀ https://jmtd.net ⠈⠳⣄
Bug#905385: stretch-pu: package weboob/1.2-1
On Wed, Aug 15, 2018 at 04:43:41PM +0900, Marc Dequènes wrote: I finally found some spoons to upload a fixed package with insults removed and a warning in the description. I found an extra insult which is not in upstream master, so I added an extra patch; this might be needed for backporting too but better check with grep to avoid missing some around. Thanks! Jonathan, if you still feel like giving a hand, then feel free to branch on the original repo with all the insult-removal patch needed, and please add the warning message as well. Yes I do still want to help. So to be clear, I will rework the branches in my Salsa fork for stable and oldstable to backport the patch committed to sid, and do an additional grep-check for anything missing, then I'll ping you. Best wishes -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Jonathan Dowland ⢿⡄⠘⠷⠚⠋⠀ https://jmtd.net ⠈⠳⣄
Bug#905385: stretch-pu: package weboob/1.2-1
Quack, I finally found some spoons to upload a fixed package with insults removed and a warning in the description. I found an extra insult which is not in upstream master, so I added an extra patch; this might be needed for backporting too but better check with grep to avoid missing some around. Jonathan, if you still feel like giving a hand, then feel free to branch on the original repo with all the insult-removal patch needed, and please add the warning message as well. Regards. -- Marc Dequènes
Bug#905385: stretch-pu: package weboob/1.2-1
Quack, Just a quick reply to say, as stated on the ML, I agree with fixing all this. I'll have a look at it when back from DebConf/Taiwan. I'm glad to have help. Before any upload, I'd like to add a warning to the package description and backport it too if the release team does not object. \_o< -- Marc Dequènes (Duck)
Bug#905385: stretch-pu: package weboob/1.2-1
Hi Adam, Thank you for answering my questions and clarifying the finer points of s-p-u! On Fri, Aug 03, 2018 at 10:20:59PM +0100, Adam D. Barratt wrote: The metadata for that bug suggests that the issue still affects unstable. Assuming that's correct, that needs addressing first. (If it's not, the metadata should be updated with an appropriate fixed version.) That's right; sid is affected, and not fixed yet, but people are still recovering from DebConf I think :) As per the Dev Ref and (possibly too infrequent) dda reminders, the version should be (stable)+deb9u1, and the suite "stretch". Thank you. I didn't think to check dev ref, I consulted policy instead. I'd not use me as a benchmark as to whether the dda reminders are frequent enough, althoug I don't filter them so do theoretically read them, I've been slicing my Debian time very thin in recent times. oldstable (jessie) is no longer managed by the Release Team, but has been in the hands of the LTS team since mid-June, as per https://lists. debian.org/debian-security-announce/2018/msg00132.html Thank you, I'll investigate pursuing a jessie fix via LTS. There are no point releases for any release other than stretch at this point. oldoldstable (i.e. wheezy) has been entirely out of (LTS) support since the end of May this year Thank you. The guidance I was reading (policy possibly) only talked about whether the release was archived or not, and oldoldstable appears to not have been yet, despite it's LTS status. But in any case we shall just ignore oldoldstable for this bug. -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Jonathan Dowland ⢿⡄⠘⠷⠚⠋⠀ https://jmtd.net ⠈⠳⣄
Bug#905385: stretch-pu: package weboob/1.2-1
Control: tags -1 + moreinfo
Hi,
Not commenting on the specific patch at this point, but a few points of
procedure.
On Fri, 2018-08-03 at 22:08 +0100, Jonathan Dowland wrote:
> Filing this bug to open a dialogue with you about updating the weboob
> package in Stretch to fix #905299 ("includes homophobic comments and
> insults the user")
The metadata for that bug suggests that the issue still affects
unstable. Assuming that's correct, that needs addressing first. (If
it's not, the metadata should be updated with an appropriate fixed
version.)
> This has been fixed upstream. I've prepared an initial backported
> patch[1], but it needs updating to close the right bug number (this
> one),
Nope. The bug against release.d.o is closed by us once the package has
been included in a point release, not by the upload. The bug an upload
should be closing is #905299.
> possibly change the version number (I used NMU scheme so far),
> replace UNRELEASED with the correct suite (which is what for s-p-u?).
As per the Dev Ref and (possibly too infrequent) dda reminders, the
version should be (stable)+deb9u1, and the suite "stretch".
[...]
> This bug is also present in oldstable, and old-oldstable. I've done a
> preliminary patch for oldstable too[2], the same caveats apply. I
> intend to request an oldstable update in just the same way as I have
> here for Stretch.
oldstable (jessie) is no longer managed by the Release Team, but has
been in the hands of the LTS team since mid-June, as per https://lists.
debian.org/debian-security-announce/2018/msg00132.html
> Is old-oldstable archived? It appears not, but, are there any plans
> for another point release? In other words, should I file another bug
> to manage an old-oldstable update to fix this?
There are no point releases for any release other than stretch at this
point. oldoldstable (i.e. wheezy) has been entirely out of (LTS)
support since the end of May this year (c.f. https://www.debian.org/New
s/2018/20180601).
Regards,
Adam
Bug#905385: stretch-pu: package weboob/1.2-1
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu
Hello stable-release managers,
Filing this bug to open a dialogue with you about updating the weboob
package in Stretch to fix #905299 ("includes homophobic comments and
insults the user")
This has been fixed upstream. I've prepared an initial backported
patch[1], but it needs updating to close the right bug number (this
one), possibly change the version number (I used NMU scheme so far),
replace UNRELEASED with the correct suite (which is what for s-p-u?).
Once those are addressed, and assuming you approve in principle this
update, and also assuming the maintainers are in favour (CCed), I'll
attach the debdiff here.
Can/should we link this new bug with #905299 in some way (blocks:
relationship?)
This bug is also present in oldstable, and old-oldstable. I've done a
preliminary patch for oldstable too[2], the same caveats apply. I intend
to request an oldstable update in just the same way as I have here for
Stretch.
Is old-oldstable archived? It appears not, but, are there any plans for
another point release? In other words, should I file another bug to
manage an old-oldstable update to fix this?
[1]
https://salsa.debian.org/jmtd/weboob/commit/5feca16265b0ce689df1d1c0c4dd61f824af0c34
[2]
https://salsa.debian.org/jmtd/weboob/commit/1729299187743a45c08bf6c987d2f95581a9cad1
Thanks
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Jonathan Dowland
⢿⡄⠘⠷⠚⠋⠀ https://jmtd.net
⠈⠳⣄
