Bug#910867: inkscape: FTBFS with poppler 0.69.0-1
On 13/10/2018 12:58, Mattia Rizzolo wrote: > On Sat, Oct 13, 2018 at 12:45:04PM +0200, Emilio Pozuelo Monfort wrote: >> For the next ones do you mean in case poppler breaks the API again for >> buster? >> I.e. can you easily fix this bug? > > Yes, this one bug is already done locally, pending one last build… > I meant for further API breaks before the next inkscape upstream > release. Ack, no problem, and thanks for fixing this bug so quickly! Emilio
Bug#910867: inkscape: FTBFS with poppler 0.69.0-1
On Sat, Oct 13, 2018 at 12:45:04PM +0200, Emilio Pozuelo Monfort wrote: > For the next ones do you mean in case poppler breaks the API again for buster? > I.e. can you easily fix this bug? Yes, this one bug is already done locally, pending one last build… I meant for further API breaks before the next inkscape upstream release. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#910867: inkscape: FTBFS with poppler 0.69.0-1
On 13/10/2018 12:01, Mattia Rizzolo wrote: > On Fri, Oct 12, 2018 at 06:26:18PM +0200, Mattia Rizzolo wrote: >>> I intend to update our poppler soon as there are some security fixes >>> in the newer versions. I'd appreciate if you can take a look at this >>> and apply any necessary fixes. >> >> I'm guessing this upstream commit might help: >> https://gitlab.com/inkscape/inkscape/commit/402c0274420fe39fd2f3393bc7d8d8879d436358 > > It does. But be aware that the next patches won't be easily > cherry-pickable, as they did this: > https://gitlab.com/inkscape/inkscape/commit/0ab3449247d9356f57c75893e1ecfa195d43b681 > which conficts a lot with the current code in the released version. For the next ones do you mean in case poppler breaks the API again for buster? I.e. can you easily fix this bug? > As inkscape upstream wrote in https://bugs.launchpad.net/inkscape/+bug/1789208 >> Seriously poppler should consider having a deprecation period > It's very annoying also for me to cherry-pick all those patches just for > poppler, not even two months after the last one... Absolutely. I'll mention this to upstream. Cheers, Emilio
Bug#910867: inkscape: FTBFS with poppler 0.69.0-1
On Fri, Oct 12, 2018 at 06:26:18PM +0200, Mattia Rizzolo wrote: > > I intend to update our poppler soon as there are some security fixes > > in the newer versions. I'd appreciate if you can take a look at this > > and apply any necessary fixes. > > I'm guessing this upstream commit might help: > https://gitlab.com/inkscape/inkscape/commit/402c0274420fe39fd2f3393bc7d8d8879d436358 It does. But be aware that the next patches won't be easily cherry-pickable, as they did this: https://gitlab.com/inkscape/inkscape/commit/0ab3449247d9356f57c75893e1ecfa195d43b681 which conficts a lot with the current code in the released version. As inkscape upstream wrote in https://bugs.launchpad.net/inkscape/+bug/1789208 > Seriously poppler should consider having a deprecation period It's very annoying also for me to cherry-pick all those patches just for poppler, not even two months after the last one... -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#910867: inkscape: FTBFS with poppler 0.69.0-1
> Your package fails to build against poppler 0.69, currently in experimental. > In some cases there are patches in Ubuntu, the PTS has links. Hardly in ubuntu, they are using poppler 0.68, and they are in very deep freeze with the looming release :) > I intend to update our poppler soon as there are some security fixes > in the newer versions. I'd appreciate if you can take a look at this > and apply any necessary fixes. I'm guessing this upstream commit might help: https://gitlab.com/inkscape/inkscape/commit/402c0274420fe39fd2f3393bc7d8d8879d436358 I'll try it tomorrow. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
