Bug#912586: [Debian-med-packaging] Bug#912586:

[Afif Elghraoui]

على ٢٣‏/٢‏/١٤٤٠ هـ ‫١١:٠٤ م، كتب Michael Hudson-Doyle:



On Fri, 2 Nov 2018 at 15:30, Afif Elghraoui > wrote:




على ٢٣‏/٢‏/١٤٤٠ هـ ‫٩:٥٣ م، كتب Michael Hudson-Doyle:
 > I don't understand this change:
 >

https://salsa.debian.org/med-team/python-cobra/commit/1ec0fba3fea202b38044e3497edf033ef94a31e3
 >
 > AFAICT, it's just wrong. But maybe I'm missing something.
 >

At one point a long time ago, the test suite would return True if
successful, which translated into an exit code of 1 and interpreted as
failure. I don't know whether that's still the case.

Not according to the docs: 
https://docs.pytest.org/en/latest/usage.html#calling-pytest-from-python-code




Back in 2016, it looked like this:

https://github.com/opencobra/cobrapy/blob/515cbaa71de74823b3a0c9fcaeff839618d47207/cobra/test/__init__.py#L42

I'm just explaining the commit in the packaging repository because I 
authored it back then. Not saying it needs to stay that way.


Afif

Bug#912586: [Debian-med-packaging] Bug#912586:

[Michael Hudson-Doyle]

On Fri, 2 Nov 2018 at 15:30, Afif Elghraoui  wrote:

>
>
> على ٢٣‏/٢‏/١٤٤٠ هـ ‫٩:٥٣ م، كتب Michael Hudson-Doyle:
> > I don't understand this change:
> >
> https://salsa.debian.org/med-team/python-cobra/commit/1ec0fba3fea202b38044e3497edf033ef94a31e3
> >
> > AFAICT, it's just wrong. But maybe I'm missing something.
> >
>
> At one point a long time ago, the test suite would return True if
> successful, which translated into an exit code of 1 and interpreted as
> failure. I don't know whether that's still the case.
>
> Not according to the docs:
https://docs.pytest.org/en/latest/usage.html#calling-pytest-from-python-code

Cheers,
mwh

Bug#912586: [Debian-med-packaging] Bug#912586:

[Afif Elghraoui]

على ٢٣‏/٢‏/١٤٤٠ هـ ‫٩:٥٣ م، كتب Michael Hudson-Doyle:
I don't understand this change: 
https://salsa.debian.org/med-team/python-cobra/commit/1ec0fba3fea202b38044e3497edf033ef94a31e3


AFAICT, it's just wrong. But maybe I'm missing something.



At one point a long time ago, the test suite would return True if 
successful, which translated into an exit code of 1 and interpreted as 
failure. I don't know whether that's still the case.


regards
Afif

--
Afif Elghraoui | عفيف الغراوي
http://afif.ghraoui.name