Bug#912935: botch: the botch autopkgtest fails with Python 3.7
Ah you're right sorry, it took a few rounds to get it to pass in Ubuntu and I meant to follow up here and drop the ball. Sorry again! On Fri, 23 Nov 2018 at 03:51, Johannes Schauer wrote: > Hi , > > On Mon, 05 Nov 2018 15:23:39 +1300 Michael Hudson-Doyle < > mwhud...@debian.org> wrote: > > The botch autopkgtest fails with Python 3.7 as default, which is now the > > case in Ubuntu. Fortunately the reason is pretty trivial, patch > > attached. > > thanks for reporting this bug! > > But please, when supplying a patch, test the patch before you submit it or > otherwise I will spend time testing a patch even though it still results > in a > FTBFS due to the changes made in the patch. > > Alternatively, just point out that the patch you attached was not tested. > > Thanks! > > cheers, josch >
Bug#912935: botch: the botch autopkgtest fails with Python 3.7
Hi , On Mon, 05 Nov 2018 15:23:39 +1300 Michael Hudson-Doyle wrote: > The botch autopkgtest fails with Python 3.7 as default, which is now the > case in Ubuntu. Fortunately the reason is pretty trivial, patch > attached. thanks for reporting this bug! But please, when supplying a patch, test the patch before you submit it or otherwise I will spend time testing a patch even though it still results in a FTBFS due to the changes made in the patch. Alternatively, just point out that the patch you attached was not tested. Thanks! cheers, josch signature.asc Description: signature
Bug#912935: botch: the botch autopkgtest fails with Python 3.7
Source: botch
Version: 0.21-6
Severity: normal
Dear Maintainer,
The botch autopkgtest fails with Python 3.7 as default, which is now the
case in Ubuntu. Fortunately the reason is pretty trivial, patch
attached.
Cheers,
mwh
-- System Information:
Debian Release: buster/sid
APT prefers bionic-updates
APT policy: (500, 'bionic-updates'), (500, 'bionic-security'), (500,
'bionic'), (400, 'bionic-proposed'), (100, 'bionic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.15.0-38-generic (SMP w/4 CPU cores)
Locale: LANG=en_NZ.UTF-8, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8),
LANGUAGE=en_NZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Description: use the copy module directly
Not one that happened to be part of argpase in Python < 3.7
Author: Michale Hudson-Doyle
Origin: vendor
Last-Update: 2018-11-05
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/tools/dose2html.py
+++ b/tools/dose2html.py
@@ -5,6 +5,7 @@
from functools import cmp_to_key
import sys
import argparse
+import copy
sys.path.append('/usr/share/botch')
from util import write_plain, read_yaml_file, cmp, parse_dose_yaml_mc
from util import read_tag_file
@@ -499,7 +500,7 @@
**kwargs)
def __call__(self, parser, namespace, values, option_string=None):
-items = argparse._copy.copy(argparse._ensure_value(namespace,
+items = copy.copy(argparse._ensure_value(namespace,
self.dest, []))
items.extend(values)
setattr(namespace, self.dest, items)
