Bug#913508: nodejs FTBFS with ICU 63.1

[Jérémy Lal]

Package: src:nodejs
Followup-For: Bug #913508
Control: fixed -1 10.15.0~dfsg-6

This has been fixed in nodejs 10.


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), 
LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Bug#913508: nodejs FTBFS with ICU 63.1

[Jérémy Lal]

Package: src:nodejs
Followup-For: Bug #913508

I believe this is fixed however i'll let the reporter close the bug,
because i'm not sure i understand perfectly the original bug report.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), 
LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Bug#913508: [Pkg-javascript-devel] Bug#913508: nodejs FTBFS with ICU 63.1

[Jérémy Lal]

Le dim. 11 nov. 2018 à 20:15, László Böszörményi  a écrit :

> Source: nodejs
> Source-Version: 8.11.2~dfsg-1
> Severity: important
> Tags: patch
> Usertags: icu63
>
> Dear Maintainer,
>
> ICU 63.1 recently released, packaged and uploaded to experimental.
> Its transition is going to start soon. However your package fails to
> build with this version. I attach a patch which fixes the problem.
> Please check if it works with the version in Sid and upload the
> package when it's feasible for you.
>

Thank you.
However nodejs 10.13.0, waiting in NEW/experimental, already fixes the issue
and will be uploaded to unstable as soon as it works all right in
experimental.

Jérémy

Bug#913508: nodejs FTBFS with ICU 63.1

[GCS]

Source: nodejs
Source-Version: 8.11.2~dfsg-1
Severity: important
Tags: patch
Usertags: icu63

Dear Maintainer,

ICU 63.1 recently released, packaged and uploaded to experimental.
Its transition is going to start soon. However your package fails to
build with this version. I attach a patch which fixes the problem.
Please check if it works with the version in Sid and upload the
package when it's feasible for you.

Thanks,
Laszlo/GCS
Description: fix FTBFS with ICU 63.1
 Add icu namespace.
Author: Laszlo Boszormenyi (GCS) 
Last-Update: 2018-11-04

---

--- nodejs-8.11.2~dfsg.orig/src/inspector_io.cc
+++ nodejs-8.11.2~dfsg/src/inspector_io.cc
@@ -74,11 +74,11 @@ std::string StringViewToUtf8(const Strin
 
   size_t result_length = view.length() * sizeof(*source);
   std::string result(result_length, '\0');
-  UnicodeString utf16(unicodeSource, view.length());
+  icu::UnicodeString utf16(unicodeSource, view.length());
   // ICU components for std::string compatibility are not enabled in build...
   bool done = false;
   while (!done) {
-CheckedArrayByteSink sink(&result[0], result_length);
+icu::CheckedArrayByteSink sink(&result[0], result_length);
 utf16.toUTF8(sink);
 result_length = sink.NumberOfBytesAppended();
 result.resize(result_length);
@@ -111,8 +111,8 @@ void ReleasePairOnAsyncClose(uv_handle_t
 }  // namespace
 
 std::unique_ptr Utf8ToStringView(const std::string& message) {
-  UnicodeString utf16 =
-  UnicodeString::fromUTF8(StringPiece(message.data(), message.length()));
+  icu::UnicodeString utf16 =
+  icu::UnicodeString::fromUTF8(icu::StringPiece(message.data(), message.length()));
   StringView view(reinterpret_cast(utf16.getBuffer()),
   utf16.length());
   return StringBuffer::create(view);
--- nodejs-8.11.2~dfsg.orig/src/node_i18n.cc
+++ nodejs-8.11.2~dfsg/src/node_i18n.cc
@@ -523,7 +523,7 @@ const char* GetVersion(const char* type,
   } else if (!strcmp(type, TYPE_UNICODE)) {
 return U_UNICODE_VERSION;
   } else if (!strcmp(type, TYPE_TZ)) {
-return TimeZone::getTZDataVersion(*status);
+return icu::TimeZone::getTZDataVersion(*status);
   } else if (!strcmp(type, TYPE_CLDR)) {
 UVersionInfo versionArray;
 ulocdata_getCLDRVersion(versionArray, status);