Bug#913594: [apt-cacher-ng] Vcs-Git field lacks branch information

2018-11-13 Thread James McCoy
Control: reassign -1 apt-cacher-ng 3.2-1

On Tue, Nov 13, 2018 at 12:42:59PM +0100, Eduard Bloch wrote:
> Hallo,
> * Jens Reyer [Mon, Nov 12 2018, 08:19:27PM]:
> > https://tracker.debian.org/pkg/apt-cacher-ng believes that the git repo
> > is outdated, because it's looking at branch master instead of debian/sid.
> > 
> > To fix either adapt the salsa project, or debian/control.
> > 
> > Patch for the latter solution is attached.
> 
> Cannot confirm. Clicking "VCS: Git (Browse" leads to the correct branch.

That's because Vcs-Browse in debian/control points to the debian/sid
branch.  Vcs-Git does not.

Either the repo on Salsa should be configured to make debian/sid the
default branch, in which case Vcs-Browse can lose the branch
information, or Vcs-Git should use "-b debian/sid" as documented in
policy[0] and supported by the tools that understand Vcs-*.

[0]: 
https://www.debian.org/doc/debian-policy/ch-controlfields.html#version-control-system-vcs-fields

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB



Bug#913594: [apt-cacher-ng] Vcs-Git field lacks branch information

2018-11-13 Thread Eduard Bloch
reassign 913594 tracker.debian.org
thanks

Hallo,
* Jens Reyer [Mon, Nov 12 2018, 08:19:27PM]:
> Package: apt-cacher-ng
> Version: 3.2-1
> Severity: minor
> Tags: patch
> 
> Hi,
> 
> https://tracker.debian.org/pkg/apt-cacher-ng believes that the git repo
> is outdated, because it's looking at branch master instead of debian/sid.
> 
> To fix either adapt the salsa project, or debian/control.
> 
> Patch for the latter solution is attached.

Cannot confirm. Clicking "VCS: Git (Browse" leads to the correct branch.

And injecting git CLI parameters is not a solution, a bad kludge at best.

Reassigning to tracker - please teach the scanner to consider branches.

BR, Eduard.



Bug#913594: [apt-cacher-ng] Vcs-Git field lacks branch information

2018-11-12 Thread Jens Reyer
Package: apt-cacher-ng
Version: 3.2-1
Severity: minor
Tags: patch

Hi,

https://tracker.debian.org/pkg/apt-cacher-ng believes that the git repo
is outdated, because it's looking at branch master instead of debian/sid.

To fix either adapt the salsa project, or debian/control.

Patch for the latter solution is attached.

Thanks for apt-cacher-ng
Greets
jre
diff --git a/debian/control b/debian/control
index 9e6f616..e4834bc 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,7 @@ Maintainer: Eduard Bloch 
 Build-Depends: debhelper (>= 9), cmake (>= 2.6.2), libbz2-dev, zlib1g-dev, liblzma-dev, libfuse-dev [!hurd-i386], pkg-config, libwrap0-dev, lsb-base (>> 3.0-6), debhelper (>= 9.20160709) | dh-systemd (>= 1.5), po-debconf, libssl-dev, libsystemd-dev (>= 210) [linux-any] | libsystemd-daemon-dev [linux-any]
 Standards-Version: 4.1.1
 Homepage: http://www.unix-ag.uni-kl.de/~bloch/acng/
-Vcs-Git: https://salsa.debian.org/blade/apt-cacher-ng.git
+Vcs-Git: https://salsa.debian.org/blade/apt-cacher-ng.git -b debian/sid
 Vcs-Browser: https://salsa.debian.org/blade/apt-cacher-ng/tree/debian/sid
 
 Package: apt-cacher-ng