Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
Quack, On 2019-03-04 19:08, Stuart Caie wrote: How odd, but yes, I have a system where size_t = unsigned int, so it went unnoticed. I've fixed it and tested it on both the 32bit system and a 64bit system. Maybe gcc is too picky, I have no idea. I've released libmspack 0.10.1 Thanks a lot :-). \_o< -- Marc Dequènes
Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
On 04/03/2019 05:00, Marc Dequènes (duck) wrote: Quack, On 2019-03-04 10:40, Stuart Caie wrote: I've released libmspack 0.10 and cabextract 1.9.1. They contain only fixes. Thanks a lot for being so fast. Unfortunately there is a build problem: How odd, but yes, I have a system where size_t = unsigned int, so it went unnoticed. I've fixed it and tested it on both the 32bit system and a 64bit system. I've released libmspack 0.10.1 Regards Stuart
Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
Quack, On 2019-03-04 10:40, Stuart Caie wrote: I've released libmspack 0.10 and cabextract 1.9.1. They contain only fixes. Thanks a lot for being so fast. Unfortunately there is a build problem: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./mspack -I./test -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wno-unused-parameter -Wno-unused-result -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -c mspack/oabd.c -fPIC -DPIC -o mspack/.libs/oabd.o mspack/oabd.c:375:12: error: conflicting types for ‘copy_fh’ static int copy_fh(struct mspack_system *sys, struct mspack_file *infh, ^~~ mspack/oabd.c:37:12: note: previous declaration of ‘copy_fh’ was here static int copy_fh(struct mspack_system *sys, struct mspack_file *infh, ^~~ Indeed `bytes_to_copy` is not of the same type. Regards. -- Marc Dequènes
Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
On 03/03/2019 04:47, Marc Dequènes (duck) wrote: Quack, On 2018-12-04 19:02, Stuart Caie wrote: This is fixed in the repository, it just hasn't been released. I'll release it in the near future. I was myself busy and we missed the Debian freeze deadline. Maybe there is still some hope to convince the release team for an exception, as long as we push fixes only. Any plan to release shortly? I've released libmspack 0.10 and cabextract 1.9.1. They contain only fixes. Regards Stuart
Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
Quack, On 2018-12-04 19:02, Stuart Caie wrote: This is fixed in the repository, it just hasn't been released. I'll release it in the near future. I was myself busy and we missed the Debian freeze deadline. Maybe there is still some hope to convince the release team for an exception, as long as we push fixes only. Any plan to release shortly? \_o< -- Marc Dequènes
Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
On 04/12/2018 05:35, Marc Dequènes (duck) wrote: libmspack fails tests on big endian architectures (s390x, mips) This is fixed in the repository, it just hasn't been released. I'll release it in the near future. commit c19e707936947b45cf05bc9aaee68517c6c2aca6 Author: Stuart Caie Date: Thu Nov 8 11:58:45 2018 + Add AC_C_BIGENDIAN so md5.c works on big-endian systems without manually setting WORDS_BIGENDIAN commit 80fb91f3680f5acf96fd372b95c9b6205e0e9cbf (tag: v0.9.1alpha) Author: Stuart Caie Date: Tue Nov 6 11:28:26 2018 + Re-release 0.9alpha as 0.9.1alpha with the doc/ directory re-included in distribution Regards Stuart
Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
Quack, Hello Stuart, here is a problem you might want to look at: On 2018-11-27 20:09, Matthias Klose wrote: Package: src:libmspack Version: 0.9.1-1 Severity: serious Tags: sid buster libmspack fails tests on big endian architectures (s390x, mips) make check-TESTS make[2]: Entering directory '/<>' make[3]: Entering directory '/<>' FAIL: test/cabd_test PASS: test/chmd_test PASS: test/kwajd_test libmspack 0.9.1alpha: ./test-suite.log # TOTAL: 3 # PASS: 2 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test/cabd_test /<>/test/test_files/cabd/bad_nofolders.cab: no folders in cabinet. /<>/test/test_files/cabd/bad_nofiles.cab: no files in cabinet. ERROR; file "2" cannot be extracted, cabinet set is incomplete cabd_extract_test_03:391 FAILED memcmp(md5_string, "940cba86658fbceb582faecd2b5975d1", 33) == 0 FAIL test/cabd_test (exit status: 1) Testsuite summary for libmspack 0.9.1alpha # TOTAL: 3 # PASS: 2 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 See ./test-suite.log Please report to ky...@cabextract.org.uk make[3]: *** [Makefile:1278: test-suite.log] Error 1 make[3]: Leaving directory '/<>' make[2]: *** [Makefile:1386: check-TESTS] Error 2 make[2]: Leaving directory '/<>' make[1]: *** [Makefile:1607: check-am] Error 2 make[1]: Leaving directory '/<>' dh_auto_test: make -j2 check VERBOSE=1 returned exit code 2 make: *** [debian/rules:7: build-arch] Error 2 You can see full logs here: https://buildd.debian.org/status/package.php?p=libmspack Regards. \_o< -- Marc Dequènes
Bug#914794: libmspack fails tests on big endian architectures (s390x, mips)
Package: src:libmspack Version: 0.9.1-1 Severity: serious Tags: sid buster libmspack fails tests on big endian architectures (s390x, mips) make check-TESTS make[2]: Entering directory '/<>' make[3]: Entering directory '/<>' FAIL: test/cabd_test PASS: test/chmd_test PASS: test/kwajd_test libmspack 0.9.1alpha: ./test-suite.log # TOTAL: 3 # PASS: 2 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test/cabd_test /<>/test/test_files/cabd/bad_nofolders.cab: no folders in cabinet. /<>/test/test_files/cabd/bad_nofiles.cab: no files in cabinet. ERROR; file "2" cannot be extracted, cabinet set is incomplete cabd_extract_test_03:391 FAILED memcmp(md5_string, "940cba86658fbceb582faecd2b5975d1", 33) == 0 FAIL test/cabd_test (exit status: 1) Testsuite summary for libmspack 0.9.1alpha # TOTAL: 3 # PASS: 2 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 See ./test-suite.log Please report to ky...@cabextract.org.uk make[3]: *** [Makefile:1278: test-suite.log] Error 1 make[3]: Leaving directory '/<>' make[2]: *** [Makefile:1386: check-TESTS] Error 2 make[2]: Leaving directory '/<>' make[1]: *** [Makefile:1607: check-am] Error 2 make[1]: Leaving directory '/<>' dh_auto_test: make -j2 check VERBOSE=1 returned exit code 2 make: *** [debian/rules:7: build-arch] Error 2
