Bug#915919: mixxx: Uses vendor-specific patch series file (ubuntu.series)

2018-12-23 Thread Jeremy Bicha
It looks like the only patch that is intentionally different between
Debian and Ubuntu is that 0002-desktop_file.patch is not applied on
Ubuntu.

I think that patch could be either removed or applied on Ubuntu too.

If you decide you do want to continue to have different behavior on
Ubuntu, you could use something like
https://salsa.debian.org/desktop-themes-team/numix-gtk-theme/commit/488a7f83
instead.

Thanks,
Jeremy Bicha



Bug#915919: mixxx: Uses vendor-specific patch series file (ubuntu.series)

2018-12-07 Thread Chris Lamb
Source: mixxx
Version: 2.1.5~dfsg-1
Severity: important
User: la...@debian.org
Usertags: package-uses-vendor-specific-patch-series

Dear Maintainer,

mixxx appears to use a vendor-specific patch series file:

  debian/patches/ubuntu.series

This is feature of dpkg that can be used to apply a different series
of quilt patches when the source package is unpacked on different
systems. However, since Debian source packages are usually treated as
a pure transport format this can cause confusion and frustration.

Please migrate away from such series files and consider alternatives
such differing source packages or modify the build process to behave
conditionally or to conditionally patch files explicitly.

After Buster is released, the presence of a vendor-specific patch
series will be a violation of a MUST directive in Debian policy.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-