Bug#915978: devscripts: salsa error Unknown command fork

2018-12-09 Thread Xavier
Le 09/12/2018 à 04:18, Dmitry Bogatov a écrit :
> Package: devscripts
> Version: 2.18.11
> Severity: normal
> 
> Dear Maintainer,
> 
> I installed devscripts/experimental to get `salsa' script and did
> following:
> 
>  $ salsa fork lintian/lintian --verbose
> 
> and got this:
> 
>  salsa error Unknown command fork
>  salsa info: Can't locate Devscripts/Salsa/chechout.pm in @INC (you may need 
> to install the Devscripts::Salsa::chechout module) (@INC contains: /etc/perl 
> /usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1 
> /usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5 
> /usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28 
> /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at 
> /usr/share/perl5/Module/Runtime.pm line 314.
>   at /usr/share/perl5/Devscripts/Salsa/fork.pm line 9.
>  Compilation failed in require at /usr/share/perl5/Module/Runtime.pm line 314.

Hello,

sorry for this stupid bug introduced during a function rename. Here is
the fix if you want to continue to test:

--- a/usr/share/perl5/Devscripts/Salsa/fork.pm
+++ b/usr/share/perl5/Devscripts/Salsa/fork.pm
@@ -6,7 +6,7 @@ use Devscripts::Output;
 use Dpkg::IPC;
 use Moo::Role;

-with 'Devscripts::Salsa::chechout';
+with 'Devscripts::Salsa::checkout';

 sub fork {
 my ($self, $project) = @_;
@@ -14,7 +14,7 @@ sub fork {
 $self->api->fork_project($project, { namespace => $path });
 my $p = $project;
 $p =~ s#.*/##;
-$self->chechout($p);
+$self->checkout($p);
 chdir $p;
 spawn(
 exec => [
> 
> According to salsa(1) it is valid:
> 
>  fork
> Forks a project in group/user repository and set "upstream" to
> original project. Example:
> 
>   $ salsa fork js-team/node-mongodb --verbose
>   ...
>   salsa.pl info: node-mongodb ready in node-mongodb/
>   $ cd node-mongodb
>   $ git remote --verbose show
>   origin  g...@salsa.debian.org:me/node-mongodb (fetch)
>   origin  g...@salsa.debian.org:me/node-mongodb (push)
>   upstreamg...@salsa.debian.org:js-team/node-mongodb (fetch)
>   upstreamg...@salsa.debian.org:js-team/node-mongodb (push)
> 
> For a group:
> 
>   salsa fork --group js-team user/node-foo
> 
> Oh, and by the way, it is quite unfortunate, that reportbug by default
> insert content of ~/.devscripts into bugreport. It could contain quite
> sensible SALSA_TOKEN. Not sure, whether it is bug in devscripts or
> reportbug.

Sure it's a bug. Report it against devscripts, then if needed we will
reassign it.

Thanks to take time to test salsa !

Cheers,
Xavier



Bug#915978: devscripts: salsa error Unknown command fork

2018-12-08 Thread Dmitry Bogatov
Package: devscripts
Version: 2.18.11
Severity: normal

Dear Maintainer,

I installed devscripts/experimental to get `salsa' script and did
following:

 $ salsa fork lintian/lintian --verbose

and got this:

 salsa error Unknown command fork
 salsa info: Can't locate Devscripts/Salsa/chechout.pm in @INC (you may need to 
install the Devscripts::Salsa::chechout module) (@INC contains: /etc/perl 
/usr/local/lib/x86_64-linux-gnu/perl/5.28.1 /usr/local/share/perl/5.28.1 
/usr/lib/x86_64-linux-gnu/perl5/5.28 /usr/share/perl5 
/usr/lib/x86_64-linux-gnu/perl/5.28 /usr/share/perl/5.28 
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at 
/usr/share/perl5/Module/Runtime.pm line 314.
  at /usr/share/perl5/Devscripts/Salsa/fork.pm line 9.
 Compilation failed in require at /usr/share/perl5/Module/Runtime.pm line 314.

According to salsa(1) it is valid:

 fork
Forks a project in group/user repository and set "upstream" to
original project. Example:

  $ salsa fork js-team/node-mongodb --verbose
  ...
  salsa.pl info: node-mongodb ready in node-mongodb/
  $ cd node-mongodb
  $ git remote --verbose show
  origin  g...@salsa.debian.org:me/node-mongodb (fetch)
  origin  g...@salsa.debian.org:me/node-mongodb (push)
  upstreamg...@salsa.debian.org:js-team/node-mongodb (fetch)
  upstreamg...@salsa.debian.org:js-team/node-mongodb (push)

For a group:

  salsa fork --group js-team user/node-foo

Oh, and by the way, it is quite unfortunate, that reportbug by default
insert content of ~/.devscripts into bugreport. It could contain quite
sensible SALSA_TOKEN. Not sure, whether it is bug in devscripts or
reportbub.

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
SALSA_TOKEN=$(pass access/git/salsa.debian.org/kaction | awk 'NR == 2 { print 
$2 }')

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
C.UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to C.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)
LSM: AppArmor: enabled

Versions of packages devscripts depends on:
ii  dpkg-dev  1.19.2
ii  fakeroot  1.23-1
ii  file  1:5.34-2
ii  gnupg 2.2.11-1
ii  gnupg22.2.11-1
ii  gpgv  2.2.11-1
ii  libc6 2.28-2
ii  libfile-homedir-perl  1.004-1
ii  libfile-which-perl1.22-1
ii  libipc-run-perl   20180523.0-1
ii  libmoo-perl   2.003004-2
ii  libwww-perl   6.36-1
ii  patchutils0.3.4-2
ii  perl  5.28.1-3
ii  python3   3.7.1-2
ii  sensible-utils0.0.12
ii  wdiff 1.2.2-2+b1

Versions of packages devscripts recommends:
ii  apt 1.8.0~alpha2
pn  at  
ii  curl7.62.0-1
ii  dctrl-tools 2.24-3
pn  debian-keyring  
ii  dput1.0.2
ii  equivs  2.2.0
ii  libdistro-info-perl 0.20
ii  libdpkg-perl1.19.2
ii  libencode-locale-perl   1.05-1
ii  libgit-wrapper-perl 0.048-1
ii  libgitlab-api-v4-perl   0.13-1
ii  liblist-compare-perl0.53-1
ii  liblwp-protocol-https-perl  6.07-2
pn  libsoap-lite-perl   
ii  libstring-shellquote-perl   1.04-1
ii  libtry-tiny-perl0.30-1
ii  liburi-perl 1.74-1
pn  licensecheck
ii  lintian 2.5.116
ii  man-db  2.8.4-3
ii  patch   2.7.6-3
ii  python3-apt 1.7.0
ii  python3-debian  0.1.33
ii  python3-magic   2:0.4.15-2
ii  python3-requests2.20.0-2
ii  python3-unidiff 0.5.4-1
ii  python3-xdg 0.25-4
ii  strace  4.21-1
ii  unzip   6.0-21
ii  wget1.19.5-2
ii  xz-utils5.2.2-1.3

Versions of packages devscripts suggests:
pn  adequate 
pn  autopkgtest  
pn  bls-standalone   
ii  bsd-mailx [mailx]8.1.2-0.20180807cvs-1
ii  build-essential  12.5
pn  check-all-the-things 
pn  cvs-buildpackage 
pn  devscripts-el
ii  diffoscope   107
pn  disorderfs   
pn  dose-extra   
pn  duck 
ii  faketime 0.9.7-3
pn  gnuplot  
pn  how-can-i-help   
pn  libauthen-sasl-perl  
pn  libdbd-pg-perl   
ii  libfile-desktopentry-perl0.22-1
pn  libnet-smtps-perl