Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Sat, 12 Jan 2019 12:51:41 +0100, Andreas Beckmann wrote: > On 2019-01-12 12:42, Otto Kekäläinen wrote: > > Now with the mysql version fixed the mariadb version regressed. Does any of > > you spot what is the failure cause in > > https://ci.debian.net/data/autopkgtest/testing/amd64/libd/libdbd-mariadb-perl/1690599/log.gz > > ? > > not ok 16 - warning is correct > # Failed test 'warning is correct' > # at t/55utf8.t line 83. > # 'Incorrect string value: '\xC4\x80dam' for column > `testdb`.`dbd_mysql_t55utf8`.`ascii` at row 1' > # doesn't match '(?^:^(?:Incorrect string value: '\\xC4\\x80dam'|Data > truncated) for column 'ascii' at row 1$)' > > not ok 58 - warning is correct > # Failed test 'warning is correct' > # at t/55utf8.t line 83. > # 'Incorrect string value: '\xC4\x80dam' for column > `testdb`.`dbd_mysql_t55utf8`.`ascii` at row 1' > # doesn't match '(?^:^(?:Incorrect string value: '\\xC4\\x80dam'|Data > truncated) for column 'ascii' at row 1$)' > > The column name is now prefixed with `testdb`.`dbd_mysql_t55utf8`. and > quoted as `ascii` instead of 'ascii' Thanks for noticing. I've filed this as a separate bug against libdbd-mariadb-perl in Debian and DBD-MariaDB upstream: https://bugs.debian.org/919071 https://github.com/gooddata/DBD-MariaDB/issues/121 Please continue the discussion there. (Note that adjusting the regexp for the expected message is no big deal but I'd rather have upstream take a look at this first.) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Eagles signature.asc Description: Digital Signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Now with the mysql version fixed the mariadb version regressed. Does any of you spot what is the failure cause in https://ci.debian.net/data/autopkgtest/testing/amd64/libd/libdbd-mariadb-perl/1690599/log.gz ? MariaDB 10.3 overview at https://tracker.debian.org/pkg/mariadb-10.3 Otto Kekäläinen kirjoitti ti 8. tammik. 2019 klo 22.40: > For the records of this bug report and people following it, there are a > lot of discussions going on in both > https://github.com/perl5-dbi/DBD-mysql/issues/275 and > https://github.com/MariaDB/mariadb-connector-c/pull/95 > > I will now import MariaDB 10.3.12 into > https://salsa.debian.org/mariadb-team/mariadb-10.3 but postpone uploading > it for now in case the issues above might produce something that we can > backport and patch upon the mariadb-10.3 packaging in Debian to help fix > the issue in Debian. Personally I cannot follow all the details in the > Github issues above, so please let me know if something actionable on my > side emerges (e.g. patches as mentioned). >
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On 2019-01-12 12:42, Otto Kekäläinen wrote: > Now with the mysql version fixed the mariadb version regressed. Does any of > you spot what is the failure cause in > https://ci.debian.net/data/autopkgtest/testing/amd64/libd/libdbd-mariadb-perl/1690599/log.gz > ? not ok 16 - warning is correct # Failed test 'warning is correct' # at t/55utf8.t line 83. # 'Incorrect string value: '\xC4\x80dam' for column `testdb`.`dbd_mysql_t55utf8`.`ascii` at row 1' # doesn't match '(?^:^(?:Incorrect string value: '\\xC4\\x80dam'|Data truncated) for column 'ascii' at row 1$)' not ok 58 - warning is correct # Failed test 'warning is correct' # at t/55utf8.t line 83. # 'Incorrect string value: '\xC4\x80dam' for column `testdb`.`dbd_mysql_t55utf8`.`ascii` at row 1' # doesn't match '(?^:^(?:Incorrect string value: '\\xC4\\x80dam'|Data truncated) for column 'ascii' at row 1$)' The column name is now prefixed with `testdb`.`dbd_mysql_t55utf8`. and quoted as `ascii` instead of 'ascii' Andreas
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Hi Otto, On Tue, 8 Jan 2019 21:40:54 +0100 =?UTF-8?B?T3R0byBLZWvDpGzDpGluZW4=?= wrote: > I will now import MariaDB 10.3.12 into > https://salsa.debian.org/mariadb-team/mariadb-10.3 but postpone uploading > it for now in case the issues above might produce something that we can > backport and patch upon the mariadb-10.3 packaging in Debian to help fix > the issue in Debian. Personally I cannot follow all the details in the > Github issues above, so please let me know if something actionable on my > side emerges (e.g. patches as mentioned). Please make sure you add a versioned Breaks on libdbd-mysql-perl somewhere in one of the right MariaDb binary packages. Apart from mariadb-10.3 apparently breaking it (AFAIU) that will also ensure that the libdbd-mysql-perl autopkgtest for the mariadb package will be taken from unstable instead of testing. Paul signature.asc Description: OpenPGP digital signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Tue, 08 Jan 2019 21:40:54 +0100, Otto Kekäläinen wrote: > For the records of this bug report and people following it, there are a lot > of discussions going on in both > https://github.com/perl5-dbi/DBD-mysql/issues/275 and > https://github.com/MariaDB/mariadb-connector-c/pull/95 The changes from the DBD-mysql issue were merged into master and a new version release. And indeed the tests pass during build and autopkgtest, so I've uploaded 4.050-1 to unstable, closing this bug. Credits go to Daniël van Eeden. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Sinéad O'Connor: 'Til I Whisper U Something signature.asc Description: Digital Signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
For the records of this bug report and people following it, there are a lot of discussions going on in both https://github.com/perl5-dbi/DBD-mysql/issues/275 and https://github.com/MariaDB/mariadb-connector-c/pull/95 I will now import MariaDB 10.3.12 into https://salsa.debian.org/mariadb-team/mariadb-10.3 but postpone uploading it for now in case the issues above might produce something that we can backport and patch upon the mariadb-10.3 packaging in Debian to help fix the issue in Debian. Personally I cannot follow all the details in the Github issues above, so please let me know if something actionable on my side emerges (e.g. patches as mentioned).
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Hi Otto, it doesn't make sense to zero a pointer, if the container (or speaking of C: structure) is freed afterwards. The documentation clearly states, that a handle (which was previously freed by mysql_close() ) needs to be initialized again. The pull request fixes the perl test case, but it didn't fix perl itself, which still abuses internal members of the connector, which are considered to be opaque. (And being opaque is the goal for next major release). /Georg On Mon, Jan 7, 2019 at 8:40 PM Otto Kekäläinen wrote: > Hello! > > gregor herrmann kirjoitti pe 4. tammikuuta 2019 klo > 1.23: > >> On Thu, 03 Jan 2019 22:04:48 +0200, Otto Kekäläinen wrote: >> >> > Just checking: are you Georg or Gregor currently working on this >> > issue, and do you have any estimate when we could expect either a >> > patch to MariaDB Connector C or a new upload of DBD-mysql so this >> > issue would be resolved? >> >> I had a look at DBD::mysql and DBD::MariaDB but without any success. >> I hope that someone with a better understanding than me from the >> Debian perl Group can try and find a solution. >> >> I've now pinged the upstream issue at: >> https://github.com/perl5-dbi/DBD-mysql/issues/275 > > > Thanks Gregor for working with upstreams to fix this. Nice Eric Herman was > also involved ;) > > Georg Richter, I hope you can review > https://github.com/MariaDB/mariadb-connector-c/pull/95 shortly, thanks! > > >> -- Georg Richter, Senior Software Engineer MariaDB Corporation Ab
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Hello! gregor herrmann kirjoitti pe 4. tammikuuta 2019 klo 1.23: > On Thu, 03 Jan 2019 22:04:48 +0200, Otto Kekäläinen wrote: > > > Just checking: are you Georg or Gregor currently working on this > > issue, and do you have any estimate when we could expect either a > > patch to MariaDB Connector C or a new upload of DBD-mysql so this > > issue would be resolved? > > I had a look at DBD::mysql and DBD::MariaDB but without any success. > I hope that someone with a better understanding than me from the > Debian perl Group can try and find a solution. > > I've now pinged the upstream issue at: > https://github.com/perl5-dbi/DBD-mysql/issues/275 Thanks Gregor for working with upstreams to fix this. Nice Eric Herman was also involved ;) Georg Richter, I hope you can review https://github.com/MariaDB/mariadb-connector-c/pull/95 shortly, thanks! >
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Fri, 04 Jan 2019 16:07:19 +0100, p...@cpan.org wrote: > Or... how many packages depends on libdbd-mysql-perl? > Cannot be they migrated to libdbd-mariadb-perl? Maybe the packages could be migrated (although I'm a bit skeptical that we would be able to catch all issues) but libdbd-mysql-perl is also widely used in third-party code and projects written by users. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Bruce Springsteen: Jungleland signature.asc Description: Digital Signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Sat, 05 Jan 2019 13:33:01 +0200, Otto Kekäläinen wrote: > Since this is holding back mariadb-10.3 from entering Debian Testing, > and the transition freeze will start on Jan 14th, could you consider > uploading an intermediate version with autopkgtest disabled or skipped > in some way so that this test passes? Disabling the failing tests during autopkgtests wouldn't help, as they fail in the same way during build. And disabling them during build seems wrong to me as they are the result of an actual bug. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Rolling Stones: Sweetblack signature.asc Description: Digital Signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
pe 4. tammik. 2019 klo 18.31 gregor herrmann (gre...@debian.org) kirjoitti: > > On Fri, 04 Jan 2019 00:22:54 +0100, gregor herrmann wrote: > > > I've now pinged the upstream issue at: > > https://github.com/perl5-dbi/DBD-mysql/issues/275 > > And they plan to try and fix the issue: > https://github.com/perl5-dbi/DBD-mysql/issues/275#issuecomment-451438094 Thanks for the update! Since this is holding back mariadb-10.3 from entering Debian Testing, and the transition freeze will start on Jan 14th, could you consider uploading an intermediate version with autopkgtest disabled or skipped in some way so that this test passes? You can then re-enable it once upstream publishes a new version of dbd-mysql. See https://tracker.debian.org/pkg/mariadb-10.3
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Fri, 04 Jan 2019 00:22:54 +0100, gregor herrmann wrote: > I've now pinged the upstream issue at: > https://github.com/perl5-dbi/DBD-mysql/issues/275 And they plan to try and fix the issue: https://github.com/perl5-dbi/DBD-mysql/issues/275#issuecomment-451438094 Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Ry Cooder: Theme From Southern Comfort signature.asc Description: Digital Signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Or... how many packages depends on libdbd-mysql-perl? Cannot be they migrated to libdbd-mariadb-perl?
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Hello! The main problem is that DBD::mysql touches internal libmariadb.so structures which for obvious reasons do not have stable nor documented API. In DBD::MariaDB I replaced this code by usage of public Connector/C API. But for buggy Perl application this may cause incompatibility. Changes are in this pull request: https://github.com/gooddata/DBD-MariaDB/pull/63 To prevent breakage of other Perl modules which uses DBD::mysql I strongly suggest to stick with MySQL Connector/C or use MariaDB 10.0 or 10.1 which is known to work. One of the reason why I forked and created DBD::MariaDB instead of touching DBD::mysql is support for MariaDB 10.2+, 10.3+. Basically touching these parts of DBD::mysql code may cause problems for applications which misuse bugs in DBD::mysql. There was long discussion about it 2 years ago and people decided that it rather should not be changed. (Reason for fork and move to DBD::MariaDB). If you want to prevent any possible breakage, then you have no other option and should stick with either MySQL 5.5-5.7 or with MariaDB 10.0/10.1. And if you really want to update MariaDB to 10.3, I strongly suggest to also update packages from DBD::mysql to DBD::MariaDB. For DBD::MariaDB we have large test coverage with different MySQL and MariaDB versions, including MariaDB 10.3 and 10.4 series, see: https://travis-ci.org/gooddata/DBD-MariaDB Seems that in DBD::mysql upstream rather decided to drop MariaDB 10.3 support as trying to fix it, see: https://github.com/perl5-dbi/DBD-mysql/commit/0c4fee5d928efdf937fdf5fdba5f4873b01848ef And rather started fixing support for MySQL 8.0 series: https://github.com/perl5-dbi/DBD-mysql/commit/08df02eabf08de62a5e363fbf852ca51f685a8ce Maybe another option can be inclusion of MySQL 8.0 for DBD::mysql?
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Thu, 03 Jan 2019 22:04:48 +0200, Otto Kekäläinen wrote: > Just checking: are you Georg or Gregor currently working on this > issue, and do you have any estimate when we could expect either a > patch to MariaDB Connector C or a new upload of DBD-mysql so this > issue would be resolved? I had a look at DBD::mysql and DBD::MariaDB but without any success. I hope that someone with a better understanding than me from the Debian perl Group can try and find a solution. I've now pinged the upstream issue at: https://github.com/perl5-dbi/DBD-mysql/issues/275 Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Little Walter: You're So Fine signature.asc Description: Digital Signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Just checking: are you Georg or Gregor currently working on this issue, and do you have any estimate when we could expect either a patch to MariaDB Connector C or a new upload of DBD-mysql so this issue would be resolved? It is currently the only thing left that stops the migration of mariadb-10.3 from Debian unstable to Debian testing. The page https://tracker.debian.org/pkg/mariadb-10.3 also lists two other issues but they have already been solved an practically only pend for a new upload. pe 28. jouluk. 2018 klo 18.54 Georg Richter (ge...@mariadb.com) kirjoitti: > > About the reconnect bug: > > Latest code is setting the reconnect flag correctly via mysql_options > (instead of accessing internal member), so I need to debug why it's failing. > > /Georg > > On Fri, Dec 28, 2018 at 1:31 PM gregor herrmann wrote: >> >> On Fri, 28 Dec 2018 11:27:04 +0200, Otto Kekäläinen wrote: >> >> > pe 28. jouluk. 2018 klo 11.09 Georg Richter (ge...@mariadb.com) kirjoitti: >> > > no clue about dbd-mysql - we reported several bugs (and sent >> > > fixes), but didn't get feedback since more than a year. Why don't >> > > you ship DBD-mariadb instead? >> > Gregor Hermann, do you want to switch to DBD-mariadb instead? >> >> DBD-mariadb is in the archive since a couple of months: >> https://tracker.debian.org/libdbd-mariadb-perl >> >> Unfortunately, it's not a 1:1 replacement for DBD-mysql and many user >> will want to continue using the latter in their existing codebase. >> >> Georg, maybe you can give us pointers to the bugs and fixes you >> mentioned above?
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
About the reconnect bug: Latest code is setting the reconnect flag correctly via mysql_options (instead of accessing internal member), so I need to debug why it's failing. /Georg On Fri, Dec 28, 2018 at 1:31 PM gregor herrmann wrote: > On Fri, 28 Dec 2018 11:27:04 +0200, Otto Kekäläinen wrote: > > > pe 28. jouluk. 2018 klo 11.09 Georg Richter (ge...@mariadb.com) > kirjoitti: > > > no clue about dbd-mysql - we reported several bugs (and sent > > > fixes), but didn't get feedback since more than a year. Why don't > > > you ship DBD-mariadb instead? > > Gregor Hermann, do you want to switch to DBD-mariadb instead? > > DBD-mariadb is in the archive since a couple of months: > https://tracker.debian.org/libdbd-mariadb-perl > > Unfortunately, it's not a 1:1 replacement for DBD-mysql and many user > will want to continue using the latter in their existing codebase. > > Georg, maybe you can give us pointers to the bugs and fixes you > mentioned above? > > > Cheers, > gregor > > -- > .''`. https://info.comodo.priv.at -- Debian Developer > https://www.debian.org > : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 > AA06 > `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation > Europe >`- NP: Penelope Swales: Turning Point > -- Georg Richter, Senior Software Engineer MariaDB Corporation Ab
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Hi, the zerofill test fails, since dbd-mysql binds a buffer with buffer_length=1, so MariaDB Connector/C can't add leading zeros and just returns 1. Perl seems to retrieve the information from metadata after mysql_stmt_store_result() call. According to the documentation ( https://dev.mysql.com/doc/refman/8.0/en/mysql-stmt-attr-set.html) you have to call mysql_stmt_attr_set(stmt, STMT_ATTR_UPDATE_MAX_LENGTH, ) to force mysql_stmt_store_result to update the max_length value in metadata - however its not set and therefore Connector/C doesn't return expected value. The correct behavior would be to check the metadata after mysql_stmt_prepare() and calculate the buffer_size or to force Connector/C to calculate the size via STMT_ATTR_UPDATE_MAX_LENGTH. I would prefer the latter one, since in some cases metadata after prepare can't be calculated correctly, e.g. for a "SELECT ? FROM DUAL" /Georg On Fri, Dec 28, 2018 at 1:31 PM gregor herrmann wrote: > On Fri, 28 Dec 2018 11:27:04 +0200, Otto Kekäläinen wrote: > > > pe 28. jouluk. 2018 klo 11.09 Georg Richter (ge...@mariadb.com) > kirjoitti: > > > no clue about dbd-mysql - we reported several bugs (and sent > > > fixes), but didn't get feedback since more than a year. Why don't > > > you ship DBD-mariadb instead? > > Gregor Hermann, do you want to switch to DBD-mariadb instead? > > DBD-mariadb is in the archive since a couple of months: > https://tracker.debian.org/libdbd-mariadb-perl > > Unfortunately, it's not a 1:1 replacement for DBD-mysql and many user > will want to continue using the latter in their existing codebase. > > Georg, maybe you can give us pointers to the bugs and fixes you > mentioned above? > > > Cheers, > gregor > > -- > .''`. https://info.comodo.priv.at -- Debian Developer > https://www.debian.org > : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 > AA06 > `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation > Europe >`- NP: Penelope Swales: Turning Point > -- Georg Richter, Senior Software Engineer MariaDB Corporation Ab
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Fri, 28 Dec 2018 11:27:04 +0200, Otto Kekäläinen wrote: > pe 28. jouluk. 2018 klo 11.09 Georg Richter (ge...@mariadb.com) kirjoitti: > > no clue about dbd-mysql - we reported several bugs (and sent > > fixes), but didn't get feedback since more than a year. Why don't > > you ship DBD-mariadb instead? > Gregor Hermann, do you want to switch to DBD-mariadb instead? DBD-mariadb is in the archive since a couple of months: https://tracker.debian.org/libdbd-mariadb-perl Unfortunately, it's not a 1:1 replacement for DBD-mysql and many user will want to continue using the latter in their existing codebase. Georg, maybe you can give us pointers to the bugs and fixes you mentioned above? Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Penelope Swales: Turning Point signature.asc Description: Digital Signature
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
Hello! pe 28. jouluk. 2018 klo 11.09 Georg Richter (ge...@mariadb.com) kirjoitti: > > Hi Otto, > > no clue about dbd-mysql - we reported several bugs (and sent fixes), but > didn't get feedback since more than a year. Why don't you ship DBD-mariadb > instead? Gregor Hermann, do you want to switch to DBD-mariadb instead? For the record, I don't have any plans to package DBD-mariadb as I have no Perl expertise.
Bug#917303: Request for help with MariaDB 10.3 / libdbd-mysql-perl packaging
On Thu, 27 Dec 2018 19:52:02 +0200, Otto Kekäläinen wrote: > The recent upload of MariadB 10.3 to Debian unstable and also the new > mysql-defaults break the Debian CI tests of your package > libdbd-mysql-perl. True. And not only the CI tests. There's already a bug for it: https://bugs.debian.org/917303 and an upstream issue: https://github.com/perl5-dbi/DBD-mysql/issues/275 (CC'ing the bug report to get the discussion into the right place.) > I would appreciate very much if you can debug what exactly goes wrong > in the libdbd-mysql-perl tests and perhaps even file a merge request > on Salsa against mariadb-10.3 to get it fixed. Looks like this is an issue in DBD-mysql; maybe other distributions have found something already (I haven't looked yet)? It might help to know what has changed in MariaDB between 10.1 and 10.3 … Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Rolling Stones: Tumbling signature.asc Description: Digital Signature
