Bug#922557: lintian: Make orig-tarball-missing-upstream-signature a "dsc" check (was: "Re: Bug#922557: lintian: Please check whether there's an expected orig tarball signature")

2019-02-19 Thread Chris Lamb
Hi Guillem,

> > Assuming that is why Guillem did not see it I am renaming this bug
> > to match. There is no reason why it cannot be a .changes check;
[…]
> As Mattia mentions, that's the other way around.

(I don't have that message, and nor does the BTS...?)

> The .dsc always get all files listed, but the .changes only list what
> they will end up uploading

Indeed, I got them muddled in my previous mail; I changed it correctly
in the code itself (I hope!):

  
https://salsa.debian.org/lintian/lintian/commit/e05ddc3dab4105af905baee3366aa7711ce0fbb4


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-



Bug#922557: lintian: Make orig-tarball-missing-upstream-signature a "dsc" check (was: "Re: Bug#922557: lintian: Please check whether there's an expected orig tarball signature")

2019-02-19 Thread Guillem Jover
Hi!

On Mon, 2019-02-18 at 14:51:42 +0100, Chris Lamb wrote:
> > There is already such a tag, orig-tarball-missing-upstream-signature.
> > That's a .changes checks, not a .dsc one, so it would be emitted only
> > for -1.

Right, had seen it but from a very quick skim got the impression it
was for missing .asc when multiple tarballs were involved! :) But it
does really look like that was the tag indeed.

> Assuming that is why Guillem did not see it I am renaming this bug
> to match. There is no reason why it cannot be a .changes check;
> perhaps I originally thought that .dsc files did not mention such
> files in their manifests?

As Mattia mentiones, that's the other way around. The .dsc always get
all files listed, but the .changes only list what they will end up
uploading which for non -1 releases it means only the .dsc itself
and the diff.gz/debian.tar. files, even if the .dsc contained
orig.tar..asc (and orig.tar.) references.

> Anyway, fix incoming...

Thanks!
Guillem



Bug#922557: lintian: Make orig-tarball-missing-upstream-signature a "dsc" check (was: "Re: Bug#922557: lintian: Please check whether there's an expected orig tarball signature")

2019-02-18 Thread Chris Lamb
retitle 922557 lintian: Make orig-tarball-missing-upstream-signature a "dsc" 
check
thanks

Hi Mattia,

> There is already such a tag, orig-tarball-missing-upstream-signature.
> That's a .changes checks, not a .dsc one, so it would be emitted only
> for -1.

Assuming that is why Guillem did not see it I am renaming this bug
to match. There is no reason why it cannot be a .changes check;
perhaps I originally thought that .dsc files did not mention such
files in their manifests?

Anyway, fix incoming...


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org 🍥 chris-lamb.co.uk
   `-