Bug#923740: unblock: pacemaker/2.0.1-1

2019-03-09 Thread wferi
Control: tags -1 - moreinfo

Jonathan Wiltshire  writes:

> On Tue, Mar 05, 2019 at 09:45:26AM +0100, Paul Gevers wrote:
>
>> I propose you let 2.0.1~rc5-1 migrate to testing, upload 2.0.1-1 to
>> unstable after that, provide us with a debdiff between 2.0.1~rc5-1 and
>> 2.0.1-1 in this bug report and we'll look at that diff. That way, the
>> review is much more trivial for us. Please remove the moreinfo tag once
>> we are there.
>
> ~rc5-1 just migrated.

Indeed, thanks for the note!  Accordingly, 2.0.1-1 is uploaded, and the
debdiff has already been posted earlier.  So, dear Release Team, please
unblock pacemaker 2.0.1-1.
-- 
Thanks,
Feri



Bug#923740: unblock: pacemaker/2.0.1-1

2019-03-09 Thread Jonathan Wiltshire
On Tue, Mar 05, 2019 at 09:45:26AM +0100, Paul Gevers wrote:
> I propose you let 2.0.1~rc5-1 migrate to testing, upload 2.0.1-1 to
> unstable after that, provide us with a debdiff between 2.0.1~rc5-1 and
> 2.0.1-1 in this bug report and we'll look at that diff. That way, the
> review is much more trivial for us. Please remove the moreinfo tag once
> we are there.

~rc5-1 just migrated.

HTH,



-- 
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51



Bug#923740: unblock: pacemaker/2.0.1-1

2019-03-05 Thread Paul Gevers
Hi Feri

On 05-03-2019 10:39, wf...@niif.hu wrote:
>> upload 2.0.1-1 to unstable after that
> 
> Without a definite ACK from you?

If that changes meet the requirements, yes:
https://release.debian.org/buster/freeze_policy.html

>> provide us with a debdiff between 2.0.1~rc5-1 and 2.0.1-1 in this bug
>> report
> 
> That's what I submitted in the first place, so already done.

A, missed that then.

> I'm tragic at simulating archive maintenance in my head. :)  Upload time
> of day certainly is a factor in such computations, and I don't know the
> timing of the cron jobs.  If you happen to know offhand: which was the
> last second for uploads targeting buster to not need a manual unblock?

No, I don't, as it also depends on the moment we actually make the
change. But as far as I counted, the package had to be installed on 2
March 19:00 UTC (that is when a new day starts for britney), assuming we
will deploy the full freeze before the final full britney run on 12
March of 22:00 UTC.

Paul



signature.asc
Description: OpenPGP digital signature


Bug#923740: unblock: pacemaker/2.0.1-1

2019-03-05 Thread wferi
Paul Gevers  writes:

> I propose you let 2.0.1~rc5-1 migrate to testing

Hi Paul,

OK, this is what Niels suggested as well (I think).

> upload 2.0.1-1 to unstable after that

Without a definite ACK from you?

> provide us with a debdiff between 2.0.1~rc5-1 and 2.0.1-1 in this bug
> report

That's what I submitted in the first place, so already done.

> Please remove the moreinfo tag once we are there.

I'll do so once 2.0.1~rc5-1 migrated to testing.

> By the way, you would have probably missed it by more than one day.

I'm tragic at simulating archive maintenance in my head. :)  Upload time
of day certainly is a factor in such computations, and I don't know the
timing of the cron jobs.  If you happen to know offhand: which was the
last second for uploads targeting buster to not need a manual unblock?
-- 
Thanks,
Feri



Bug#923740: unblock: pacemaker/2.0.1-1

2019-03-05 Thread Paul Gevers
Control: tags -1 moreinfo

Hi Ferenc,

On 04-03-2019 22:41, Ferenc Wágner wrote:
> Even if I uploaded 2.0.1-1 now, it would miss the freeze date by a day,
> kicking out 2.0.1~rc5-1 as well, which would be quite a shame,
> considering that it's almost as good as the final, and definitely better
> than 2.0.1~rc4-1 currently in testing.  Could you please provide a way
> for 2.0.1-1 final (not uploaded yet) to reach buster?

I propose you let 2.0.1~rc5-1 migrate to testing, upload 2.0.1-1 to
unstable after that, provide us with a debdiff between 2.0.1~rc5-1 and
2.0.1-1 in this bug report and we'll look at that diff. That way, the
review is much more trivial for us. Please remove the moreinfo tag once
we are there.

Paul
By the way, you would have probably missed it by more than one day.



signature.asc
Description: OpenPGP digital signature


Bug#923740: unblock: pacemaker/2.0.1-1

2019-03-04 Thread Niels Thykier
Ferenc Wágner:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> 
> Dear Release Team,
> 
> Please advise about the situation with Pacemaker.
> 
> At the moment pacemaker_2.0.1~rc5-1 is 6 days old in unstable (it was
> uploaded on the day following its release) and now that it finally built
> on all architectures (it triggered a linker bug on amd64) I expect it to
> migrate to testing this week, well before the full freeze.
> 
> However, Pacemaker 2.0.1 final was released today and includes a single
> code change only, with the following commit message (the change itself
> is the deletion of lines at the end of the debdiff below):
> 
> High: libcrmcommon: complete interrupted live migrations correctly
> 
> 8435966 (2.0.0) got the sense of compare_version() wrong when
> attempting to remove the old behavior for recording partial live
> migrations, instead re-introducing it.
> 
> This causes a regression in behavior when a transition containing a
> live migration is aborted after the migrate_to has been initiated
> but before the migrate_from has been initiated. In that case, it
> would schedule a full start on the destination node rather than a
> migrate_from.
> 
> I think we should release buster with Pacemaker 2.0.1, thus with this
> fix and the small documentation fixes also bundled with it.  The added
> include directives just make previously indirect includes explicit, and
> our build doesn't use the abi-check script, so that change is a no-op.
> Full debdiff from 2.0.1~rc5-1 (which is on its way to testing):
> 
> [...]
> 
> Even if I uploaded 2.0.1-1 now, it would miss the freeze date by a day,
> kicking out 2.0.1~rc5-1 as well, which would be quite a shame,
> considering that it's almost as good as the final, and definitely better
> than 2.0.1~rc4-1 currently in testing.  Could you please provide a way
> for 2.0.1-1 final (not uploaded yet) to reach buster?
> 
> Thanks,
> Feri.
> 
> unblock pacemaker/2.0.1-1
> 

Hi Feri,

Thanks for filing the report.

Please let the current version of pacemaker as it is and then ping us on
this bug once it have.

Thanks,
~Niels



Bug#923740: unblock: pacemaker/2.0.1-1

2019-03-04 Thread Ferenc Wágner
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Dear Release Team,

Please advise about the situation with Pacemaker.

At the moment pacemaker_2.0.1~rc5-1 is 6 days old in unstable (it was
uploaded on the day following its release) and now that it finally built
on all architectures (it triggered a linker bug on amd64) I expect it to
migrate to testing this week, well before the full freeze.

However, Pacemaker 2.0.1 final was released today and includes a single
code change only, with the following commit message (the change itself
is the deletion of lines at the end of the debdiff below):

High: libcrmcommon: complete interrupted live migrations correctly

8435966 (2.0.0) got the sense of compare_version() wrong when
attempting to remove the old behavior for recording partial live
migrations, instead re-introducing it.

This causes a regression in behavior when a transition containing a
live migration is aborted after the migrate_to has been initiated
but before the migrate_from has been initiated. In that case, it
would schedule a full start on the destination node rather than a
migrate_from.

I think we should release buster with Pacemaker 2.0.1, thus with this
fix and the small documentation fixes also bundled with it.  The added
include directives just make previously indirect includes explicit, and
our build doesn't use the abi-check script, so that change is a no-op.
Full debdiff from 2.0.1~rc5-1 (which is on its way to testing):

diff -Nru pacemaker-2.0.1~rc5/abi-check pacemaker-2.0.1/abi-check
--- pacemaker-2.0.1~rc5/abi-check   2019-02-25 22:35:40.0 +0100
+++ pacemaker-2.0.1/abi-check   2019-03-04 20:55:07.0 +0100
@@ -76,7 +76,8 @@
 
 EOF
 
-abi-compliance-checker -l $PACKAGE -dump_abi $DESC
+abi-compliance-checker -l $PACKAGE -dump_abi $DESC \
+-dump-path abi_dumps/${PACKAGE}/${PACKAGE}_${VERSION}.abi.tar.gz
 rm -rf $BUILD_ROOT
 }
 
diff -Nru pacemaker-2.0.1~rc5/ChangeLog pacemaker-2.0.1/ChangeLog
--- pacemaker-2.0.1~rc5/ChangeLog   2019-02-25 22:35:40.0 +0100
+++ pacemaker-2.0.1/ChangeLog   2019-03-04 20:55:07.0 +0100
@@ -1,103 +1,75 @@
-* Mon Feb 25 2019 Ken Gaillot  Pacemaker-2.0.1-rc5
-- Changesets: 17
-- Diff:   15 files changed, 1037 insertions(+), 677 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc4
-  + scheduler: regression test compatibility with glib 2.59.0
-
-* Tue Jan 29 2019 Ken Gaillot  Pacemaker-2.0.1-rc4
-- Changesets: 42
- 15 files changed, 216 insertions(+), 137 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc3
-  + attrd: clear election dampening when the writer leaves
-  + controller: clear election dampening when DC is lost
-  + scheduler: don't order non-DC shutdowns before DC fencing
-  + libcrmservice: cancel DBus call when cancelling systemd/upstart actions
-  + tools: remove duplicate fence history state in crm_mon XML output
-  + build: offer configure option to disable tests broken with glib 2.59.0
-  + build: minor logging fixes to allow compatibility with GCC 9 -Werror
-
-* Thu Jan 10 2019 Ken Gaillot  Pacemaker-2.0.1-rc3
-- Changesets: 27
-- Diff:   20 files changed, 375 insertions(+), 195 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc2
-  + attrd: start new election immediately if writer is lost
-  + attrd: detect alert configuration changes when CIB is entirely replaced
-  + controller: avoid transition timeout if resource cleaned while operation
-is in-flight (regression in 2.0.1-rc1)
-  + libstonithd: restore C++ compatibility (regression in 2.0.1-rc1)
-  + tools: fix crm_resource --clear when lifetime was used with ban/move
-  + tools: fix crm_resource --move when lifetime was used with previous move
-
-* Wed Dec 19 2018 Ken Gaillot  Pacemaker-2.0.1-rc2
-- Changesets: 12
-- Diff:   2 files changed, 6 insertions(+), 2 deletions(-)
-
-- Changes since Pacemaker-2.0.1-rc1
-  + libpe_status: avoid double free of stop_needed list (regression in 
2.0.1-rc1)
-  + tools: stonith_admin -I doesn't require an agent (regression in 2.0.1-rc1)
-
-* Wed Dec 12 2018 Ken Gaillot  Pacemaker-2.0.1-rc1
-- Changesets: 481
- 164 files changed, 7717 insertions(+), 4398 deletions(-)
+* Mon Mar 4 2019 Ken Gaillot  Pacemaker-2.0.1-1
+- Changesets: 592
+ 173 files changed, 9268 insertions(+), 5344 deletions(-)
 
 - Features added since Pacemaker-2.0.0
-  + Pacemaker bundles now support podman container management
-  + fencing: SBD may now be used in a cluster that has guest nodes or bundles
-  + fencing: synchronize fencing history among all nodes
-  + fencing: stonith_admin now has option to clear fence history
-  + tools: crm_mon now supports showing fencing action failures and history
+  + Pacemaker bundles support podman for container management
+  + fencing: SBD may be used in a cluster that has guest nodes or bundles
+  + fencing: fencing history is synchronized among all nodes
+  + fencing: