Bug#925455: alsa volume never saved/restored

2019-04-09 Thread Elimar Riesebieter
* gregor herrmann  [2019-04-09 18:09 +0200]:

> On Sun, 07 Apr 2019 19:39:34 +0200, Elimar Riesebieter wrote:
> 
> > > > Jordi is MIA at the moment. Tried to reach him since a few days. I
> > > > can't upload the fix myself, though...
> > > I pinged him on a different channel, but if he doesn't have time I'm
> > > happy to offer a sponsored upload to fix this bug.
> > Would be nice. Yes, please :-)
> 
> It looks like Jordi is still busy, so I decided to help out and
> uploaded 1.1.8-2 from the git repo. 

Many thanks :-)

Elimar
-- 
.~.
/V\   L   I   N   U   X
   /( )\ >Phear the Penguin<
   ^^-^^


signature.asc
Description: PGP signature


Bug#925455: alsa volume never saved/restored

2019-04-09 Thread gregor herrmann
On Sun, 07 Apr 2019 19:39:34 +0200, Elimar Riesebieter wrote:

> > > Jordi is MIA at the moment. Tried to reach him since a few days. I
> > > can't upload the fix myself, though...
> > I pinged him on a different channel, but if he doesn't have time I'm
> > happy to offer a sponsored upload to fix this bug.
> Would be nice. Yes, please :-)

It looks like Jordi is still busy, so I decided to help out and
uploaded 1.1.8-2 from the git repo. 


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Kurt Ostbahn & Die Kombo: Wenn der Herbst langsam näherrückt


signature.asc
Description: Digital Signature


Bug#925455: alsa volume never saved/restored

2019-04-08 Thread Hartmut Buhrmester

Looking a bit further it seems that /var/lib/alsa/asound.state doesn't
exist.

That means that we are facing a chicken-egg problem here, the file will
never be created as the service is never started (and then never
stopped).


I don't know, if it helps, but I could manually create a working 
settings file with:


alsactl -f /var/lib/alsa/asound.state init
alsactl -f /var/lib/alsa/asound.state store


In the shell:


root@debian:/var/lib/alsa# alsactl -f /var/lib/alsa/asound.state init
Found hardware: "ICH" "Analog Devices AD1881A" "AC97a:41445348" "0x1043" 
"0x11d4"
Hardware is initialized using a generic method
root@debian:/var/lib/alsa# ls -l
insgesamt 0
root@debian:/var/lib/alsa# alsactl -f /var/lib/alsa/asound.state store
root@debian:/var/lib/alsa# ls -l
insgesamt 8
-rw-r--r-- 1 root root 5680 Apr  7 18:55 asound.state
root@debian:/var/lib/alsa# 



Since then, the sound level was properly saved and restored on restart.

/var/log/syslog on start:


Apr  7 19:41:46 debian systemd[1]: Starting Save/Restore Sound Card State...
Apr  7 19:41:46 debian systemd[1]: Started Save/Restore Sound Card State.
Apr  7 19:41:46 debian systemd[1]: Reached target Sound Card.


/var/log/syslog on shutdown:


Apr  7 19:45:17 debian systemd[1]: Stopped target Sound Card.
Apr  7 19:45:17 debian systemd[1]: Stopping Save/Restore Sound Card State...


I doesn't say "Stopped Save/Restore Sound Card State.", though. So the 
last confirmation seems to be missing. But it still works, as far as I 
can tell...



I think, I always needed to run "alsactl init" at least once since 
Debian 8 Jessie, and this is still mentioned in the Debian Wiki:



Configure alsa by running the command 'alsactl init' as root. Then
reboot and try to test your sound.


-- https://wiki.debian.org/ALSA


Regards,

Hartmut Buhrmester



Bug#925455: alsa volume never saved/restored

2019-04-07 Thread Elimar Riesebieter
* gregor herrmann  [2019-04-07 18:16 +0200]:

> On Sun, 07 Apr 2019 18:05:06 +0200, Elimar Riesebieter wrote:
> 
> > > There is a commit in the packaging repo which claims to fix this bug:
> > > https://salsa.debian.org/alsa-team/alsa-utils/commit/af161676131e94bbaed72f37d0c5d4c6685a119e
> > Jordi is MIA at the moment. Tried to reach him since a few days. I
> > can't upload the fix myself, though...
> 
> I pinged him on a different channel, but if he doesn't have time I'm
> happy to offer a sponsored upload to fix this bug.

Would be nice. Yes, please :-)

-- 
  "Talking much about oneself can also
   be a means to conceal oneself."
 -Friedrich Nietzsche


signature.asc
Description: PGP signature


Bug#925455: alsa volume never saved/restored

2019-04-07 Thread gregor herrmann
On Sun, 07 Apr 2019 18:05:06 +0200, Elimar Riesebieter wrote:

> > There is a commit in the packaging repo which claims to fix this bug:
> > https://salsa.debian.org/alsa-team/alsa-utils/commit/af161676131e94bbaed72f37d0c5d4c6685a119e
> Jordi is MIA at the moment. Tried to reach him since a few days. I
> can't upload the fix myself, though...

I pinged him on a different channel, but if he doesn't have time I'm
happy to offer a sponsored upload to fix this bug.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Furry Lewis: Billy lyons & stack o' lee


signature.asc
Description: Digital Signature


Bug#925455: alsa volume never saved/restored

2019-04-07 Thread Elimar Riesebieter
* gregor herrmann  [2019-04-07 17:46 +0200]:

> Control: tag -1 + patch pending
> 
> On Mon, 25 Mar 2019 12:05:36 +0100, Laurent Bigonville wrote:
> 
> > The more obvious solution would of course be to remove the condition in the
> > .service file
> 
> There is a commit in the packaging repo which claims to fix this bug:
> https://salsa.debian.org/alsa-team/alsa-utils/commit/af161676131e94bbaed72f37d0c5d4c6685a119e

Jordi is MIA at the moment. Tried to reach him since a few days. I
can't upload the fix myself, though...

Elimar
-- 
  We all know Linux is great... it does infinite loops in 5 seconds.
-Linus Torvalds


signature.asc
Description: PGP signature


Bug#925455: alsa volume never saved/restored

2019-04-07 Thread gregor herrmann
Control: tag -1 + patch pending

On Mon, 25 Mar 2019 12:05:36 +0100, Laurent Bigonville wrote:

> The more obvious solution would of course be to remove the condition in the
> .service file

There is a commit in the packaging repo which claims to fix this bug:
https://salsa.debian.org/alsa-team/alsa-utils/commit/af161676131e94bbaed72f37d0c5d4c6685a119e


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Furry Lewis: Billy lyons & stack o' lee


signature.asc
Description: Digital Signature


Bug#925455: alsa volume never saved/restored

2019-03-25 Thread Laurent Bigonville
On Mon, 25 Mar 2019 12:01:02 +0100 Laurent Bigonville  
wrote:


>
> An option might be to create an empty file in the postinst script on the
> first installation. An empty file will cause the "alsa restore" command
> to fail with return code 99 but the systemd service will still be marked
> as "active (exited)" and the ExecStop will be executed on shutdown
> meaning that the volume will be saved. (Wouldn't that cause issue with
> some setup?)

The more obvious solution would of course be to remove the condition in 
the .service file




Bug#925455: alsa volume never saved/restored

2019-03-25 Thread Laurent Bigonville
Package: alsa-utils
Version: 1.1.8-1
Severity: important
File: /lib/systemd/system/alsa-restore.service

Hi,

On my newly installed laptop, the volume is never saved and restored

It seems that the "alsa-restore.service" is never "started/stopped"
because there is a condition not met:

$ systemctl status alsa-restore.service 
● alsa-restore.service - Save/Restore Sound Card State
   Loaded: loaded (/lib/systemd/system/alsa-restore.service; static; vendor 
preset: enabled)
   Active: inactive (dead)
Condition: start condition failed at Mon 2019-03-25 10:25:34 CET; 1h 15min ago
 Docs: man:alsactl(1)

mar 25 10:25:34 edoras systemd[1]: Condition check resulted in Save/Restore 
Sound Card State being skipped.

Looking a bit further it seems that /var/lib/alsa/asound.state doesn't
exist.

That means that we are facing a chicken-egg problem here, the file will
never be created as the service is never started (and then never
stopped).

An option might be to create an empty file in the postinst script on the
first installation. An empty file will cause the "alsa restore" command
to fail with return code 99 but the systemd service will still be marked
as "active (exited)" and the ExecStop will be executed on shutdown
meaning that the volume will be saved. (Wouldn't that cause issue with
some setup?)

AFAICS, it's a regression and we might want to get this fixed in buster,
if you think it should be the case, please make this bug RC.

Kind regards,
Laurent Bigonville

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_BE:fr (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages alsa-utils depends on:
ii  kmod  26-1
ii  libasound21.1.8-1
ii  libc6 2.28-8
ii  libfftw3-single3  3.3.8-2
ii  libncursesw6  6.1+20181013-2
ii  libsamplerate00.1.9-2
ii  libtinfo6 6.1+20181013-2
ii  lsb-base  10.2019031300
ii  whiptail  0.52.20-8

alsa-utils recommends no packages.

alsa-utils suggests no packages.

-- no debconf information