Bug#926554: xbindkeys-config: segfault upon "Get key"

[Adam Borowski]

On Sat, Apr 20, 2019 at 01:48:08AM +0200, Bernhard Übelacker wrote:
> The line information from your backtrace and that in 268630
> looks quite equal, so it might still be the same cause.
> In this bug and in 268630 xbindkeys-config might crash
> because xbindkeys gives no or unexpected output to stdout.
> And probably just an error message to stderr.

Possibly -- I still did not manage to get xbindkeys-config to produce
an usable result, but I did not try very hard.

> So might your manually created .xbindkeysrc contain an
> error that makes "xbindkeys -k" to fail?

Alas, I don't know what is valid and what is not -- I tried the GUI
specifically to avoid having to research that.

> In 268630 I have attached a patch that tries to avoid
> the crash at least.

Indeed, it fixes my crash as well.

On the other hand, I wonder how much effort would be appropriate to put
into the package -- it has a pretty dead smell.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8"
⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs?
⠈⠳⣄

Bug#926554: xbindkeys-config: segfault upon "Get key"

[Bernhard Übelacker]

Hello Adam Borowski,
I am just looking through crashes of random packages and tried to
get some more information from that.

The line information from your backtrace and that in 268630
looks quite equal, so it might still be the same cause.
In this bug and in 268630 xbindkeys-config might crash
because xbindkeys gives no or unexpected output to stdout.
And probably just an error message to stderr.

So might your manually created .xbindkeysrc contain an
error that makes "xbindkeys -k" to fail?

In 268630 I have attached a patch that tries to avoid
the crash at least.

And it seems not limited to just arm64.

Kind regards,
Bernhard

Bug#926554: xbindkeys-config: segfault upon "Get key"

[Adam Borowski]

Package: xbindkeys-config
Version: 0.1.3-2+b2
Severity: important

Hi!
There's already a separate bug about "Get key" segfaulting when there's no
default config (#268630) -- but for me, it segfaults a bit later when the
config is there.

Without the config, "Get key" segfaults immediately.
After generating it manually, a window appears, but trying to interact with
it results in:


Program received signal SIGSEGV, Segmentation fault.
middle_get_key (data=, parent=) at middle.c:364

(gdb) bt full
#0  middle_get_key (data=, parent=) at 
middle.c:364
f = 0x6f5c80
buf = "Press combination of keys or/and click under the window.\nYou 
can use one of the two lines after \"NoCommand\"\nin $HOME/.xbindkeysrc to bind 
a key.\n\344\347\255=\246\245\264\300\335\377\377\177\000\000\000|#۷\177", 
'\000' , 
"\344\347\255=\246\245\264@\336\377\377\177\000\000\000\274\251۷\177\000\000\000\060\211"...
buf2 = 
"0\000\000\000\000\000\000\000p\334\377\377\177\000\000\000\060\000\000\000\000\000\000\000P\000\000\000\000\000\000\000\200\333\377\377\177\000\000\000\214\241S\267\177\000\000\000@\000\000\000\000\000\000\000\360\324oUU\000\000\000\000\271qUU\000\000\000\320;pUU\000\000\000Z\000\000\000\000\000\000\000u\000\000\000\000\000\000\000\020\271qU"
pl1 = 0x1 
pl2 = 
buf3 = {0xb4a5a63dade7e400 , 0x7fdba0 "", 0x7fb7abba20 "\307\002@\271\363\003", 
0x6fd508 "c\002", 
  0x7fb7abc6a4 "\352w@\271!\a@\371?\300", , 
0x7fdc00 "\220\334\377\377\177", 
  0x7fb7abc6a4 "\352w@\271!\a@\371?\300", , 
0x71b910 "0", 0x703be0 " 1rUU", 0x71b910 "0", 0x7fb7abb5a8 
"\375{\273\251\177", 
  0x6fd4f8 "\002", 0x75 , 0x6fd4f0 "\004", 0x703bd0 "\340\265qUU", 0x71b900 "c\002", 
  0x7fdda0 "\300\335\377\377\177", 0x7fdc90 "", 0x7fb7abccd8 
 "\341\003\023\252", 0x6fd240 "\300\324oUU", 
0x5c6360 "\020@\\UU", 
  0x6fd6d0 "@\322oUU", 0x5c6360 "\020@\\UU", 0x0, 0x0, 0x0, 
0x5c6480 "\020@\\UU", 0x20 , 
0x7fb763b490 "\002", 
  0x7fdcb0 "`\335\377\377\177", 
  0x7fb7ac7a84 "\367cC\251\371kD\251\350'Fm\275\377\377\027\300v@\371 
\377\377\264\300:@\371\340\376\377\265\351\377\377\027@\033@\371\340O", 
0x7fb7b4c000 "", 
  0x5c6360 "\020@\\UU", 0x6fd6d0 "@\322oUU", 0x5c6360 
"\020@\\UU", 0x0, 0x0, 0x7fb7b4c000 "", 0x5c6360 "\020@\\UU", 
  0x7fdd60 "s after \"NoCommand\"\nin $HOME/.xbindkeysrc to bind a 
key.\n\344\347\255=\246\245\264\300\335\377\377\177", 
  0x7fb7ac7d50 
"\340\003\025\252\327\323\377\227\367\033@\371\333\377\377\027\341#\001\221\340\003\024\252\365\003\001\252\342S\001\221\341C\001\221\377'",
 
  0x7fb7b4c000 "", 0x5c6360 "\020@\\UU", 0x6fd6d0 "@\322oUU", 
0x0, 0x1 , 
  0xa2 , 0x1b , 0x338 , 
  0x20 }
len = 145
i = 
__s1_len = 
__s2_len = 
#1  0x007fb76299f0 in g_closure_invoke () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#2  0x007fb763e2c4 in ?? () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#3  0x007fb764660c in g_signal_emit_valist () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#4  0x007fb7646b78 in g_signal_emit () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#5  0x007fb7bde9e0 in ?? () from 
/usr/lib/aarch64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#6  0x007fb7c8e63c in ?? () from 
/usr/lib/aarch64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#7  0x007fb76299f0 in g_closure_invoke () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#8  0x007fb763db38 in ?? () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#9  0x007fb7646030 in g_signal_emit_valist () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#10 0x007fb7646b78 in g_signal_emit () from 
/usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#11 0x007fb7db1ca0 in ?? () from 
/usr/lib/aarch64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
--Type  for more, q to quit, c to continue without paging--
#12 0x007fb7c8c53c in gtk_propagate_event () from 
/usr/lib/aarch64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#13 0x007fb7c8c9a4 in gtk_main_do_event () from 
/usr/lib/aarch64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#14 0x007fb7ae559c in ?? () from 
/usr/lib/aarch64-linux-gnu/libgdk-x11-2.0.so.0
No symbol table info available.
#15 0x007fb7534634 in g_main_context_dispatch () from 
/usr/lib/aarch64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#16 0x007fb75348a8 in ?? () from /usr/lib/aarch64-linux-gnu/libglib-2.0.so.0
No symbol table info available.