Bug#926802: ipywidgets: FTBFS (TypeError: path.scope.getBindings(...).hasOwnProperty is not a function)
On Saturday, April 27 2019, Ximin Luo wrote: > Sergio Durigan Junior: >> Control: block -1 by 928090 >> On Saturday, April 27 2019, Ximin Luo wrote: >> >>> Awesome, thanks! I was just getting around to this today. Do you want to do >>> the NMU or shall I upload -4 as the "official maintainer"? >> >> Heya, thanks for the quick reply :-). >> >> I was actually going to write saying that I'm part of the Debian Python >> group, so I can just make a team upload. But I've created the unblock >> bug with release.debian.org (#928090), so let's just wait on their >> reply. Meanwhile, I'll push the changes to the git repo. >> > > We have to do an upload *as well as* unblock request, and we don't > need to wait for the release team to do that. So we should do it ASAP > when we're confident the bug is actually fixed, to avoid latency due > to the asynchronity between teams here. Ah, fair enough, thanks for clarifying. > (The point of the unblock is to unblock *the package already in unstable* to > be able to migrate to testing.) > > As a team member you are free to take the -4 version, just put "Team upload" > instead of "Non-maintainer upload" at the top line of your changelog, or use > "dch --team" instead of "dch --nmu". Yep, this is what I already did. > OK, I think I'll let you take care of the whole process :) Let me know if you > need anything else. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/ signature.asc Description: PGP signature
Bug#926802: ipywidgets: FTBFS (TypeError: path.scope.getBindings(...).hasOwnProperty is not a function)
Sergio Durigan Junior: > Control: block -1 by 928090 > On Saturday, April 27 2019, Ximin Luo wrote: > >> Awesome, thanks! I was just getting around to this today. Do you want to do >> the NMU or shall I upload -4 as the "official maintainer"? > > Heya, thanks for the quick reply :-). > > I was actually going to write saying that I'm part of the Debian Python > group, so I can just make a team upload. But I've created the unblock > bug with release.debian.org (#928090), so let's just wait on their > reply. Meanwhile, I'll push the changes to the git repo. > We have to do an upload *as well as* unblock request, and we don't need to wait for the release team to do that. So we should do it ASAP when we're confident the bug is actually fixed, to avoid latency due to the asynchronity between teams here. (The point of the unblock is to unblock *the package already in unstable* to be able to migrate to testing.) As a team member you are free to take the -4 version, just put "Team upload" instead of "Non-maintainer upload" at the top line of your changelog, or use "dch --team" instead of "dch --nmu". OK, I think I'll let you take care of the whole process :) Let me know if you need anything else. X -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git
Bug#926802: ipywidgets: FTBFS (TypeError: path.scope.getBindings(...).hasOwnProperty is not a function)
Control: block -1 by 928090 On Saturday, April 27 2019, Ximin Luo wrote: > Awesome, thanks! I was just getting around to this today. Do you want to do > the NMU or shall I upload -4 as the "official maintainer"? Heya, thanks for the quick reply :-). I was actually going to write saying that I'm part of the Debian Python group, so I can just make a team upload. But I've created the unblock bug with release.debian.org (#928090), so let's just wait on their reply. Meanwhile, I'll push the changes to the git repo. Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/ signature.asc Description: PGP signature
Bug#926802: ipywidgets: FTBFS (TypeError: path.scope.getBindings(...).hasOwnProperty is not a function)
Awesome, thanks! I was just getting around to this today. Do you want to do the NMU or shall I upload -4 as the "official maintainer"? X Sergio Durigan Junior: > tags 926802 + patch > usertags 926802 + bsp-2019-04-ca-toronto > thanks > > On Wednesday, April 10 2019, Santiago Vila wrote: > >> Dear maintainer: >> >> I tried to build this package in buster but it failed: > [...] > > Heya from the Toronto BSP! > > So, I've given it a try and managed to... hm... fix the issue. My > JavaScript knowledge is rudimentary at best, but with the diff below > makes the build complete without any apparent side effects (i.e., the > testsuite still pass). > > Kudos to Samuel Vale for helping verifying the code and making sure it > looks OK. > > I'll open an unblock request soon. > > Thanks, > -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git
Bug#926802: ipywidgets: FTBFS (TypeError: path.scope.getBindings(...).hasOwnProperty is not a function)
tags 926802 + patch
usertags 926802 + bsp-2019-04-ca-toronto
thanks
On Wednesday, April 10 2019, Santiago Vila wrote:
> Dear maintainer:
>
> I tried to build this package in buster but it failed:
[...]
Heya from the Toronto BSP!
So, I've given it a try and managed to... hm... fix the issue. My
JavaScript knowledge is rudimentary at best, but with the diff below
makes the build complete without any apparent side effects (i.e., the
testsuite still pass).
Kudos to Samuel Vale for helping verifying the code and making sure it
looks OK.
I'll open an unblock request soon.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
diff --git a/debian/changelog b/debian/changelog
index e19e631..166519b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+ipywidgets (6.0.0-3.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Use 'Object.prototype' instead of 'path.scope.getBindings' when
+calling 'hasOwnProperty'. (Closes: #926802)
+
+ -- Sergio Durigan Junior Sat, 27 Apr 2019 14:47:09
-0400
+
ipywidgets (6.0.0-3) unstable; urgency=medium
[ Ondřej Nový ]
diff --git a/debian/fakewebpack-postprocess.js
b/debian/fakewebpack-postprocess.js
index e7f7dbc..8126eef 100755
--- a/debian/fakewebpack-postprocess.js
+++ b/debian/fakewebpack-postprocess.js
@@ -127,7 +127,7 @@ var transform = function transform(ast, fn, moduleList) {
&& injectGlobalsReplace.hasOwnProperty(path.node.name)
&& (parent.type !== 'MemberExpression' || parent.object ===
path.node)
&& (parent.type !== 'Property' || parent.value === path.node)) {
-if (!path.scope.getBindings().hasOwnProperty(path.node.name)) {
+if
(!Object.prototype.hasOwnProperty.call(path.scope.getBindings(),
path.node.name)) {
injectGlobals.push(path.node.name);
}
}
signature.asc
Description: PGP signature
Bug#926802: ipywidgets: FTBFS (TypeError: path.scope.getBindings(...).hasOwnProperty is not a function)
Package: src:ipywidgets
Version: 6.0.0-3
Severity: serious
Tags: ftbfs
Dear maintainer:
I tried to build this package in buster but it failed:
[...]
debian/rules build-indep
dh build-indep --with python2,python3,sphinxdoc --buildsystem=pybuild
dh_update_autotools_config -i -O--buildsystem=pybuild
dh_autoreconf -i -O--buildsystem=pybuild
debian/rules override_dh_auto_configure
make[1]: Entering directory '/<>'
dh_auto_configure
I: pybuild base:217: python2.7 setup.py config
running config
I: pybuild base:217: python3.7 setup.py config
running config
dh_auto_configure -- -d ./widgetsnbextension
I: pybuild base:217: python2.7 setup.py config
INFO:root:setup.py entered
INFO:root:$PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
running config
I: pybuild base:217: python3.7 setup.py config
INFO:root:setup.py entered
INFO:root:$PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
running config
make[1]: Leaving directory '/<>'
debian/rules override_dh_auto_build
make[1]: Entering directory '/<>'
/usr/bin/make -C debian -f fakewebpack.mk all
make[2]: Entering directory '/<>/debian'
/usr/bin/make -f "fakewebpack-prep-unpacked.mk" all
make[3]: Entering directory '/<>/debian'
cd "fakewebpack-unpacked/phosphor/" && tsc --moduleResolution Classic --project
src
mkdir -p "fakewebpack-unpacked/phosphor/styles/" && NODE_PATH=../..
fakewebpack-helpers/css-loader-pack.py <
"fakewebpack-unpacked/phosphor/styles/base.css.real" >
"fakewebpack-unpacked/phosphor/styles/base.css"
mkdir -p "fakewebpack-unpacked/phosphor/styles/" && m4 -DNODE_PATH=../..
-DCSS_INPUT=./base.css "fakewebpack-helpers/style-loader.js.m4" >
"fakewebpack-unpacked/phosphor/styles/base.css?f74d"
printf "module.exports = $(cat
"fakewebpack-unpacked/jupyter-js-widgets/package.json.real");" >
"fakewebpack-unpacked/jupyter-js-widgets/package.json"
cd "fakewebpack-unpacked/jupyter-js-widgets/" && tsc --moduleResolution Classic
--project src
mkdir -p "fakewebpack-unpacked/jupyter-js-widgets/css/"
cd ../jupyter-js-widgets/css && cat widgets.css | \
sed -e '/@import ".\/labvariables.css"/{r ./labvariables.css'"${NLD}"'}' \
-e '/@import ".\/widgets-base.css"/{r ./widgets-base.css'"${NLD}"'}' | \
sed -e '/@import ".\/materialcolors.css"/{r ./materialcolors.css'"${NLD}"'}' >
/<>/debian/"fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css.real"
mkdir -p "fakewebpack-unpacked/jupyter-js-widgets/css/" && NODE_PATH=../..
fakewebpack-helpers/css-loader-pack.py <
"fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css.real" >
"fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css"
mkdir -p "fakewebpack-unpacked/jupyter-js-widgets/css/" && m4 -DNODE_PATH=../..
-DCSS_INPUT=./widgets.css "fakewebpack-helpers/style-loader.js.m4" >
"fakewebpack-unpacked/jupyter-js-widgets/css/widgets.css?7dc3"
mkdir -p "fakewebpack-unpacked/widgetsnbextension/webpack/ ./" && m4
-DWEBPACK_PUBLIC_PATH= "fakewebpack-helpers/webpack-bootstrap.js.m4" >
"fakewebpack-unpacked/widgetsnbextension/webpack/bootstrap e65abc6196a7e23c9fcf"
mkdir -p "fakewebpack-unpacked/widgetsnbextension/css/" &&
NODE_PATH=../node_modules fakewebpack-helpers/css-loader-pack.py <
"fakewebpack-unpacked/widgetsnbextension/css/outputarea.css.real" >
"fakewebpack-unpacked/widgetsnbextension/css/outputarea.css"
mkdir -p "fakewebpack-unpacked/widgetsnbextension/css/" && m4
-DNODE_PATH=../node_modules -DCSS_INPUT=./outputarea.css
"fakewebpack-helpers/style-loader.js.m4" >
"fakewebpack-unpacked/widgetsnbextension/css/outputarea.css?73c5"
printf "module.exports = $(cat
"fakewebpack-unpacked/widgetsnbextension/package.json.real");" >
"fakewebpack-unpacked/widgetsnbextension/package.json"
mkdir -p fakewebpack
touch "fakewebpack/prep.stamp"
make[3]: Leaving directory '/<>/debian'
touch fakewebpack/widgetsnbextension-unpacked.stamp
rm -rf "fakewebpack/widgetsnbextension" && mkdir -p
"fakewebpack/widgetsnbextension" && ./fakewebpack-generate.py
fakewebpack-meta/widgetsnbextension.files
fakewebpack-meta/widgetsnbextension.modules
fakewebpack-unpacked/widgetsnbextension/ True >
"fakewebpack/widgetsnbextension/extension.js" && touch
"fakewebpack/widgetsnbextension.stamp"
/<>/debian/fakewebpack-postprocess.js:130
if (!path.scope.getBindings().hasOwnProperty(path.node.name)) {
^
TypeError: path.scope.getBindings(...).hasOwnProperty is not a function
at Context.visitIdentifier
(/<>/debian/fakewebpack-postprocess.js:130:47)
at Context.invokeVisitorMethod
(/usr/lib/nodejs/ast-types/lib/path-visitor.js:344:49)
at Visitor.PVp.visitWithoutReset
(/usr/lib/nodejs/ast-types/lib/path-visitor.js:196:32)
at visitChildren (/usr/lib/nodejs/ast-types/lib/path-visitor.js:246:25)
at Visitor.PVp.visitWithoutReset
(/usr/lib/nodejs/ast-types/lib/path-visitor.js:204:20)
at
