Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Hideki Yamane]

control: tags -1 +patch +pending

Hi,

 Thanks for your patch, I'll test and upload in this weekend holiday.

-- 
Hideki Yamane 

Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Tatsuya Kinoshita]

Control: severity -1 grave

Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Tatsuya Kinoshita]

Control: retitle -1 riece: unusable on Emacs 26
Control: severity -1 serious
Control: tags -1 + patch

On April 17, 2019 at 7:57PM +0900, kmuto (at kmuto.jp) wrote:
> > If I replace ffloor with floor, it works.
> It's riece-server.el on Buster version. After I changed the file,
> it works like a charm!

Ah, it seems fixed in the upstream Git repo

http://git.savannah.nongnu.org/cgit/riece.git/commit/?id=b7c92250888d568a791e8270b2954c692ed837d3
using defalias instead of replacing ffloor.

Thanks,
-- 
Tatsuya Kinoshita

Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Kenshi Muto]

At Wed, 17 Apr 2019 18:37:29 +0900 (JST),
Tatsuya Kinoshita wrote:
> Refer to the upstream issue, :
> > Submitted by:   naruse  
> > Submitted on:   Mon 19 Nov 2018 11:39:47 AM UTC
> > It may work older emacs(?), but at least on my environment (emacs 26.1 on 
> > FreeBSD 26.1) it doesn't work.
> > If I replace ffloor with floor, it works.
> 
> ```
> --- a/lisp/riece-compat.el
> +++ b/lisp/riece-compat.el
> @@ -114,7 +114,7 @@
>  "Convert SECONDS (a floating point number) to a time value."
>  (list (floor seconds 65536)
> (floor (mod seconds 65536))
> -   (floor (* (- seconds (ffloor seconds)) 100)
> +   (floor (* (- seconds (floor seconds)) 100)
>  
>  (provide 'riece-compat)
> ```

It's riece-server.el on Buster version. After I changed the file,
it works like a charm!
Thanks!

OK, so Hideki, this problem will be solved by tiny patch, I believe.
-- 
Kenshi Muto
kmuto at kmuto jp

Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Tatsuya Kinoshita]

On April 17, 2019 at 2:19PM +0900, kmuto (at kmuto.jp) wrote:
> riece-unread.el:
> 63   (make-face 'riece-modeline-unread-face)
> 64  ;; "Face used for displaying unread channels in modeline.")
> 
> Now I succeeded to call M-x riece.

As Hideki mentioned, seems fixed in the upstream Git repo:

  - 
http://git.savannah.nongnu.org/cgit/riece.git/commit/?id=f7974cb688850bf3f41ee2f7329fc3d5e8c41c97

> But things goes worse.
> 
> Though I specified correct server for Riece asking, Emacs displayed
> just only 'Saving /home/kmuto/.riece/save... Done'.
> IRC process seems be running but no connection isn't established.

Refer to the upstream issue, :
> Submitted by: naruse  
> Submitted on: Mon 19 Nov 2018 11:39:47 AM UTC
> It may work older emacs(?), but at least on my environment (emacs 26.1 on 
> FreeBSD 26.1) it doesn't work.
> If I replace ffloor with floor, it works.

```
--- a/lisp/riece-compat.el
+++ b/lisp/riece-compat.el
@@ -114,7 +114,7 @@
 "Convert SECONDS (a floating point number) to a time value."
 (list (floor seconds 65536)
  (floor (mod seconds 65536))
- (floor (* (- seconds (ffloor seconds)) 100)
+ (floor (* (- seconds (floor seconds)) 100)
 
 (provide 'riece-compat)
```

Though not tested, I'm not a user of riece.

Thanks,
-- 
Tatsuya Kinoshita

Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Hideki Yamane]

control: tags -1 confirmed fixed-upstream

On Wed, 17 Apr 2019 12:14:22 +0900
Kenshi Muto  wrote:
> Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 2)

 It seems that is fixed in upstream git HEAD, but not investigate
 yet.


-- 
Hideki Yamane 

Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Kenshi Muto]

On Wed, 17 Apr 2019 12:14:22 +0900,
Kenshi Muto wrote:
> 4. wrote down below and M-x eval-region
>(setq debug-on-error t)
>(riece)
> 
> Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 2)
>   make-face(riece-modeline-current-face "Face used for displaying the current 
> channel in modeline.")

OK, error message told a reason.

I replaced:
riece-highlight.el:
197  (make-face 'riece-modeline-current-face)
198 ;; "Face used for displaying the current channel in modeline.")

riece-history.el:
68   (make-face 'riece-modeline-history-face)
69  ;; "Face used for displaying history channels in modeline.")

riece-unread.el:
63   (make-face 'riece-modeline-unread-face)
64  ;; "Face used for displaying unread channels in modeline.")

Now I succeeded to call M-x riece.
But things goes worse.

Though I specified correct server for Riece asking, Emacs displayed
just only 'Saving /home/kmuto/.riece/save... Done'.
IRC process seems be running but no connection isn't established.

Thanks,
-- 
Kenshi Muto
kmuto at kmuto.jp

Bug#927263: riece: error on (wrong-number-of-arguments (1 . 1) 2)

[Kenshi Muto]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Package: riece
Version: 9.0.0-8
Severity: normal

Dear Maintainer,

I upgraded my environment from Stretch to Buster, and noticed riece
won't boot up. (so the severity may be 'grave')

1. remove .riece folder

2. Run emacs26 by 'emacs -no-init-file -nw'

3. wrote down below and M-x eval-region
   (emacs-version)
   '26.1' was returned.

4. wrote down below and M-x eval-region
   (setq debug-on-error t)
   (riece)

Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 2)
  make-face(riece-modeline-current-face "Face used for displaying the current 
channel in modeline.")
  
byte-code("\300\301\302\303\304DD\305\306\307\310\311&\007\210\300\312\302\303\313DD\314\306\315\310\311&\007\210\316\317!\2040\0\320\317\321\"\210\322\317\323\324!\"\210\300\207"
 [custom-declare-variable riece-channel-list-mark-face-alist funcall function 
#f(compiled-function () #) "An alist mapping marks on 
riece-channel-list-buffer to faces." :type (repeat (cons character symbol)) 
:group riece-highlight riece-channel-list-font-lock-keywords 
#f(compiled-function () #) "Default expressions to highlight 
in riece-channel-list-mode." (repeat (list string)) riece-facep 
riece-modeline-current-face make-face "Face used for displaying the current 
channel in modeline." set-face-foreground face-foreground 
riece-channel-list-current-face] 8)
  require(riece-highlight)
  eval-buffer(# nil 
"/usr/share/emacs/site-lisp/riece/riece-ctcp.el" nil t)  ; Reading at buffer 
position 1122
  load-with-code-conversion("/usr/share/emacs/site-lisp/riece/riece-ctcp.el" 
"/usr/share/emacs/site-lisp/riece/riece-ctcp.el" nil t)
  require(riece-ctcp)
  riece-load-and-build-addon-dependencies((riece-alias riece-button riece-ctcp 
riece-ctlseq riece-guess riece-highlight riece-history riece-icon riece-ignore 
riece-keyword riece-log riece-mcat riece-menu riece-shrink-buffer riece-toolbar 
riece-unread riece-url))
  riece-resolve-addons((riece-highlight riece-history riece-icon riece-ignore 
riece-keyword riece-log riece-mcat riece-menu riece-shrink-buffer riece-toolbar 
riece-unread riece-url))
  riece(nil)
  funcall-interactively(riece nil)
  call-interactively(riece record nil)
  command-execute(riece record)
  execute-extended-command(nil "riece" "rie")
  funcall-interactively(execute-extended-command nil "riece" "rie")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)

- -- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-4-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8), 
LANGUAGE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages riece depends on:
ii  debconf  1.5.71
ii  emacs1:26.1+1-3.2
ii  emacs-gtk [emacsen]  1:26.1+1-3.2
ii  emacsen-common   3.0.4

riece recommends no packages.

Versions of packages riece suggests:
ii  dictionaries-common  1.28.1
pn  kakasi   
pn  lsdb 
ii  ruby-gettext 3.2.9-1

- -- no debconf information
-BEGIN PGP SIGNATURE-
Comment: Processed by Mailcrypt 3.5.9 

iQIzBAEBCgAdFiEEnMxcIsEJVbWPVaUbHSHIPcRS4PwFAly2mgUACgkQHSHIPcRS
4PxjlhAAlLIZ+5bXXb/xlNU0HN1e1+wEgrDCnswm0W2fpga0Jl68RxtcFRcBR40s
V6HAsH/ThGZzEMAPbN3f4qAg36OAxBXpn6ul49niUX2JVm2dwJj3wWXanHZEYapk
ectGfpTMJMQop0DgrZISNxCW33bPKzigUaYwOaKMlTgY/C41h+C54dSwHy/mEe6H
pwWOZeYx696z4V4T4YKO+cyz7MDxwcWfeBpCyEE9i2iAnguxMQYpTLfTS3GZySBh
oX3WiDqYUhKtRnvhIg/6R1s+3rCgkGbLOX1IChCxfye4MBurt6FymfD6eHqbv710
fiqItohPAjmkuuxDSBj4d1PBivFm54M/qWww4vsEWk03RguX5ZszH57+t/zujhtN
D49NSC7UGwcKrKhe4MbtL3mG+AeNaf5NUZiOF9FDhXpJXz/mX2eOMtGocuyr4bjD
u+MMO6tQSMNklncW74nZzaQ6lwBJcsIzLx+Iu9LVhxwdhXH+1vlrcRdId5CJayW6
KKAdXcgDVljekNZ/unQvoI/GnYxk4mCUEVAGXkot3pkE00aAPeZyHEqt5YejrYgE
W3qqpKSIOe8XA20viW3oXV7Nf5XLRScNrPPzqQ0WqGijOIw8CCsslcKwUbFgG9my
0gJelaTBPWkLydGl96MbRSNCcAoEtjIFgcYlUQwG1JkTvvrsMRY=
=ROsn
-END PGP SIGNATURE-