Bug#928021: opendnssec-enforcer: AllowExtraction should be supported but startup fails with it

2019-04-28 Thread Timo Aaltonen
On 28.4.2019 14.53, Mathieu Mirmont wrote:
> On Fri, Apr 26, 2019 at 02:44:29PM +0300, Timo Aaltonen wrote:
>> On 26.4.2019 14.33, Mathieu Mirmont wrote:
>>> control: tags -1 +confirmed
>>>
>>> On Fri, Apr 26, 2019 at 01:09:33PM +0300, Timo Aaltonen wrote:
 While testing FreeIPA, I noticed that enforcer startup fails if conf.xml 
 has  on it. The feature was forward-ported to 2.1 from 
 1.4, so it should work in theory but instead I get this on startup:

 /etc/opendnssec/conf.xml:11: element AllowExtraction: Relax-NG validity 
 error : Element Repository has extra content: AllowExtraction
 /etc/opendnssec/conf.xml:7: element Repository: Relax-NG validity error : 
 Element RepositoryList has extra content: Repository
>>>
>>> Hmm yeah. I can't imagine that this can have anything to do with the way
>>> the package is made. I'll have a look at the code and see if I can fix
>>> it myself (and send the patch upstream of course), otherwise I'll just
>>> report it upstream.
>>
>> Right, the upstream wiki is down so I didn't know where to send it..
> 
> It turns out that the conf.rn{cg} file(s) require the field to be
> named "AllowExtract" while everywhere in the code (including the
> sample conf.xml file) it is referred to as "AllowExtraction".
> 
> I fixed it in this commit and will send the patch upstream asap:
> https://salsa.debian.org/debian/opendnssec/commit/c15a42fbec6894e7ec6f21ce4713f509b2803d46

Hah, excellent.. nice catch. I couldn't see any fault in the original
commit after looking at it for 15min :)


-- 
t



Bug#928021: opendnssec-enforcer: AllowExtraction should be supported but startup fails with it

2019-04-28 Thread Mathieu Mirmont
On Fri, Apr 26, 2019 at 02:44:29PM +0300, Timo Aaltonen wrote:
> On 26.4.2019 14.33, Mathieu Mirmont wrote:
> > control: tags -1 +confirmed
> > 
> > On Fri, Apr 26, 2019 at 01:09:33PM +0300, Timo Aaltonen wrote:
> >> While testing FreeIPA, I noticed that enforcer startup fails if conf.xml 
> >> has  on it. The feature was forward-ported to 2.1 from 
> >> 1.4, so it should work in theory but instead I get this on startup:
> >>
> >> /etc/opendnssec/conf.xml:11: element AllowExtraction: Relax-NG validity 
> >> error : Element Repository has extra content: AllowExtraction
> >> /etc/opendnssec/conf.xml:7: element Repository: Relax-NG validity error : 
> >> Element RepositoryList has extra content: Repository
> > 
> > Hmm yeah. I can't imagine that this can have anything to do with the way
> > the package is made. I'll have a look at the code and see if I can fix
> > it myself (and send the patch upstream of course), otherwise I'll just
> > report it upstream.
> 
> Right, the upstream wiki is down so I didn't know where to send it..

It turns out that the conf.rn{cg} file(s) require the field to be
named "AllowExtract" while everywhere in the code (including the
sample conf.xml file) it is referred to as "AllowExtraction".

I fixed it in this commit and will send the patch upstream asap:
https://salsa.debian.org/debian/opendnssec/commit/c15a42fbec6894e7ec6f21ce4713f509b2803d46

Cheers,

-- 
Mathieu Mirmont 


signature.asc
Description: PGP signature


Bug#928021: opendnssec-enforcer: AllowExtraction should be supported but startup fails with it

2019-04-26 Thread Timo Aaltonen
On 26.4.2019 14.33, Mathieu Mirmont wrote:
> control: tags -1 +confirmed
> 
> On Fri, Apr 26, 2019 at 01:09:33PM +0300, Timo Aaltonen wrote:
>> While testing FreeIPA, I noticed that enforcer startup fails if conf.xml has 
>>  on it. The feature was forward-ported to 2.1 from 1.4, so 
>> it should work in theory but instead I get this on startup:
>>
>> /etc/opendnssec/conf.xml:11: element AllowExtraction: Relax-NG validity 
>> error : Element Repository has extra content: AllowExtraction
>> /etc/opendnssec/conf.xml:7: element Repository: Relax-NG validity error : 
>> Element RepositoryList has extra content: Repository
> 
> Hmm yeah. I can't imagine that this can have anything to do with the way
> the package is made. I'll have a look at the code and see if I can fix
> it myself (and send the patch upstream of course), otherwise I'll just
> report it upstream.

Right, the upstream wiki is down so I didn't know where to send it..


-- 
t



Bug#928021: opendnssec-enforcer: AllowExtraction should be supported but startup fails with it

2019-04-26 Thread Mathieu Mirmont
control: tags -1 +confirmed

On Fri, Apr 26, 2019 at 01:09:33PM +0300, Timo Aaltonen wrote:
> While testing FreeIPA, I noticed that enforcer startup fails if conf.xml has 
>  on it. The feature was forward-ported to 2.1 from 1.4, so 
> it should work in theory but instead I get this on startup:
> 
> /etc/opendnssec/conf.xml:11: element AllowExtraction: Relax-NG validity error 
> : Element Repository has extra content: AllowExtraction
> /etc/opendnssec/conf.xml:7: element Repository: Relax-NG validity error : 
> Element RepositoryList has extra content: Repository

Hmm yeah. I can't imagine that this can have anything to do with the way
the package is made. I'll have a look at the code and see if I can fix
it myself (and send the patch upstream of course), otherwise I'll just
report it upstream.

-- 
Mathieu Mirmont 


signature.asc
Description: PGP signature


Bug#928021: opendnssec-enforcer: AllowExtraction should be supported but startup fails with it

2019-04-26 Thread Timo Aaltonen
Package: opendnssec-enforcer
Severity: important

Hi,

While testing FreeIPA, I noticed that enforcer startup fails if conf.xml has 
 on it. The feature was forward-ported to 2.1 from 1.4, so it 
should work in theory but instead I get this on startup:

/etc/opendnssec/conf.xml:11: element AllowExtraction: Relax-NG validity error : 
Element Repository has extra content: AllowExtraction
/etc/opendnssec/conf.xml:7: element Repository: Relax-NG validity error : 
Element RepositoryList has extra content: Repository