Bug#928055: change "disable-pings" to "no-pings"?

2019-04-28 Thread ilf

Michael Gilbert:
The disable-pings flag has to do with the component updater [0]. 
[0]components/component_updater/component_updater_command_line_config_policy.cc


Thanks!

Full quote from upstream source:


// Disables pings. Pings are the requests sent to the update server that report
// the success or the failure of component install or update attempts.
const char kSwitchDisablePings[] = "disable-pings";


https://cs.chromium.org/chromium/src/components/component_updater/component_updater_command_line_config_policy.cc?type=cs=disable-pings=package:chromium=0=33

--
ilf

If you upload your address book to "the cloud", I don't want to be in it.


signature.asc
Description: PGP signature


Bug#928055: change "disable-pings" to "no-pings"?

2019-04-27 Thread Michael Gilbert
control: severity -1 wishlist
control: retitle -1 chromium: add "no-pings" flag

On Fri, Apr 26, 2019 at 7:09 PM ilf wrote:
> So either I am missing something here, or the Debian package
> default-flags should replace "disable-pings" with "no-pings".

The disable-pings flag has to do with the component updater [0].
Setting no-pings could be a useful addition.

Best wishes,
Mike

[0]components/component_updater/component_updater_command_line_config_policy.cc



Bug#928055: change "disable-pings" to "no-pings"?

2019-04-26 Thread ilf

Package: chromium
Version: 74.0.3729.108-1

The HTML Living Standard of the Web Hypertext Application Technology 
Working Group specifies Hyperlink auditing AKA "pinging": 
https://html.spec.whatwg.org/multipage/links.html#hyperlink-auditing


The Debian chromium package tries to disable this by default:

# Disable pinging 
export CHROMIUM_FLAGS="$CHROMIUM_FLAGS --disable-pings"


https://salsa.debian.org/chromium-team/chromium/raw/master/debian/etc/default-flags

However, the upstream source code uses "no-pings", not "disable-pings":


// Don't send hyperlink auditing pings
const char kNoPings[]   = "no-pings";


https://cs.chromium.org/chromium/src/chrome/common/chrome_switches.cc?q=kNoPings=package:chromium=cs=438

This is also echoed by a Google Software Engineer working on Google, 
Chrome & Android:



--no-pings
Don't send hyperlink auditing pings


https://peter.sh/experiments/chromium-command-line-switches/#no-pings

So either I am missing something here, or the Debian package 
default-flags should replace "disable-pings" with "no-pings".


--
ilf

If you upload your address book to "the cloud", I don't want to be in it.


signature.asc
Description: PGP signature