Bug#928093: unblock (pre-approval): gnome-shell/3.30.2-9, mutter/3.30.2-7
Control: tags 928093 - moreinfo Control: tags 928094 - moreinfo On Sat, 27 Apr 2019 at 21:32:00 +, Niels Thykier wrote: > Simon McVittie: > > Now that gnome-shell's RC bugs are (hopefully) dealt with, I'd like > > to update gnome-shell with the remaining bug fixes from the upstream > > gnome-3-30 branch, backported from 3.32.x development. ... > > While preparing gnome-shell/3.30.2-9 (see separate unblock request) I > > thought I should also look into updating the closely-related mutter > > package from the upstream gnome-3-30 stable branch. > > Please go ahead with the upload and remove the moreinfo tag once the > upload is in unstable and ready to be unblocked. Both uploaded and built on all release architectures (except gnome-shell:s390x, which is not a regression). Final debdiffs attached, piped through filterdiff -p1 --exclude 'debian/patches/Update-*-translation*.patch' in the case of gnome-shell. Thanks, smcv diffstat for gnome-shell-3.30.2 gnome-shell-3.30.2 changelog | 30 patches/ShellApp-Use-g_signal_connect_object-for-window-signals.patch |9 patches/Update-Icelandic-translation.patch | 1981 ++ patches/Update-Scottish-Gaelic-translation-1.patch | 332 + patches/Update-Scottish-Gaelic-translation.patch| 1889 + patches/dnd-Only-handle-touch-events-in-wayland.patch | 34 patches/inputMethod-Avoid-calling-set_preedit_text-if-unnecessary.patch | 48 patches/inputMethod-Keep-track-of-preedit-string-visibility.patch | 69 patches/messageTray-Re-enable-unredirection-when-banner-is-destro.patch | 47 patches/series | 12 patches/windowManager-Don-t-animate-touch-touchpad-gesture-in-ove.patch | 41 11 files changed, 4487 insertions(+), 5 deletions(-) diff -Nru gnome-shell-3.30.2/debian/changelog gnome-shell-3.30.2/debian/changelog --- gnome-shell-3.30.2/debian/changelog 2019-04-20 22:29:02.0 +0100 +++ gnome-shell-3.30.2/debian/changelog 2019-04-28 00:13:04.0 +0100 @@ -1,3 +1,33 @@ +gnome-shell (3.30.2-9) unstable; urgency=medium + + * Team upload + * d/p/ShellApp-Use-g_signal_connect_object-for-window-signals.patch: +Mark as forwarded and applied upstream + * d/p/tweener-Save-handlers-on-target-and-remove-them-on-destro.patch, +d/p/workaround_crasher_fractional_scaling.patch: +Move non-upstreamed patches to appear last in d/p/series + * Update patch series from gnome-3-30 branch, up to 3.30.2-19-g1f03c94d3 +- d/p/inputMethod-Avoid-calling-set_preedit_text-if-unnecessary.patch, + d/p/inputMethod-Keep-track-of-preedit-string-visibility.patch: + Avoid a bad interaction between gnome-shell, GTK, non-English input + methods, WebKitGTK and Evolution that can cause text to be deleted + unintentionally when Ctrl or Alt is pressed (Closes: #927719) +- d/p/messageTray-Re-enable-unredirection-when-banner-is-destro.patch: + If a notification appears while a game or other graphically intensive + application is full-screen, correctly re-enable unredirection (for + its performance benefits) when the notification closes + (Closes: #927718) +- d/p/dnd-Only-handle-touch-events-in-wayland.patch: + Fix a bug seen in X11 mode where extensions that use drag-and-drop, + such as dash-to-dock, can get the Shell into a state where + interaction with apps is no longer possible +- d/p/windowManager-Don-t-animate-touch-touchpad-gesture-in-ove.patch: + When the four-finger swipe up/down touchpad gesture is used to move + between workspaces, don't move application windows to the wrong place +- Update translations: gd, is + + -- Simon McVittie Sun, 28 Apr 2019 00:13:04 +0100 + gnome-shell (3.30.2-8) unstable; urgency=medium * Team upload diff -Nru gnome-shell-3.30.2/debian/patches/dnd-Only-handle-touch-events-in-wayland.patch gnome-shell-3.30.2/debian/patches/dnd-Only-handle-touch-events-in-wayland.patch --- gnome-shell-3.30.2/debian/patches/dnd-Only-handle-touch-events-in-wayland.patch 1970-01-01 01:00:00.0 +0100 +++ gnome-shell-3.30.2/debian/patches/dnd-Only-handle-touch-events-in-wayland.patch 2019-04-28 00:13:04.0 +0100 @@ -0,0 +1,34 @@ +From: Andrea Azzarone +Date: Mon, 4 Mar 2019 16:14:22 + +Subject: dnd: Only handle touch events in wayland + +There are serveral issues around touch passive grab and touch/pointer doubly +handling to use these on X11, so we stick to single-touch/pointer there. + +Bug: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1015 +Origin: upstream, 3.30.3, commit:843ed09b0954f256225b6aacc631a9131a191981 +--- + js/ui/dnd.js | 10 ++ + 1 file changed, 10 insertions(+) + +diff --git a/js/ui/dnd.js b/js/ui/dnd.js +index 8483e89..755c49b 100644 +--- a/js/ui/dnd.js b/js/ui/dnd.js
Bug#928093: unblock (pre-approval): gnome-shell/3.30.2-9
Control: tags -1 moreinfo confirmed Simon McVittie: > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock > > Now that gnome-shell's RC bugs are (hopefully) dealt with, I'd like > to update gnome-shell with the remaining bug fixes from the upstream > gnome-3-30 branch, backported from 3.32.x development. > >> [...] > > Proposed diff attached, filtering out the translation update patches for > brevity. Is this (plus a `dch -r`) suitable for upload to unstable? > > Thanks, > smcv > Please go ahead with the upload and remove the moreinfo tag once the upload is in unstable and ready to be unblocked. Thanks, ~Niels
Bug#928093: unblock (pre-approval): gnome-shell/3.30.2-9
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Now that gnome-shell's RC bugs are (hopefully) dealt with, I'd like to update gnome-shell with the remaining bug fixes from the upstream gnome-3-30 branch, backported from 3.32.x development. > gnome-shell (3.30.2-9) UNRELEASED; urgency=medium > > * d/p/ShellApp-Use-g_signal_connect_object-for-window-signals.patch: > Mark as forwarded and applied upstream > * d/p/tweener-Save-handlers-on-target-and-remove-them-on-destro.patch, > d/p/workaround_crasher_fractional_scaling.patch: > Move non-upstreamed patches to appear last in d/p/series Basically documentation: no functional effect. > * Update patch series from gnome-3-30 branch, up to 3.30.2-19-g1f03c94d3 > - d/p/inputMethod-Avoid-calling-set_preedit_text-if-unnecessary.patch, > d/p/inputMethod-Keep-track-of-preedit-string-visibility.patch: > Avoid a bad interaction between gnome-shell, GTK, non-English input > methods, WebKitGTK and Evolution that can cause text to be deleted > unintentionally when Ctrl or Alt is pressed (Closes: #927719) This seems like a nasty failure mode. I'm not sure whether it has already been fixed in buster via one of the other affected components, but it's probably safest to deal with "complicated interaction" bugs like this by making all the components as robust as possible. > - d/p/messageTray-Re-enable-unredirection-when-banner-is-destro.patch: > If a notification appears while a game or other graphically intensive > application is full-screen, correctly re-enable unredirection (for > its performance benefits) when the notification closes > (Closes: #927718) This can apparently be quite a bad performance regression, and is easily fixed. > - d/p/dnd-Only-handle-touch-events-in-wayland.patch: > Fix a bug seen in X11 mode where extensions that use drag-and-drop, > such as dash-to-dock, can get the Shell into a state where > interaction with apps is no longer possible This seems like a nasty failure mode, and is particularly important if people want to make X11 mode the default for GNOME (as was done for stretch). > - d/p/windowManager-Don-t-animate-touch-touchpad-gesture-in-ove.patch: > When the four-finger swipe up/down touchpad gesture is used to move > between workspaces, don't move application windows to the wrong place This seems somewhat obscure, but it's a straightforward fix. > - Update translations: gd, is Presumably harmless. Proposed diff attached, filtering out the translation update patches for brevity. Is this (plus a `dch -r`) suitable for upload to unstable? Thanks, smcv debian/changelog | 29 + ..._signal_connect_object-for-window-signals.patch |9 +- debian/patches/Update-Icelandic-translation.patch | 1981 .../Update-Scottish-Gaelic-translation-1.patch | 332 .../Update-Scottish-Gaelic-translation.patch | 1889 +++ .../dnd-Only-handle-touch-events-in-wayland.patch | 34 + ...d-calling-set_preedit_text-if-unnecessary.patch | 48 + ...d-Keep-track-of-preedit-string-visibility.patch | 69 + ...nable-unredirection-when-banner-is-destro.patch | 47 + debian/patches/series | 12 +- ...n-t-animate-touch-touchpad-gesture-in-ove.patch | 41 + 11 files changed, 4486 insertions(+), 5 deletions(-) diff --git a/debian/changelog b/debian/changelog index 6f6c22a11..67aec735f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,32 @@ +gnome-shell (3.30.2-9) UNRELEASED; urgency=medium + + * d/p/ShellApp-Use-g_signal_connect_object-for-window-signals.patch: +Mark as forwarded and applied upstream + * d/p/tweener-Save-handlers-on-target-and-remove-them-on-destro.patch, +d/p/workaround_crasher_fractional_scaling.patch: +Move non-upstreamed patches to appear last in d/p/series + * Update patch series from gnome-3-30 branch, up to 3.30.2-19-g1f03c94d3 +- d/p/inputMethod-Avoid-calling-set_preedit_text-if-unnecessary.patch, + d/p/inputMethod-Keep-track-of-preedit-string-visibility.patch: + Avoid a bad interaction between gnome-shell, GTK, non-English input + methods, WebKitGTK and Evolution that can cause text to be deleted + unintentionally when Ctrl or Alt is pressed (Closes: #927719) +- d/p/messageTray-Re-enable-unredirection-when-banner-is-destro.patch: + If a notification appears while a game or other graphically intensive + application is full-screen, correctly re-enable unredirection (for + its performance benefits) when the notification closes + (Closes: #927718) +- d/p/dnd-Only-handle-touch-events-in-wayland.patch: + Fix a bug seen in X11 mode where extensions that use drag-and-drop, + such as dash-to-dock, can get the Shell into a state where + interaction
