Bug#928219: libusbauth-configparser: autopkgtest makes improper use of sudo
On Tue, Apr 30, 2019 at 01:16:35PM +0800, Kun-Hung Tsai(蔡昆宏) wrote: > Hi Steve, > Thanks for your kindly advice. > In version 1.0.1+git20190123.0e6393b-2, I ran ldconfig with sudo but got a > "command not found" error. > That's why I fix it with sudo in version 1.0.1+git20190123.0e6393b-3. Ok. In Ubuntu, ldconfig is on the default path for non-root users, which is why this now passes there. For Debian, you probably need to either call /sbin/ldconfig with a full path, or add /sbin to $PATH. > [...] > > autopkgtest [22:24:11]: test test: [--- > /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: > 9: /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: > ldconfig: not found > run: Check if library file exist > run: Fail > autopkgtest [22:24:11]: test test: ---] > autopkgtest [22:24:11]: test test: - - - - - - - - - - results - - - > - - - - - - - > test FAIL non-zero exit status 1 > autopkgtest [22:24:12]: test test: - - - - - - - - - - stderr - - - - > - - - - - - > /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: > 9: /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: > ldconfig: not found > > [...] > > However, it caused the new problem you mentioned. > I will try to figure out why these days and do you have any idea about the > "command not found" error? > > Thanks again for your help. > > > Kun-Hung Tsai > > > Steve Langasek 於 2019年4月30日 週二 下午12:57寫道： > > > Package: libusbauth-configparser > > Version: 1.0.1+git20190123.0e6393b-3 > > Severity: important > > Tags: patch > > User: ubuntu-de...@lists.ubuntu.com > > Usertags: origin-ubuntu eoan ubuntu-patch > > > > Dear Kun-Hung, > > > > With the sync of libusbauth-configparser 1.0.1+git20190123.0e6393b-3 to > > Ubuntu from Debian unstable, the autopkgtest now fails on armhf: > > > > [...] > > autopkgtest [06:11:25]: test test: [--- > > run: Check if library file exist > > sudo: no tty present and no askpass program specified > > run: Fail > > autopkgtest [06:11:27]: test test: ---] > > [...] > > > > ( > > http://autopkgtest.ubuntu.com/packages/libu/libusbauth-configparser/eoan/armhf > > ) > > > > This is because you have introduced the use of sudo into your autopkgtest. > > An autopkgtest environment is not guaranteed to permit passwordless sudo; > > if > > an autopkgtest needs root privileges, it must instead declare > > 'Restrictions: > > needs-root' and be run as root by the test harness. > > > > However, in this case the only thing you're running under sudo is 'ldconfig > > -p', which only looks at the system cache and is not a privileged > > operation. > > So the simplest fix here is to just drop the use of sudo. > > > > Please see the attached patch, which I have uploaded to Ubuntu. > > > > Thanks, > > -- > > Steve Langasek Give me a lever long enough and a Free OS > > Debian Developer to set it on, and I can move the world. > > Ubuntu Developer https://www.debian.org/ > > slanga...@ubuntu.com vor...@debian.org > > -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org signature.asc Description: PGP signature
Bug#928219: libusbauth-configparser: autopkgtest makes improper use of sudo
Hi Steve, Thanks for your kindly advice. In version 1.0.1+git20190123.0e6393b-2, I ran ldconfig with sudo but got a "command not found" error. That's why I fix it with sudo in version 1.0.1+git20190123.0e6393b-3. [...] autopkgtest [22:24:11]: test test: [--- /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: 9: /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: ldconfig: not found run: Check if library file exist run: Fail autopkgtest [22:24:11]: test test: ---] autopkgtest [22:24:11]: test test: - - - - - - - - - - results - - - - - - - - - - test FAIL non-zero exit status 1 autopkgtest [22:24:12]: test test: - - - - - - - - - - stderr - - - - - - - - - - /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: 9: /tmp/autopkgtest-lxc.976e8wyk/downtmp/build.gAc/src/debian/tests/test: ldconfig: not found [...] However, it caused the new problem you mentioned. I will try to figure out why these days and do you have any idea about the "command not found" error? Thanks again for your help. Kun-Hung Tsai Steve Langasek 於 2019年4月30日 週二 下午12:57寫道： > Package: libusbauth-configparser > Version: 1.0.1+git20190123.0e6393b-3 > Severity: important > Tags: patch > User: ubuntu-de...@lists.ubuntu.com > Usertags: origin-ubuntu eoan ubuntu-patch > > Dear Kun-Hung, > > With the sync of libusbauth-configparser 1.0.1+git20190123.0e6393b-3 to > Ubuntu from Debian unstable, the autopkgtest now fails on armhf: > > [...] > autopkgtest [06:11:25]: test test: [--- > run: Check if library file exist > sudo: no tty present and no askpass program specified > run: Fail > autopkgtest [06:11:27]: test test: ---] > [...] > > ( > http://autopkgtest.ubuntu.com/packages/libu/libusbauth-configparser/eoan/armhf > ) > > This is because you have introduced the use of sudo into your autopkgtest. > An autopkgtest environment is not guaranteed to permit passwordless sudo; > if > an autopkgtest needs root privileges, it must instead declare > 'Restrictions: > needs-root' and be run as root by the test harness. > > However, in this case the only thing you're running under sudo is 'ldconfig > -p', which only looks at the system cache and is not a privileged > operation. > So the simplest fix here is to just drop the use of sudo. > > Please see the attached patch, which I have uploaded to Ubuntu. > > Thanks, > -- > Steve Langasek Give me a lever long enough and a Free OS > Debian Developer to set it on, and I can move the world. > Ubuntu Developer https://www.debian.org/ > slanga...@ubuntu.com vor...@debian.org >
Bug#928219: libusbauth-configparser: autopkgtest makes improper use of sudo
Package: libusbauth-configparser Version: 1.0.1+git20190123.0e6393b-3 Severity: important Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu eoan ubuntu-patch Dear Kun-Hung, With the sync of libusbauth-configparser 1.0.1+git20190123.0e6393b-3 to Ubuntu from Debian unstable, the autopkgtest now fails on armhf: [...] autopkgtest [06:11:25]: test test: [--- run: Check if library file exist sudo: no tty present and no askpass program specified run: Fail autopkgtest [06:11:27]: test test: ---] [...] (http://autopkgtest.ubuntu.com/packages/libu/libusbauth-configparser/eoan/armhf) This is because you have introduced the use of sudo into your autopkgtest. An autopkgtest environment is not guaranteed to permit passwordless sudo; if an autopkgtest needs root privileges, it must instead declare 'Restrictions: needs-root' and be run as root by the test harness. However, in this case the only thing you're running under sudo is 'ldconfig -p', which only looks at the system cache and is not a privileged operation. So the simplest fix here is to just drop the use of sudo. Please see the attached patch, which I have uploaded to Ubuntu. Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org diff -Nru libusbauth-configparser-1.0.1+git20190123.0e6393b/debian/tests/test libusbauth-configparser-1.0.1+git20190123.0e6393b/debian/tests/test --- libusbauth-configparser-1.0.1+git20190123.0e6393b/debian/tests/test 2019-04-20 21:50:05.0 -0700 +++ libusbauth-configparser-1.0.1+git20190123.0e6393b/debian/tests/test 2019-04-29 21:51:24.0 -0700 @@ -6,7 +6,7 @@ set -e echo "run: Check if library file exist" -if sudo ldconfig -p | grep libusbauth-configparser +if ldconfig -p | grep libusbauth-configparser then echo "run: Found libary" else
