Bug#931631: Wrong dependency on virtual logind packages
Am 09.07.19 um 01:49 schrieb Colin Watson: > On Tue, Jul 09, 2019 at 12:44:20AM +0200, Michael Biebl wrote: >> Am 08.07.19 um 18:13 schrieb Colin Watson: >>> CCing Adam, who suggested the default-logind | logind part of this; I >>> know very little about elogind myself. >>> >>> I can see how an "artificial" dependency like this might make sense to >>> avoid libpam-systemd being pulled in for people who aren't using >>> systemd, though, even if other logind implementations don't provide the >>> same session registration features. >> >> Well, if that is the sole reason why that alternative dependency was >> added, then this is a poor choice. > > Assuming that my attempt to restate the requirement is correct, what's > your concrete alternative proposal, implementable in openssh, that also > satisfies that requirement? Assuming it is, there is none (atm), or is there? So imho it's best to revert this change since it doesn't achieve what it is supposed to achieve and is simply confusing. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#931631: Wrong dependency on virtual logind packages
On Tue, Jul 09, 2019 at 12:44:20AM +0200, Michael Biebl wrote: > Am 08.07.19 um 18:13 schrieb Colin Watson: > > CCing Adam, who suggested the default-logind | logind part of this; I > > know very little about elogind myself. > > > > I can see how an "artificial" dependency like this might make sense to > > avoid libpam-systemd being pulled in for people who aren't using > > systemd, though, even if other logind implementations don't provide the > > same session registration features. > > Well, if that is the sole reason why that alternative dependency was > added, then this is a poor choice. Assuming that my attempt to restate the requirement is correct, what's your concrete alternative proposal, implementable in openssh, that also satisfies that requirement? I'm not enthusiastic about simply reverting the change from #923199, unless the people who requested it tell me that it's not in fact needed. > Also, it would have been a good idea to mention that in the changelog. To be fair I'm reverse-engineering this from bug records and the like; it didn't seem a big deal to me at the time, so I didn't work out all the details sufficiently to describe them in the changelog. > What you really want to fix is apt trying to satisfy a recommends over > uninstalling/installing a new init system (which tbh I find kinda odd, > that apt prefers to uninstall a package over not installing a recommends). It's not in my power to change apt's dependency resolution in a reasonable time frame. > And also, this alternative dependency is completely useless if you don't > already have elogind installed, which I suspect is the case (about 1% > have sysvinit installed, the number for elogind is only statistic noise). Well, I may also have made a wrong guess as to the underlying reason for the request, so hopefully Adam can fill in more detail. -- Colin Watson [cjwat...@debian.org]
Bug#931631: Wrong dependency on virtual logind packages
Am 08.07.19 um 18:13 schrieb Colin Watson: > On Mon, Jul 08, 2019 at 03:14:59PM +0200, Michael Biebl wrote: >> in #923199, the recommends libpam-systemd was changed to >> default-logind | logind | libpam-systemd >> >> This doesn't really make sense, as openssh does not use any of the >> logind D-Bus interfaces that are supposed to be provided by those >> virtual facilities. >> The libpam-systemd recommends is there to ensure that login sessions are >> registered by logind and properly moved into their own cgroups. >> This is not a functionality that is provided by elogind or even relevant >> for elogind. > > CCing Adam, who suggested the default-logind | logind part of this; I > know very little about elogind myself. > > I can see how an "artificial" dependency like this might make sense to > avoid libpam-systemd being pulled in for people who aren't using > systemd, though, even if other logind implementations don't provide the > same session registration features. Well, if that is the sole reason why that alternative dependency was added, then this is a poor choice. Also, it would have been a good idea to mention that in the changelog. What you really want to fix is apt trying to satisfy a recommends over uninstalling/installing a new init system (which tbh I find kinda odd, that apt prefers to uninstall a package over not installing a recommends). And also, this alternative dependency is completely useless if you don't already have elogind installed, which I suspect is the case (about 1% have sysvinit installed, the number for elogind is only statistic noise). Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#931631: Wrong dependency on virtual logind packages
On Mon, Jul 08, 2019 at 03:14:59PM +0200, Michael Biebl wrote: > in #923199, the recommends libpam-systemd was changed to > default-logind | logind | libpam-systemd > > This doesn't really make sense, as openssh does not use any of the > logind D-Bus interfaces that are supposed to be provided by those > virtual facilities. > The libpam-systemd recommends is there to ensure that login sessions are > registered by logind and properly moved into their own cgroups. > This is not a functionality that is provided by elogind or even relevant > for elogind. CCing Adam, who suggested the default-logind | logind part of this; I know very little about elogind myself. I can see how an "artificial" dependency like this might make sense to avoid libpam-systemd being pulled in for people who aren't using systemd, though, even if other logind implementations don't provide the same session registration features. -- Colin Watson [cjwat...@debian.org]
Bug#931631: Wrong dependency on virtual logind packages
Package: openssh-server Version: 1:7.9p1-10 Severity: normal Hi, in #923199, the recommends libpam-systemd was changed to default-logind | logind | libpam-systemd This doesn't really make sense, as openssh does not use any of the logind D-Bus interfaces that are supposed to be provided by those virtual facilities. The libpam-systemd recommends is there to ensure that login sessions are registered by logind and properly moved into their own cgroups. This is not a functionality that is provided by elogind or even relevant for elogind. -- System Information: Debian Release: 10.0 APT prefers unstable APT policy: (500, 'unstable'), (200, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages openssh-server depends on: ii adduser3.118 ii debconf [debconf-2.0] 1.5.72 ii dpkg 1.19.7 ii libaudit1 1:2.8.4-3 ii libc6 2.28-10 ii libcom-err21.45.2-1 ii libgssapi-krb5-2 1.17-3 ii libkrb5-3 1.17-3 ii libpam-modules 1.3.1-5 ii libpam-runtime 1.3.1-5 ii libpam0g 1.3.1-5 ii libselinux12.9-2 ii libssl1.1 1.1.1c-1 ii libsystemd0242-2 ii libwrap0 7.6.q-28 ii lsb-base 10.2019051400 ii openssh-client 1:7.9p1-10 ii openssh-sftp-server1:7.9p1-10 ii procps 2:3.3.15-2 ii ucf3.0038+nmu1 ii zlib1g 1:1.2.11.dfsg-1 Versions of packages openssh-server recommends: ii libpam-systemd 242-2 ii ncurses-term6.1+20181013-2 ii xauth 1:1.0.10-1 Versions of packages openssh-server suggests: pn molly-guard pn monkeysphere pn rssh ii ssh-askpass 1:1.2.4.1-10 pn ufw -- debconf information excluded
