Bug#932465: dgit cowbuilder' fails with "unrecognized option"

2019-07-19 Thread Ian Jackson
gregor herrmann writes ("Re: Bug#932465: dgit cowbuilder' fails with 
"unrecognized option""):
> On Fri, 19 Jul 2019 19:56:32 +0100, Ian Jackson wrote:
> > In the meantime, gregor (and anyone else reading this):
> > I think a workaround is to pass this command-line option to dgit:
> > 
> >   --cowbuilder!:--no-source-only-changes
> 
> I can confirm that
> dgit --rm-old-changes --cowbuilder\!:--no-source-only-changes cowbuilder
> worked.

Good, thaks.

> > This assumes that your cowbuilder is not configured to do source only
> > changes by default.  If it does then I think you may have to adjust
> > that, because dgit is of course only invoking cowbuilder to build
> > binaries (presumably for your formal test build), and if you wanted to
> > do a source-only upload you would just use dgit push-source.
> 
> I'm happy with my current build setup for now, just wanted to play
> with dgit.
> 
> And I've successfully uploaded 2 packages with `dgit push-source'
> already :) which is the more important part in my understanding.

Yes.  Indeed if you are happy with your build setup for formal test
builds, there is no need to use dgit to do builds.  dgit push-source
is sufficient.

If you want to go through NEW or to upload to security (where
source-only uploads are not permitted) then you may find you need
dgit cowbuilder (or some other dgit build rune) working.

Ian.

-- 
Ian JacksonThese opinions are my own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.



Bug#932465: dgit cowbuilder' fails with "unrecognized option"

2019-07-19 Thread gregor herrmann
On Fri, 19 Jul 2019 19:56:32 +0100, Ian Jackson wrote:

> In the meantime, gregor (and anyone else reading this):
> 
> I think a workaround is to pass this command-line option to dgit:
> 
>   --cowbuilder!:--no-source-only-changes

I can confirm that
dgit --rm-old-changes --cowbuilder\!:--no-source-only-changes cowbuilder
worked.
 
> This assumes that your cowbuilder is not configured to do source only
> changes by default.  If it does then I think you may have to adjust
> that, because dgit is of course only invoking cowbuilder to build
> binaries (presumably for your formal test build), and if you wanted to
> do a source-only upload you would just use dgit push-source.

I'm happy with my current build setup for now, just wanted to play
with dgit.

And I've successfully uploaded 2 packages with `dgit push-source'
already :) which is the more important part in my understanding.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature


Bug#932465: dgit cowbuilder' fails with "unrecognized option"

2019-07-19 Thread Ian Jackson
Control: reassign -1 cowbuilder
Control: retitle -1 cowbuilder: Please implement --no-source-only-changes

gregor herrmann writes ("Bug#932465: dgit cowbuilder' fails with "unrecognized 
option""):
> AFAIK, pbuilder knows about --no-source-only-changes but cowbuilder
> doesn't .. (So it can be argued that this should actually be fixed in
> cowbuilder.)

Oh!  It hadn't occurred to Sean or me that this would need separate
support in cowbuilder.

pbuilder maintainers:

you were very resposive in #904716 (which was this issue wrt pbuilder)
so I hope you will appreciate me simply reassigning this bug to
cowbuilder.

If you think implementing this may take a while, or is a bad idea for
some reason, please let us know.  In that case it might be sensible to
change dgit to treat cowbuilder and pbuilder differently in this
respect, or something.


In the meantime, gregor (and anyone else reading this):

I think a workaround is to pass this command-line option to dgit:

  --cowbuilder!:--no-source-only-changes

This assumes that your cowbuilder is not configured to do source only
changes by default.  If it does then I think you may have to adjust
that, because dgit is of course only invoking cowbuilder to build
binaries (presumably for your formal test build), and if you wanted to
do a source-only upload you would just use dgit push-source.

HTH.

Regards,
Ian.



Bug#932465: dgit cowbuilder' fails with "unrecognized option"

2019-07-19 Thread gregor herrmann
Package: dgit
Version: 9.3
Severity: normal

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

% dgit --gbp cowbuilder:(
Format `3.0 (quilt)', need to check/update patch stack
gzip: warning: GZIP environment variable is deprecated; use an alias or script
dgit: split brain (separate dgit view) may be needed (--quilt=gbp).
dgit view: found cached (commit id d2bad975cdde31874a55b8f6b8ae2ff010b127bf)
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building libkiokudb-perl using existing 
./libkiokudb-perl_0.57.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: building libkiokudb-perl in 
libkiokudb-perl_0.57-2.debian.tar.xz
dpkg-source: info: building libkiokudb-perl in libkiokudb-perl_0.57-2.dsc
changelog will contain changes since 0.57-1
dpkg-genchanges: info: not including original source code in upload
cowbuilder: unrecognized option '--no-source-only-changes'
E: Unhandled option
dgit: failed command: sudo -E cowbuilder build --no-source-only-changes 
--debbuildopts '-nc -b' --distribution unstable libkiokudb-perl_0.57-2.dsc

dgit: error: subprocess failed with error exit status 1



AFAIK, pbuilder knows about --no-source-only-changes but cowbuilder
doesn't .. (So it can be argued that this should actually be fixed in
cowbuilder.)


Cheers
gregor

- -- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'unstable-debug'), (500, 
'oldoldstable'), (500, 'experimental'), (500, 'testing'), (500, 'stable'), 
(500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=de_AT.utf8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages dgit depends on:
ii  apt 1.8.2
ii  ca-certificates 20190110
ii  coreutils   8.30-3
ii  curl7.65.1-1
ii  devscripts  2.19.5
ii  dpkg-dev1.19.7
ii  dput1.0.3
ii  git [git-core]  1:2.22.0-1
ii  git-buildpackage0.9.14
pn  libdigest-sha-perl  
ii  libdpkg-perl1.19.7
ii  libjson-perl4.02000-1
ii  liblist-moreutils-perl  0.416-1+b4
ii  liblocale-gettext-perl  1.07-3+b4
ii  libtext-glob-perl   0.10-1
ii  libtext-iconv-perl  1.7-6
ii  libwww-perl 6.39-1
ii  perl5.28.1-6

Versions of packages dgit recommends:
ii  openssh-client [ssh-client]  1:8.0p1-3

Versions of packages dgit suggests:
ii  cowbuilder  0.88
ii  pbuilder0.230.4
ii  sbuild  0.78.1-2

- -- no debconf information

-BEGIN PGP SIGNATURE-

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl0yC2BfFIAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qga+0RAAuX7ND4qyJe8CT40ymwGWicOXKwMc2OcpKV3W64sVjiIJ8rmlbvn8pcdG
Y79jAhZw6dOZwB4N11gbNHVhyaaf0i2VkFXbEMYXRsUttCg33YIaGSJSwOdDYCRg
cg1vsF4T0RvuREhXGqx+awBLwprxN27L2gU8KM2zkFTaP3IDgVoGF6DiEtQ8vZcF
QdapU2zY5brAMfhdoDCWv+vqGDaXYcmn2j9T+y+JO/cK9dQktPpSXy0tQcuYtchi
yUGsngR4wpVmqhzdqjdUrgauk5iDAevSJSKsSePqqY6c7HxTM3D4OH/XpTYHBvLS
9vsk5rl72lAcMX3Pq4ewD0ocxQHLVw35ijLJLCBk07J+wfta7yLccSTQQTt37GlP
pHxKVwQ81BCrcqNEwhLKuX8vqh0fWrOZQehv73bf8Ca6QbEKvtKLCwAQ9gWQaRQB
dMA5jdNtWq/nVnl+zVI18e+sfrbKbmUD6yrlmzUaN9xjRPd9EVQIACXTYZ4L1dGa
4S8X9dB3sNeTWBglcO0Pn/3bg2eZ7h6Da9FLMuXK1GmmqU6NrjKHagv1O5tJpfYn
5sAPimB2CJWTMykxmRw2vJy94nkFfkhCkQK2/mHU2pkFGaQ6cC4njU8kkfc1+mL0
V7GsLgFjkyiCTy3rLxg5L7Xg1q9Fcg9RJWGbnCyOuyYcC3ac99M=
=MYK5
-END PGP SIGNATURE-