Bug#933450: fityk: Please rebuild against wxWidgets GTK 3 package

2019-09-25 Thread Olly Betts
On Thu, Aug 08, 2019 at 02:59:56PM +1000, Stuart Prescott wrote:
> On Thursday, 8 August 2019 09:57:42 AEST Olly Betts wrote:
> > There have been a lot of GTK3-related fixes in wxGTK since then so I'd
> > expect it to work much better now.
> 
> Thanks for that useful info, Olly.
> 
> I've uploaded it to experimental building against GTK3 so we can see that it 
> builds and tests correctly everywhere (although the tests aren't really going 
> to test the GUI!). That also makes packages that are easier to test.

It's had more than 6 weeks in experimental now - unless that's uncovered
problems, maybe it's time to upload to unstable?

Cheers,
Olly



Bug#933450: fityk: Please rebuild against wxWidgets GTK 3 package

2019-08-07 Thread Stuart Prescott
On Thursday, 8 August 2019 09:57:42 AEST Olly Betts wrote:
> There have been a lot of GTK3-related fixes in wxGTK since then so I'd
> expect it to work much better now.

Thanks for that useful info, Olly.

I've uploaded it to experimental building against GTK3 so we can see that it 
builds and tests correctly everywhere (although the tests aren't really going 
to test the GUI!). That also makes packages that are easier to test.

regards
Stuart

-- 
Stuart Prescotthttp://www.nanonanonano.net/   stu...@nanonanonano.net
Debian Developer   http://www.debian.org/ stu...@debian.org
GPG fingerprint90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7



Bug#933450: fityk: Please rebuild against wxWidgets GTK 3 package

2019-08-07 Thread Olly Betts
On Thu, Aug 08, 2019 at 12:13:34AM +1000, Stuart Prescott wrote:
> Unfortunately, fityk does not yet appear to be ready to make that switch, 
> with 
> the following in included in the code:
> 
> https://github.com/wojdyr/fityk/blob/master/wxgui/app.cpp#L11
> 
> #ifdef __WXGTK3__
> #error "Not everything is working with wxGTK3. Use default wxGTK instead, " \
>"based on GTK+2. If you want to test it, just remove this #error."
> #endif
> 
> I have tried running fityk with wxGTK3 but haven't yet worked out what works 
> and what does not. I'll write to upstream to seek advice.

git blame shows that check was added 5 years ago:

https://github.com/wojdyr/fityk/blame/master/wxgui/app.cpp#L11

There have been a lot of GTK3-related fixes in wxGTK since then so I'd
expect it to work much better now.

Cheers,
Olly



Bug#933450: fityk: Please rebuild against wxWidgets GTK 3 package

2019-08-07 Thread Stuart Prescott
Control: tags -1 + upstream help

Hi!

Thanks for detailed information on how to switch to the GTK 3 version of 
wxWidgets.

Unfortunately, fityk does not yet appear to be ready to make that switch, with 
the following in included in the code:

https://github.com/wojdyr/fityk/blob/master/wxgui/app.cpp#L11

#ifdef __WXGTK3__
#error "Not everything is working with wxGTK3. Use default wxGTK instead, " \
   "based on GTK+2. If you want to test it, just remove this #error."
#endif

I have tried running fityk with wxGTK3 but haven't yet worked out what works 
and what does not. I'll write to upstream to seek advice.

regards
Stuart


-- 
Stuart Prescotthttp://www.nanonanonano.net/   stu...@nanonanonano.net
Debian Developer   http://www.debian.org/ stu...@debian.org
GPG fingerprint90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7