Control: tags -1 + upstream
Control: fixed -1 4.89+dfsg-0.1
Dear Maintainer,
I just tried to find some more informations about this issue.
The lsof version 4.89+dfsg-0.1 did not show this issue, therefore
Stretch is not affected. It started with version 4.91+dfsg-1 which
is already contained in Buster.
As far as I see, the issue is /proc/[pid]/stat contains
usually a single line with all process informations.
Therefore lsof needs to parse that line.
It looks like linux delivers the process name parenthesised and
cropped to the first 16 characters.
Then lsof 4.91 got a change to handle process names with parenthesises
better, therefore counts them in the process name.
Therefore there is an issue with process names where parenthesises are
beyond the 16 character limit or the number of left parenthesises is
higher than the right parenthesises.
The minimal example to demonstrate the issue would be:
root@debian:~# perl -E '$0 = "("; print "My PID is $$\n"; '
My PID is 13957
root@debian:~# lsof -p 13957
root@debian:~# hexdump -C /proc/13957/stat
31 33 39 35 37 20 28 28 29 20 53 20 34 39 32 36 |13957 (() S
4926|
...
The source location is around lsof-4.91+dfsg/dialects/linux/dproc.c,
lines 1568 to 1602.
Looking at 'ps aux', a different approach is used there:
The file /proc/[pid]/stat gets read as a whole and then
searched for the first '(' and then in reverse direction
from the end for the ')'.
In procps-3.3.15/proc/readproc.c, lines 597 and 600.
Maybe lsof could also use libprocps7 for that, too?
Kind regards,
Bernhard
PS.: It looks like the value set by perl is even when terminated a
lot longer than '('. Therefore 'ps aux' prints a lot of spaces
for the process name. Would that justify to open an bug there too?
root@debian:~# hexdump -C /proc/13957/cmdline
28 00 20 20 20 20 20 20 20 20 20 20 20 20 20 20 |(. |
0010 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 ||
*
0100 00|.|
0101
# Minimal Qemu VMs 2019-08-19
##
apt update
apt dist-upgrade
reboot
##
root@debian:~# cat /etc/debian_version
bullseye/sid
root@debian:~# perl -E '$0 = "with-hyphen (and paren)"; print "My PID is $$\n";
'
My PID is 473
...
root@debian:~# lsof -p 473
root@debian:~# ps aux | grep 473
root 473 0.0 0.1 10572 4532 pts/0S+ 22:42 0:00 with-hyphen
(and paren)
root 494 0.0 0.0 6088 828 pts/1S+ 23:19 0:00 grep 473
root@debian:~#
#
root@debian:~# cat /etc/debian_version
10.0
root@debian:~# perl -E '$0 = "with-hyphen (and paren)"; print "My PID is $$\n";
'
My PID is 456
...
root@debian:~# lsof -p 456
root@debian:~# ps aux | grep 456
root 456 0.0 0.1 10572 4228 pts/0S+ 22:43 0:00 with-hyphen
(and paren)
root 486 0.0 0.0 6088 892 pts/1S+ 23:18 0:00 grep 456
root@debian:~#
#
root@debian:~# cat /etc/debian_version
9.9
root@debian:~# perl -E '$0 = "with-hyphen (and paren)"; print "My PID is $$\n";
'
My PID is 519
...
root@debian:~# lsof -p 519
COMMAND PID USER FD TYPE DEVICE SIZE/OFFNODE NAME
with-hyph 519 root cwdDIR8,1 4096 1048579 /root
with-hyph 519 root rtdDIR8,1 4096 2 /
with-hyph 519 root txtREG8,1 2021960 919288 /usr/bin/perl
with-hyph 519 root memREG8,139256 655504
/lib/x86_64-linux-gnu/libcrypt-2.24.so
with-hyph 519 root memREG8,1 1689360 655486
/lib/x86_64-linux-gnu/libc-2.24.so
with-hyph 519 root memREG8,1 135440 655655
/lib/x86_64-linux-gnu/libpthread-2.24.so
with-hyph 519 root memREG8,1 1063328 655508
/lib/x86_64-linux-gnu/libm-2.24.so
with-hyph 519 root memREG8,114640 655506
/lib/x86_64-linux-gnu/libdl-2.24.so
with-hyph 519 root memREG8,1 153288 655396
/lib/x86_64-linux-gnu/ld-2.24.so
with-hyph 519 root memREG8,1 1679840 918472
/usr/lib/locale/locale-archive
with-hyph 519 root0u CHR 136,0 0t0 3 /dev/pts/0
with-hyph 519 root1u CHR 136,0 0t0 3 /dev/pts/0
with-hyph 519 root2u CHR 136,0 0t0 3 /dev/pts/0
root@debian:~#
--> Got introduced between Stretch and Buster release?
2017-06-17: Initial release: 9.0
2019-07-06: Initial release: 10.0
#
/etc/approx/approx.conf
debian-10-buster-snapshot.debian.org
