Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2021-02-18 Thread Chris Hofstaedtler
Control: severity -1 normal

* Dmitry Bogatov  [2019-09-11 16:15]:
> control: severity -1 +normal

That appears to have failed. Trying again, as a service :-)



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-11-10 Thread Dmitry Bogatov



[2019-11-10 02:31] Santiago Vila 
> > I am losing context. We have at least following three files (oh, why all
> > this madness?):
> > 
> >  * /usr/lib/os-release
> >  * /etc/os-release
> >  * /etc/debian_version
> > 
> > So, in case of conflicts, what should override what?
>
> Please note that /usr/lib/os-release and /etc/os-release are the same file.

Thank you for your patience.

> AFAIK, lsb-release is already ignoring /etc/debian_version in buster,
> which is the reason we have this problem.

Not exactly. We have following code, where get_os_release() reads
"/usr/lib/os-release", and guess_debian_release() uses several other
files, including "/etc/debian_version".

lsbinfo = get_os_release()
# OS is only used inside guess_debian_release anyway
for key in ('ID', 'RELEASE', 'CODENAME', 'DESCRIPTION',):
if key not in lsbinfo:
distinfo = guess_debian_release()
distinfo.update(lsbinfo)
return distinfo
 else:
 return lsbinfo

So /etc/os-release overrides /etc/debian_version. Probably, we could
drop guess_debian_release() code though, since base-files are essential.

> b) As it has been suggested by you, fixing the problem in base-files
> by including the minor version in /etc/os-release "somewhere".
>
> I am ok with doing the change in base-files, because I believe it's
> the best option in the long term.
>
> I also believe that it would suffice to change VERSION_ID, but I need
> confirmation for that.
> [..]
>
> So: Is this ok for you?

Yes, that is fine. As I just checked, `lsb_release -d` (as is in
Archives) will happily output anything I put into VERSION_ID variable of
/etc/os_release.
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-11-09 Thread Santiago Vila
On Sun, Nov 10, 2019 at 01:13:08AM +, Dmitry Bogatov wrote:
> 
> control: tags -1 +help
> 
> [2019-11-08 13:42] Santiago Vila 
> > Hi.
> >
> > I've asked the Release Managers about this here:
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944351
> >
> > If they say yes, I'll modify base-files accordingly (for Debian 10.2).
> >
> > If they say no, please be ready to fix the bug in lsb-release as soon
> > as you can, by making an upload to proposed-updates (there is a point
> > release around the corner).
> 
> I am losing context. We have at least following three files (oh, why all
> this madness?):
> 
>  * /usr/lib/os-release
>  * /etc/os-release
>  * /etc/debian_version
> 
> So, in case of conflicts, what should override what?

Please note that /usr/lib/os-release and /etc/os-release are the same file.

AFAIK, lsb-release is already ignoring /etc/debian_version in buster,
which is the reason we have this problem.

We should either:

a) modify lsb-release so that it looks at /etc/debian_version again
(i.e. reverting the recent change)

or

b) As it has been suggested by you, fixing the problem in base-files
by including the minor version in /etc/os-release "somewhere".

I am ok with doing the change in base-files, because I believe it's
the best option in the long term.

I also believe that it would suffice to change VERSION_ID, but I need
confirmation for that.

My feeling is that Release Managers would welcome this change if it's
*limited* to VERSION_ID. Rationale: Major Release versions are integer
numbers (7, 8, 9, 10, etc), and we identify "buster" with "Debian 10",
without minor version, i.e. there should be no need
to change PRETTY_NAME or VERSION, only VERSION_ID.

So: Is this ok for you?

Thanks.



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-11-09 Thread Dmitry Bogatov


control: tags -1 +help

[2019-11-08 13:42] Santiago Vila 
> Hi.
>
> I've asked the Release Managers about this here:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944351
>
> If they say yes, I'll modify base-files accordingly (for Debian 10.2).
>
> If they say no, please be ready to fix the bug in lsb-release as soon
> as you can, by making an upload to proposed-updates (there is a point
> release around the corner).

I am losing context. We have at least following three files (oh, why all
this madness?):

 * /usr/lib/os-release
 * /etc/os-release
 * /etc/debian_version

So, in case of conflicts, what should override what?

BTW, help via NMU/Team upload is welcome.
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-11-08 Thread Santiago Vila
Hi.

I've asked the Release Managers about this here:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944351

If they say yes, I'll modify base-files accordingly (for Debian 10.2).

If they say no, please be ready to fix the bug in lsb-release as soon
as you can, by making an upload to proposed-updates (there is a point
release around the corner).

Thanks.



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-09-11 Thread Dmitry Bogatov


control: severity -1 +normal

[2019-09-10 10:21] Jonathan Wiltshire 
> >> The x.y there was a remnant from Debian sarge times.
> > 
> > Up until squeeze I have seen it show x.y.z, then from wheezy to
> > stretch I see only x.y, but it does seem new behaviour in buster to
> > only show x.
> > 
> > $ ansible '*' -i inventories/testing -a 'lsb_release -d' | grep ^Descr | 
> > sort -u
> > Description:Debian GNU/Linux 10 (buster)
> > Description:Debian GNU/Linux 8.11 (jessie)
> > Description:Debian GNU/Linux 9.10 (stretch)
>
> This stems from lsb_release switching to reading the cross-distro
> standard file, /usr/lib/os-release:
>
> | $ cat /etc/debian_version
> | 10.1
> | $ cat /usr/lib/os-release
> | PRETTY_NAME="Debian GNU/Linux 10 (buster)"
> | NAME="Debian GNU/Linux"
> | VERSION_ID="10"
> | VERSION="10 (buster)"

As pointed by maintainer of base-files, this format of
/usr/lib/os-release is with us for some time (just checked on stretch
box).

In theory, I can revert #914287, but is it good thing? Actually, I fail
to see the whole point of `lsb_release` command. You can't squash all
information in your /etc/apt/sources.list into two digits.

This said, I feel current behaviour more logical. LSB pretends to
provide cross-distributions interface, so reading /usr/lib/os-release
feels more natural than /etc/debian_release.
-- 
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-09-10 Thread Santiago Vila
reassign 939733 lsb-release
thanks

On Tue, 10 Sep 2019, Jonathan Wiltshire wrote:

> This stems from lsb_release switching to reading the cross-distro
> standard file, /usr/lib/os-release:

Therefore it was lsb_release who changed behaviour, not base-files.

> So arguably base-files should be updating that file with point release
> information, just as /etc/debian_version is. The spec [1] does not rule
> that out, and other distributions do so:

Not ruling out != mandating it.

> Severity upgraded because it causes an unexpected behaviour change in
> lsb_release, but feel free to adjust.

There was already a bug in base-files for this:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931197

and it will be considered for bullseye, but the fact that os-release
does not change in Debian is clearly documented in the base-files
changelog:

 base-files (10.2) unstable; urgency=medium
 [...]
 Add also VERSION_ID and VERSION. (never expected to change)

So it may not be argued that this is a surprise from base-files side.

Reassigning again.

Thanks.



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-09-10 Thread Jonathan Wiltshire
Control: reassign -1 base-files
Control: severity -1 serious
Control: found -1 10.3+deb10u1

Hi,

On 09/09/2019 13:54, Andy Smith wrote:
> Hello,
> 
> On Sun, Sep 08, 2019 at 05:08:12PM +0200, Thorsten Glaser wrote:
>> On Sun, 8 Sep 2019, Markku Leiniö wrote:
>>> On Buster, "lsb_release -d" does not show the point release:
>>>
>>> $ lsb_release -d
>>> Description:Debian GNU/Linux 10 (buster)
>>
>> Isn’t that a feature?
>>
>> The x.y there was a remnant from Debian sarge times.
> 
> Up until squeeze I have seen it show x.y.z, then from wheezy to
> stretch I see only x.y, but it does seem new behaviour in buster to
> only show x.
> 
> $ ansible '*' -i inventories/testing -a 'lsb_release -d' | grep ^Descr | sort 
> -u
> Description:Debian GNU/Linux 10 (buster)
> Description:Debian GNU/Linux 8.11 (jessie)
> Description:Debian GNU/Linux 9.10 (stretch)

This stems from lsb_release switching to reading the cross-distro
standard file, /usr/lib/os-release:

| $ cat /etc/debian_version
| 10.1
| $ cat /usr/lib/os-release
| PRETTY_NAME="Debian GNU/Linux 10 (buster)"
| NAME="Debian GNU/Linux"
| VERSION_ID="10"
| VERSION="10 (buster)"

So arguably base-files should be updating that file with point release
information, just as /etc/debian_version is. The spec [1] does not rule
that out, and other distributions do so:

| $ cat /etc/os-release
| NAME="Red Hat Enterprise Linux Server"
| VERSION="7.7 (Maipo)"
| VERSION_ID="7.7"
| PRETTY_NAME="Red Hat Enterprise Linux"

Please consider doing this urgently in stable, and possible even as a
stable update - it's having knock-on effects for us in several places
already, and I'm sure there will be other users with similar stories.

Severity upgraded because it causes an unexpected behaviour change in
lsb_release, but feel free to adjust.

1: https://www.freedesktop.org/software/systemd/man/os-release.html

Thanks,

-- 
Jonathan Wiltshire

Red Hat Certified Engineer (#170-281-083)

Tiger Computing Ltd
ISO27001:2017 Certified

Tel: 01600 483 484
Web: http://www.tiger-computing.co.uk

Registered in England. Company number: 3389961
Registered address: Wyastone Business Park,
 Wyastone Leys, Monmouth, NP25 3SR



signature.asc
Description: OpenPGP digital signature


Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-09-09 Thread Andy Smith
Hello,

On Sun, Sep 08, 2019 at 05:08:12PM +0200, Thorsten Glaser wrote:
> On Sun, 8 Sep 2019, Markku Leiniö wrote:
> > On Buster, "lsb_release -d" does not show the point release:
> > 
> > $ lsb_release -d
> > Description:Debian GNU/Linux 10 (buster)
> 
> Isn’t that a feature?
> 
> The x.y there was a remnant from Debian sarge times.

Up until squeeze I have seen it show x.y.z, then from wheezy to
stretch I see only x.y, but it does seem new behaviour in buster to
only show x.

$ ansible '*' -i inventories/testing -a 'lsb_release -d' | grep ^Descr | sort -u
Description:Debian GNU/Linux 10 (buster)
Description:Debian GNU/Linux 8.11 (jessie)
Description:Debian GNU/Linux 9.10 (stretch)

Cheers,
Andy



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-09-08 Thread Thorsten Glaser
On Sun, 8 Sep 2019, Markku Leiniö wrote:

> On Buster, "lsb_release -d" does not show the point release:
> 
> $ lsb_release -d
> Description:Debian GNU/Linux 10 (buster)

Isn’t that a feature?

The x.y there was a remnant from Debian sarge times.

bye,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg



Bug#939733: lsb-release: lsb_release does not show point release on Debian 10.1

2019-09-08 Thread Markku Leiniö
Package: lsb-release
Version: 10.2019051400
Severity: normal

Dear Maintainer,

On Stretch, the "lsb_release -d" command shows the point release, like
this:

$ lsb_release -d
Description:Debian GNU/Linux 9.10 (stretch)

On Buster, "lsb_release -d" does not show the point release:

$ lsb_release -d
Description:Debian GNU/Linux 10 (buster)
$ cat /etc/debian_version
10.1

The expected output of "lsb_release -d" on Debian 10.1 would be:

Description:Debian GNU/Linux 10.1 (buster)


-- Package-specific info:
lsb_release output
-*- -*- -*- -*- -*-
Distributor ID: Debian
Description:Debian GNU/Linux 10 (buster)
Release:10
Codename:   buster
-*- -*- -*- -*- -*-
Apt policy
-*- -*- -*- -*- -*-
Package files:
 100 /var/lib/dpkg/status
 release a=now
 500 http://repo.zabbix.com/zabbix/4.0/debian buster/main amd64 Packages
 release o=Zabbix,n=buster,l=zabbix,c=main,b=amd64
 origin repo.zabbix.com
 500 https://download.docker.com/linux/debian buster/stable amd64 Packages
 release o=Docker,a=buster,l=Docker CE,c=stable,b=amd64
 origin download.docker.com
 500 http://www.nic.funet.fi/debian buster-updates/main amd64 Packages
 release o=Debian,a=stable-updates,n=buster-updates,l=Debian,c=main,b=amd64
 origin www.nic.funet.fi
 500 http://security.debian.org/debian-security buster/updates/main amd64 
Packages
 release v=10,o=Debian,a=stable,n=buster,l=Debian-Security,c=main,b=amd64
 origin security.debian.org
 500 http://www.nic.funet.fi/debian buster/main amd64 Packages
 release v=10.1,o=Debian,a=stable,n=buster,l=Debian,c=main,b=amd64
 origin www.nic.funet.fi
Pinned packages:
-*- -*- -*- -*- -*-
   sources.list
-*- -*- -*- -*- -*-
deb http://www.nic.funet.fi/debian/ buster main
deb-src http://www.nic.funet.fi/debian/ buster main
deb http://security.debian.org/debian-security buster/updates main
deb-src http://security.debian.org/debian-security buster/updates main
deb http://www.nic.funet.fi/debian/ buster-updates main
deb-src http://www.nic.funet.fi/debian/ buster-updates main
deb [arch=amd64] https://download.docker.com/linux/debian buster stable
-*- -*- -*- -*- -*-
 /etc/lsb_release
-*- -*- -*- -*- -*-
- none

-- System Information:
Debian Release: 10.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lsb-release depends on:
ii  distro-info-data  0.41
ii  python3   3.7.3-1

Versions of packages lsb-release recommends:
ii  apt  1.8.2

Versions of packages lsb-release suggests:
pn  lsb  

-- no debconf information