Bug#940319: backintime: run test suite during build

2024-06-30 Thread Maytham Alsudany
Hi Christian,

On Mon, 29 Aug 2022 10:10:37 + c.bu...@posteo.jp wrote:
> On Sun, 15 Sep 2019 15:16:25 +0100 Jonathan Wiltshire  wrote:
> > In 1.2 upstream added a test suite. We should run it during build
> > (cd common && $(MAKE) test) but it needs to be able to write to the 
> > home
> > directory, which is disabled on Debian auto-builders. Need to find
> > a solution to that.
> 
> I would like to suggest to save time and resources and not fixing that
> Issue.

Wouldn't a simple solution be creating a temporary home directory and directing
the tests there? From a quick look at the code, it seems os.path.expanduser is
used to determine the home directory, and according to the Python docs[1], "an
initial ~ is replaced by the environment variable HOME if it is set".

Kind regards,
-- 
Maytham Alsudany
Debian Maintainer

maytham @ OFTC
maytha8 @ Libera

[1]: https://docs.python.org/3/library/os.path.html#os.path.expanduser



signature.asc
Description: This is a digitally signed message part


Bug#940319: backintime: run test suite during build

2022-08-29 Thread c . buhtz

Dear Jonathan,


In 1.2 upstream added a test suite. We should run it during build
(cd common && $(MAKE) test) but it needs to be able to write to the 
home

directory, which is disabled on Debian auto-builders. Need to find
a solution to that.


I would like to suggest to save time and resources and not fixing that 
Issue.


The test infrastructure of BIT will be modified to a modern and more 
python-recommended solution (src-layout of the project folder and 
"tests" folder outside the package folder). To be honest this won't 
happen early because currently there are other more urgent problems for 
BIT that need to be fixed before restructuring the whole project 
layout/infrastructure (which would breaking everything in the first 
place).


And "writing to home" seems like a bad workaround/hack. A unittest 
shouldn't write to a real filesystem. And IMHO (personaly not as 
upstream) distributors should support such an unusual solution. This is 
a problem that I also will take into account at upstream.


I vote for closing this issue. Upstream will contact you when it is time 
to restructure the project infrastructure including the test suite.




Bug#940319: backintime: run test suite during build

2019-09-15 Thread Jonathan Wiltshire
Source: backintime
Version: 1.2.1-1
Severity: wishlist

In 1.2 upstream added a test suite. We should run it during build
(cd common && $(MAKE) test) but it needs to be able to write to the home
directory, which is disabled on Debian auto-builders. Need to find
a solution to that.

-- System Information:
Debian Release: 10.1
  APT prefers proposed-updates
  APT policy: (990, 'proposed-updates'), (990, 'stable'), (500, 
'stable-updates'), (500, 'oldstable-updates'), (500, 'unstable'), (500, 
'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled