Bug#941162: php-horde-mime: DEP-8 tests fail with error "Class 'Horde_Test_Case' not found".

[Mathieu Parent]

Le mer. 25 sept. 2019 à 21:03, Bryce Harrington
 a écrit :
>
> Package: php-horde-mime
> Version: 2.11.0-2
> Severity: normal
>
> Dear Maintainer,

Thanks for your report.

> php-horde-mime fails its DEP-8 test with the error shown below, on
> ci.debian.net, and similar failure was seen in Ubuntu.
>
> PHP Fatal error:  Uncaught Error: Class 'Horde_Test_Case' not found in 
> /tmp/autopkgtest.WKueSZ/build.G63/src/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php:26
> Stack trace:
> #0 /usr/share/php/PHPUnit/Util/FileLoader.php(57): include_once()
> #1 /usr/share/php/PHPUnit/Util/FileLoader.php(45): 
> PHPUnit\Util\FileLoader::load('/tmp/autopkgtes...')
> #2 /usr/share/php/PHPUnit/Framework/TestSuite.php(540): 
> PHPUnit\Util\FileLoader::checkAndLoad('/tmp/autopkgtes...')
> #3 /usr/share/php/PHPUnit/Framework/TestSuite.php(618): 
> PHPUnit\Framework\TestSuite->addTestFile('/tmp/autopkgtes...')
> #4 /usr/share/php/PHPUnit/Runner/BaseTestRunner.php(70): 
> PHPUnit\Framework\TestSuite->addTestFiles(Array)
> #5 /usr/share/php/PHPUnit/TextUI/Command.php(183): 
> PHPUnit\Runner\BaseTestRunner->getTest('.', '', Array)
> #6 /usr/share/php/PHPUnit/TextUI/Command.php(162): 
> PHPUnit\TextUI\Command->run(Array, true)
> #7 /usr/bin/phpunit(42): PHPUnit\TextUI\Command::main()
> #8 {main}
>   thrown in 
> /tmp/autopkgtest.WKueSZ/build.G63/src/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php
>  on line 26
>
> Debian log:
> 
> https://ci.debian.net/data/autopkgtest/unstable/amd64/p/php-horde-mime/3015914/log.gz
> Ubuntu log:
> 
> https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan/eoan/amd64/p/php-horde-mime/20190913_195327_67b6b@/log.gz
>
> I've added a patch in Ubuntu that works around the issue by adding an
> include for AllTests.php.  (Is it possible AllTests.php is supposed to
> be automatically included, yet isn't for some reason?)

This looks like a workaround indeed.

Currently almost all horde packages fails in CI, there is a huge work
here and I need help. I don't want to merge those workaround patches
until we have a summary of the different kind of problems. Also, we
need to work with upstream.

Can Ubuntu help here?

See also : https://salsa.debian.org/groups/horde-team/-/merge_requests

Regards

Mathieu Parent

Bug#941162: php-horde-mime: DEP-8 tests fail with error "Class 'Horde_Test_Case' not found".

[Bryce Harrington]

Package: php-horde-mime
Version: 2.11.0-2
Severity: normal

Dear Maintainer,

php-horde-mime fails its DEP-8 test with the error shown below, on
ci.debian.net, and similar failure was seen in Ubuntu.

PHP Fatal error:  Uncaught Error: Class 'Horde_Test_Case' not found in 
/tmp/autopkgtest.WKueSZ/build.G63/src/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php:26
Stack trace:
#0 /usr/share/php/PHPUnit/Util/FileLoader.php(57): include_once()
#1 /usr/share/php/PHPUnit/Util/FileLoader.php(45): 
PHPUnit\Util\FileLoader::load('/tmp/autopkgtes...')
#2 /usr/share/php/PHPUnit/Framework/TestSuite.php(540): 
PHPUnit\Util\FileLoader::checkAndLoad('/tmp/autopkgtes...')
#3 /usr/share/php/PHPUnit/Framework/TestSuite.php(618): 
PHPUnit\Framework\TestSuite->addTestFile('/tmp/autopkgtes...')
#4 /usr/share/php/PHPUnit/Runner/BaseTestRunner.php(70): 
PHPUnit\Framework\TestSuite->addTestFiles(Array)
#5 /usr/share/php/PHPUnit/TextUI/Command.php(183): 
PHPUnit\Runner\BaseTestRunner->getTest('.', '', Array)
#6 /usr/share/php/PHPUnit/TextUI/Command.php(162): 
PHPUnit\TextUI\Command->run(Array, true)
#7 /usr/bin/phpunit(42): PHPUnit\TextUI\Command::main()
#8 {main}
  thrown in 
/tmp/autopkgtest.WKueSZ/build.G63/src/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php
 on line 26

Debian log:

https://ci.debian.net/data/autopkgtest/unstable/amd64/p/php-horde-mime/3015914/log.gz
Ubuntu log:

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan/eoan/amd64/p/php-horde-mime/20190913_195327_67b6b@/log.gz

I've added a patch in Ubuntu that works around the issue by adding an
include for AllTests.php.  (Is it possible AllTests.php is supposed to
be automatically included, yet isn't for some reason?)

-- System Information:
Debian Release: buster/sid
  APT prefers bionic-updates
  APT policy: (500, 'bionic-updates'), (500, 'bionic-security'), (500, 
'bionic'), (100, 'bionic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-62-generic (SMP w/6 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages php-horde-mime depends on:
ii  php-common   1:60ubuntu1
pn  php-horde-exception  
pn  php-horde-listheaders
pn  php-horde-mail   
pn  php-horde-stream 
pn  php-horde-stream-filter  
pn  php-horde-support
pn  php-horde-text-flowed
pn  php-horde-translation
pn  php-horde-util   

Versions of packages php-horde-mime recommends:
pn  php-horde-nls  
pn  php-horde-test 
pn  php-horde-text-filter  
pn  php-idn
pn  php-intl   
pn  php-net-dns2   

php-horde-mime suggests no packages.
Description: Fix test failure with "Class 'Horde_Test_Case' not found"
 Explicitly include AllTests.php to fix missing base class issue.  I get
 the impression this should really be automatically included but is not
 in our case.
Author: Bryce Harrington 
Origin: vendor
Last-Update: 2019-09-16

diff -Nurp php-horde-mime-2.11.0/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php php-horde-mime-2.11.0-fixed/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php
--- php-horde-mime-2.11.0/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php	2018-01-14 22:49:19.0 +
+++ php-horde-mime-2.11.0-fixed/Horde_Mime-2.11.0/test/Horde/Mime/Filter/EncodingTest.php	2019-09-13 21:40:17.263283745 +
@@ -1,4 +1,7 @@
 http://www.horde.org/)
  *