Bug#947760: [Pkg-javascript-devel] Bug#947760: Bug#947760: why ?

2019-12-31 Thread Paolo Greppi
Il 30/12/19 11:36, Xavier ha scritto:
> ...
> I think that npm is needed when a package has to be build locally.
> That's why a "recommends" should be enough
> 

Xavier, I have enabled salsa CI on node-es6-iterator repo and fixed it to run 
tests with yarnpkg so that the dependency on npm can be dropped from 
debian/tests/control

See this run:
https://salsa.debian.org/js-team/node-es6-iterator/-/jobs/483337

If you think this fixes the issue, please go ahead and close this bug.

Paolo

P.S. Regarding node-es6-iterator autopkgtest, after "node 
./node_modules/tad/bin/tad" it prints "No tests run".
This is the same as before when tests were run with "npm run test":
https://salsa.debian.org/js-team/node-es6-iterator/-/jobs/483318
But it does not seem right !
If I run the tests in the source tree with "yarnpkg install && yarnpkg test" 
this is what i see:

yarn run v1.21.1
$ node ./node_modules/tad/bin/tad
15:56:30.392  ✓  #/chain.js ...
15:56:30.397  ✓  array.js ...
15:56:30.404  ✓  for-of.js ...
15:56:30.409  ✓  get.js ...
15:56:30.411  ✓  index.js ..
15:56:30.415  ✓  is-iterable.js .
15:56:30.417  ✓  string.js 
15:56:30.419  ✓  valid-iterable.js ..

.037 141 Ok [100.00%]

Done in 0.83s.



Bug#947760: [Pkg-javascript-devel] Bug#947760: Bug#947760: why ?

2019-12-30 Thread Xavier
Le 30/12/2019 à 10:58, Pirate Praveen a écrit :
> 
> 
> On തി, Dec 30, 2019 at 10:48, Xavier  wrote:
>> Hi,
>>
>> See node-es6-iterator debian/tests/control, 'yarnpkg install' fails
>> without npm. You should add npm as recommended dependency at least
> 
> That is likely a bug in node-es6-iterator or it needs npm explicitly. In
> gitlab, yarnpkg install has been working all the time without npm.

I think that npm is needed when a package has to be build locally.
That's why a "recommends" should be enough



Bug#947760: [Pkg-javascript-devel] Bug#947760: Bug#947760: why ?

2019-12-30 Thread Pirate Praveen




On തി, Dec 30, 2019 at 10:48, Xavier  wrote:

Hi,

See node-es6-iterator debian/tests/control, 'yarnpkg install' fails 
without npm. You should add npm as recommended dependency at least


That is likely a bug in node-es6-iterator or it needs npm explicitly. 
In gitlab, yarnpkg install has been working all the time without npm.