Bug#948269: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

2020-01-06 Thread Christoph Biedl
James McCoy wrote...

> Autopkgtests already run against packages in experimental, albeit at a
> slower pace than those in unstable.  It seems those did catch the issue
> -- https://release.debian.org/britney/pseudo-excuses-experimental.html#file

TIL - now added to the list of things to check before the first upload
to unstable.

Christoph


signature.asc
Description: PGP signature


Bug#948269: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

2020-01-06 Thread James McCoy
On Mon, Jan 06, 2020 at 12:19:21PM +0100, Christoph Biedl wrote:
> Additionally, I always upload new upstream versions of src:file to
> experimental first to avoid situations like this. If anybody wishes to
> receive a notification to start tests, drop me a line with your e-mail
> address, preferably group/team/package address. That list is public.

Autopkgtests already run against packages in experimental, albeit at a
slower pace than those in unstable.  It seems those did catch the issue
-- https://release.debian.org/britney/pseudo-excuses-experimental.html#file

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB



Bug#948269: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

2020-01-06 Thread Christoph Biedl
Control: tags 948269 tags pending upstream

Sebastian Ramacher wrote...

(...)
> Note the difference in dynamically linked vs statically linked. This
> change breaks dh_shlibdeps causing ${shlibs:Depends} to not be properly
> populated.

That was a change done upstream:

|PR/93: iaeiaeiaeiae: Do as the comment says, and count as dynamically 
linked
|only the binaries that have an interpreter, not the ones that contain a
|dynamic section. Fixes issue with -static-pie from gcc-9.x


... which obviously requires a re-visit.

Assuming the current version of src:file breaks more or less the entire
buildd infrastructure, I'll upload a new version, reverting that commit.
As you can see from the commit message, this might introduce issues in
other places - so please keep me informed about any future problems.

For example, I've spotted a regression as follows:

-./debian-bugs/882310/dummy.so: ELF 64-bit LSB pie executable, x86-64, version 
1 (SYSV), no program header, not stripped
+./debian-bugs/882310/dummy.so: ELF 64-bit LSB shared object, x86-64, version 1 
(SYSV), no program header, not stripped

Additionally, I always upload new upstream versions of src:file to
experimental first to avoid situations like this. If anybody wishes to
receive a notification to start tests, drop me a line with your e-mail
address, preferably group/team/package address. That list is public.

Christoph


signature.asc
Description: PGP signature


Bug#948269: file: misdetection of shared libraries as statically linked - breaks dh_shlibdeps

2020-01-06 Thread Sebastian Ramacher
Package: file
Version: 1:5.38-2
Severity: grave

With file version 1:5.37-6:

$ file /usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0
/usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0: ELF 64-bit LSB shared object, 
x86-64, version 1 (SYSV), dynamically linked, 
BuildID[sha1]=4b36146a48b30a0658cbd4c0f32cdf262be38a5f, stripped

With file version 1:5.38-2:

$ file /usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0
/usr/lib/x86_64-linux-gnu/libcrypt.so.1.1.0: ELF 64-bit LSB shared object, 
x86-64, version 1 (SYSV), statically linked, 
BuildID[sha1]=4b36146a48b30a0658cbd4c0f32cdf262be38a5f, stripped

Note the difference in dynamically linked vs statically linked. This
change breaks dh_shlibdeps causing ${shlibs:Depends} to not be properly
populated.

Cheers

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (650, 'unstable-debug'), (650, 'unstable'), (601, 'testing'), 
(600, 'experimental-debug'), (600, 'buildd-unstable'), (600, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.3.0-3-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages file depends on:
ii  libc6  2.29-8
ii  libmagic1  1:5.38-2

file recommends no packages.

file suggests no packages.

-- no debconf information

-- 
Sebastian Ramacher


signature.asc
Description: PGP signature