Bug#949623: [pkg-cryptsetup-devel] Bug#949623: cryptsetup: cryptdisks_stop/start bash completion broken

[Guilhem Moulin]

Control: found -1 2:1.7.0-1

On Wed, 22 Jan 2020 at 23:28:37 +0100, Guilhem Moulin wrote:
> If that's a regression it's older than 2:2.0.3-1, AFAICT stretch has
> the same problem.

Before 2:1.7.0-1 the completion file was copied into
/etc/bash_completion.d, which AFAICT bash traverses and sources at
startup.

-- 
Guilhem.


signature.asc
Description: PGP signature

Bug#949623: [pkg-cryptsetup-devel] Bug#949623: cryptsetup: cryptdisks_stop/start bash completion broken

[Guilhem Moulin]

Control: tag -1 moreinfo
Control: severity -1 minor

On Wed, 22 Jan 2020 at 23:08:32 +0100, Christoph Anton Mitterer wrote:
> in .bashrc, and that's enough for all other completions... e.g. the one
> for cryptsetup work (more or less).

~$ foo looks for /usr/share/bash-completion/completions/foo (and
also with a ‘.bash’ extension and a ‘_’ prefix.  We therefore need to
ship /usr/share/bash-completion/completions/cryptdisks_start (plus a
symlink to cryptdisks_stop, or just split it) if we want autocompletion
to work out of the box.  If that's a regression it's older than
2:2.0.3-1, AFAICT stretch has the same problem.

-- 
Guilhem.


signature.asc
Description: PGP signature

Bug#949623: [pkg-cryptsetup-devel] Bug#949623: cryptsetup: cryptdisks_stop/start bash completion broken

[Christoph Anton Mitterer]

On Wed, 2020-01-22 at 22:53 +0100, Guilhem Moulin wrote:
> Did you source /usr/share/bash-completion/completions/cryptdisks?

Well not manually... I do have
if ! shopt -oq posix; then
  if [ -f /usr/share/bash-completion/bash_completion ]; then
. /usr/share/bash-completion/bash_completion
  elif [ -f /etc/bash_completion ]; then
. /etc/bash_completion
  fi
fi

in .bashrc, and that's enough for all other completions... e.g. the one
for cryptsetup work (more or less).


> Is
> the TABFILE environment variable set to something else than your
> normal
> crypttab(5)?

It's unset.


Thanks,
Chris.

Bug#949623: [pkg-cryptsetup-devel] Bug#949623: cryptsetup: cryptdisks_stop/start bash completion broken

[Guilhem Moulin]

Control: tag -1 moreinfo

On Wed, 22 Jan 2020 at 22:31:49 +0100, Christoph Anton Mitterer wrote:
> Instead of possible device target names it just completes to
> the files of the local directories.

Works fine here, also as non-root.  In a sid chroot:

~$ dd if=/dev/zero of=/tmp/disk.img bs=1M count=64 status=none
~$ /sbin/cryptsetup luksFormat /tmp/disk.img --pbkdf-force-iterations 4 
--pbkdf-memory 32 <<>"$TABFILE"
~$ . /usr/share/bash-completion/completions/cryptdisks
~$ /usr/sbin/cryptdisks_start 
--  --readonly  -r  test_crypt
~$ /usr/sbin/cryptdisks_stop 

Did you source /usr/share/bash-completion/completions/cryptdisks?  Is
the TABFILE environment variable set to something else than your normal
crypttab(5)?

-- 
Guilhem.


signature.asc
Description: PGP signature

Bug#949623: cryptsetup: cryptdisks_stop/start bash completion broken

[Christoph Anton Mitterer]

Source: cryptsetup
Version: 2:2.2.2-2
Severity: normal


Hi.

I think since "fixing" #827200 in 2:2.0.3-1 bash completion for
cryptdisks_stop/start doesn't seem to work anymore at all.

Instead of possible device target names it just completes to
the files of the local directories.

Cheers,
Chris